[Konflux] Fix Latest Releases not shown when applications field is omitted or uses wildcard patterns. (#2873)

* refactor(konflux): move glob pattern matching to konflux-common

Move globToRegex and matchesApplicationPattern from konflux-backend
to konflux-common so both frontend and backend can reuse them.

* fix(konflux): show releases when applications field is omitted or uses wildcards

The frontend was requiring the applications field to be present and
non-empty, silently discarding configs when it was omitted. It was
also doing literal string matching instead of glob pattern matching.

* chore(konflux): add changesets

Add changesets with the changes made for konflux and konflux-backend
plugins.

* chore(konflux): generate api reference

Run 'yarn build:api-reports:only' to update api references.

Author: rrosatti

workspaces/konflux/.changeset/ready-clowns-juggle.md

@@ -0,0 +1,7 @@
+---
+'@red-hat-developer-hub/backstage-plugin-konflux-backend': patch
+'@red-hat-developer-hub/backstage-plugin-konflux-common': patch
+'@red-hat-developer-hub/backstage-plugin-konflux': patch
+---
+
+Bump Backstage dependencies from 1.45.2 to 1.49.4 to align with RHDH 1.10. Fix Latest Releases not shown when applications field is omitted or uses wildcard patterns.

workspaces/konflux/plugins/konflux-backend/src/helpers/kubernetes.ts

@@ -16,30 +16,9 @@
 import {
   getApplicationFromResource,
   K8sResourceCommonWithClusterInfo,
+  matchesApplicationPattern,
 } from '@red-hat-developer-hub/backstage-plugin-konflux-common';
 
-/**
- * Convert a glob pattern (e.g. "app-*", "*api*") to a RegExp
- */
-const globToRegex = (pattern: string): RegExp => {
-  const escaped = pattern.replace(/[.+^${}()|[\]\\]/g, '\\$&');
-  const regexStr = escaped.replace(/\*/g, '.*');
-  return new RegExp(`^${regexStr}$`);
-};
-
-/**
- * Check if a name matches any of the given application patterns.
- * Supports exact matches and glob patterns with "*".
- */
-export const matchesApplicationPattern = (
-  name: string,
-  patterns: string[],
-): boolean => {
-  return patterns.some(pattern =>
-    pattern.includes('*') ? globToRegex(pattern).test(name) : pattern === name,
-  );
-};
-
 /**
  * Filter resources by application names or glob patterns
  */

workspaces/konflux/plugins/konflux-common/report.api.md

@@ -87,6 +87,9 @@ export function getSubcomponentsWithFallback(
   mainEntity: Entity,
 ): Entity[];
 
+// @public
+export const globToRegex: (pattern: string) => RegExp;
+
 // @public
 export type GroupVersionKind = GroupVersionKind_2;
 
@@ -180,6 +183,12 @@ export const konfluxResourceModels: {
   [key: string]: GroupVersionKind_2;
 };
 
+// @public
+export const matchesApplicationPattern: (
+  name: string,
+  patterns: string[],
+) => boolean;
+
 // @public (undocumented)
 export enum ModelsPlural {
   // (undocumented)

workspaces/konflux/plugins/konflux-common/src/__tests__/patterns.test.ts

@@ -0,0 +1,95 @@
+/*
+ * Copyright Red Hat, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { globToRegex, matchesApplicationPattern } from '../patterns';
+
+describe('globToRegex', () => {
+  it('should match exact string when no wildcard', () => {
+    const regex = globToRegex('my-app');
+    expect(regex.test('my-app')).toBe(true);
+    expect(regex.test('my-app-extra')).toBe(false);
+    expect(regex.test('prefix-my-app')).toBe(false);
+  });
+
+  it('should match prefix wildcard', () => {
+    const regex = globToRegex('my-app-*');
+    expect(regex.test('my-app-frontend')).toBe(true);
+    expect(regex.test('my-app-backend')).toBe(true);
+    expect(regex.test('my-app-')).toBe(true);
+    expect(regex.test('other-app')).toBe(false);
+  });
+
+  it('should match suffix wildcard', () => {
+    const regex = globToRegex('*-backend');
+    expect(regex.test('my-app-backend')).toBe(true);
+    expect(regex.test('other-backend')).toBe(true);
+    expect(regex.test('backend')).toBe(false);
+    expect(regex.test('my-app-frontend')).toBe(false);
+  });
+
+  it('should match contains wildcard', () => {
+    const regex = globToRegex('*-api-*');
+    expect(regex.test('my-api-service')).toBe(true);
+    expect(regex.test('test-api-backend')).toBe(true);
+    expect(regex.test('my-app')).toBe(false);
+  });
+
+  it('should match all with single wildcard', () => {
+    const regex = globToRegex('*');
+    expect(regex.test('anything')).toBe(true);
+    expect(regex.test('')).toBe(true);
+  });
+
+  it('should escape regex special characters', () => {
+    const regex = globToRegex('my.app*');
+    expect(regex.test('my.app-frontend')).toBe(true);
+    expect(regex.test('myXapp-frontend')).toBe(false);
+  });
+});
+
+describe('matchesApplicationPattern', () => {
+  it('should match exact names', () => {
+    expect(matchesApplicationPattern('app1', ['app1', 'app2'])).toBe(true);
+    expect(matchesApplicationPattern('app3', ['app1', 'app2'])).toBe(false);
+  });
+
+  it('should match glob patterns', () => {
+    expect(matchesApplicationPattern('my-app-frontend', ['my-app-*'])).toBe(
+      true,
+    );
+    expect(matchesApplicationPattern('other-app', ['my-app-*'])).toBe(false);
+  });
+
+  it('should match mix of exact and glob patterns', () => {
+    expect(
+      matchesApplicationPattern('special-app', ['my-app-*', 'special-app']),
+    ).toBe(true);
+    expect(
+      matchesApplicationPattern('my-app-backend', ['my-app-*', 'special-app']),
+    ).toBe(true);
+    expect(
+      matchesApplicationPattern('other-app', ['my-app-*', 'special-app']),
+    ).toBe(false);
+  });
+
+  it('should return false for empty patterns', () => {
+    expect(matchesApplicationPattern('app1', [])).toBe(false);
+  });
+
+  it('should be case sensitive', () => {
+    expect(matchesApplicationPattern('App1', ['app1'])).toBe(false);
+  });
+});

workspaces/konflux/plugins/konflux-common/src/index.ts

@@ -85,3 +85,5 @@ export { PipelineRunLabel } from './pipeline-runs';
 export { getApplicationFromResource } from './resources';
 
 export { getSubcomponentsWithFallback, getSubcomponentNames } from './entities';
+
+export { globToRegex, matchesApplicationPattern } from './patterns';

workspaces/konflux/plugins/konflux-common/src/patterns.ts

@@ -0,0 +1,42 @@
+/*
+ * Copyright Red Hat, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/**
+ * Convert a glob pattern (e.g. "app-*", "*api*") to a RegExp.
+ * Only supports `*` as a wildcard character.
+ *
+ * @public
+ */
+export const globToRegex = (pattern: string): RegExp => {
+  const escaped = pattern.replace(/[.+^${}()|[\]\\]/g, '\\$&');
+  const regexStr = escaped.replace(/\*/g, '.*');
+  return new RegExp(`^${regexStr}$`);
+};
+
+/**
+ * Check if a name matches any of the given application patterns.
+ * Supports exact matches and glob patterns with "*".
+ *
+ * @public
+ */
+export const matchesApplicationPattern = (
+  name: string,
+  patterns: string[],
+): boolean => {
+  return patterns.some(pattern =>
+    pattern.includes('*') ? globToRegex(pattern).test(name) : pattern === name,
+  );
+};

workspaces/konflux/plugins/konflux/src/components/List/LatestReleasesList/utils.ts

@@ -16,6 +16,7 @@
 
 import {
   getApplicationFromResource,
+  matchesApplicationPattern,
   ReleaseResource,
   SubcomponentClusterConfig,
 } from '@red-hat-developer-hub/backstage-plugin-konflux-common';
@@ -40,16 +41,19 @@ export const getLatestRelease = (
       config.namespace === namespace,
   );
 
-  // get all applications from matching configs
-  const appNames = new Set(
-    matchingConfigs.flatMap(config => config.applications),
+  // get all application patterns from matching configs
+  const appPatterns = matchingConfigs.flatMap(
+    config => config.applications ?? [],
   );
+  const fetchesAll = appPatterns.length === 0 || appPatterns.includes('*');
 
   const filteredReleases = releases.filter(release => {
     const applicationName = getApplicationFromResource(release) || '';
+    const matchesApp =
+      fetchesAll || matchesApplicationPattern(applicationName, appPatterns);
     return (
       release.subcomponent?.name === subcomponent &&
-      appNames.has(applicationName) &&
+      matchesApp &&
       release.cluster.name === cluster &&
       release.metadata?.namespace === namespace
     );

workspaces/konflux/plugins/konflux/src/hooks/useEntitiesKonfluxConfig.ts

@@ -50,17 +50,12 @@ export const useEntitiesKonfluxConfig = ():
           const subcomponentName = e.metadata.name;
           clustersParsedYaml.forEach(clusterConfig => {
             // filter out invalid configs (missing required fields)
-            if (
-              clusterConfig.cluster &&
-              clusterConfig.namespace &&
-              clusterConfig.applications &&
-              clusterConfig.applications.length > 0
-            ) {
+            if (clusterConfig.cluster && clusterConfig.namespace) {
               subcomponentConfigs.push({
                 subcomponent: subcomponentName,
                 cluster: clusterConfig.cluster,
                 namespace: clusterConfig.namespace,
-                applications: clusterConfig.applications,
+                applications: clusterConfig.applications || [],
               });
             }
           });