test(lightspeed): MCP servers e2e — mocked API, scenarios, en-only suite (#2724)

* test(lightspeed): e2e MCP settings across display modes

Add Chatbot MCP settings describe with Overlay, Dock, and Fullscreen coverage.
Introduce POM helpers (open/close panel, verifyMcpSettingsPanel) and extend
display-mode menu snapshot for MCP settings. Scope MCP table locators to avoid
strict-mode clashes with the catalog; avoid form-only assertions in fullscreen.

Made-with: Cursor

* test(lightspeed): MCP servers e2e mocks, scenarios, and en-only suite

- Mock GET /api/lightspeed/mcp-servers in devMode with replaceable scenarios
- Add mcpServerMocks fixtures, presets, and status-detail helper for assertions
- Extend verifyMcpSettingsPanel and heading helpers; scope MCP table actions
- Add two-server and empty-list tests; runMcpPanelScenario helper
- skipUnlessLocales: run Chatbot MCP settings e2e only on en project

Made-with: Cursor

* test(lightspeed): MCP e2e — PATCH mock, toggle, Name sort, helpers

- mockMcpServers: handle PATCH for enable/disable; broaden route glob
- LightspeedPage: mcpServersTableBodyRows, click Name/Status columns, gridcell toggle
- tests: toggle row Disabled/14 tools; Name column sort order (allHealthy)

Made-with: Cursor

* test(lightspeed): MCP e2e — crisper titles, status helper cleanup

- Rename Chatbot MCP settings tests; Sort / Toggle 'works as expected'
- Simplify getExpectedMcpStatusDetailForMock (early returns)

Made-with: Cursor

---------

Co-authored-by: HusneShabbir <husneshabbir447@gmail.com>

Author: HusneShabbir

workspaces/lightspeed/packages/app-legacy/e2e-tests/fixtures/mcpServerMocks.ts

@@ -0,0 +1,157 @@
+/*
+ * Copyright Red Hat, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/**
+ * GET /api/lightspeed/mcp-servers body shape (see McpServersSettings McpServerResponse).
+ * Use {@link mcpServer} for defaults; override fields per scenario.
+ */
+export type McpServerMockEntry = {
+  name: string;
+  /** Optional — some backends send it; not shown in the MCP table name/status cells. */
+  url?: string;
+  enabled: boolean;
+  status: 'connected' | 'error' | 'unknown';
+  toolCount: number;
+  hasToken: boolean;
+  hasUserToken: boolean;
+};
+
+export type McpServersListMock = {
+  servers: McpServerMockEntry[];
+};
+
+/** Build one entry; defaults match a healthy connected server. */
+export function mcpServer(
+  name: string,
+  overrides: Partial<Omit<McpServerMockEntry, 'name'>> = {},
+): McpServerMockEntry {
+  return {
+    name,
+    enabled: true,
+    status: 'connected',
+    toolCount: 0,
+    hasToken: true,
+    hasUserToken: false,
+    ...overrides,
+  };
+}
+
+/**
+ * Expected Status column text for a mock row — mirrors McpServersSettings getDisplayStatus +
+ * getDisplayDetail.
+ */
+export function getExpectedMcpStatusDetailForMock(
+  server: McpServerMockEntry,
+): string {
+  // Same branch order as McpServersSettings getDisplayStatus + getDisplayDetail.
+  if (!server.hasToken) return 'Token required';
+  if (!server.enabled) return 'Disabled';
+  if (server.status === 'error') return 'Failed';
+  if (server.status === 'unknown') return 'Unknown';
+  const suffix = server.toolCount === 1 ? 'tool' : 'tools';
+  return `${server.toolCount} ${suffix}`;
+}
+
+/** Named presets for Playwright `mockMcpServers(page, scenario)` and panel assertions. */
+export const mcpServerScenarios = {
+  /** Default e2e: connected + tools + second row token-required. */
+  default: {
+    servers: [
+      {
+        name: 'mcp-integration-tools',
+        url: 'http://localhost:7008/api/mcp-actions/v1',
+        enabled: true,
+        status: 'connected' as const,
+        toolCount: 14,
+        hasToken: true,
+        hasUserToken: false,
+      },
+      {
+        name: 'test-mcp-server',
+        url: 'http://localhost:8888/mcp',
+        enabled: true,
+        status: 'unknown' as const,
+        toolCount: 0,
+        hasToken: false,
+        hasUserToken: false,
+      },
+    ],
+  } satisfies McpServersListMock,
+
+  empty: { servers: [] } satisfies McpServersListMock,
+
+  allHealthy: {
+    servers: [
+      mcpServer('alpha-mcp', { toolCount: 3 }),
+      mcpServer('beta-mcp', { toolCount: 27 }),
+    ],
+  } satisfies McpServersListMock,
+
+  /** Single row — exercises "1 tool" (singular) copy. */
+  singularTool: {
+    servers: [mcpServer('single-tool-server', { toolCount: 1 })],
+  } satisfies McpServersListMock,
+
+  /** One failed row + one ok row. */
+  errorAndOk: {
+    servers: [
+      mcpServer('failing-mcp', { status: 'error', toolCount: 0 }),
+      mcpServer('ok-mcp', { toolCount: 5 }),
+    ],
+  } satisfies McpServersListMock,
+
+  /** Disabled row still lists toolCount in model but UI shows "Disabled". */
+  disabledAndOk: {
+    servers: [
+      mcpServer('disabled-mcp', { enabled: false, toolCount: 12 }),
+      mcpServer('active-mcp', { toolCount: 2 }),
+    ],
+  } satisfies McpServersListMock,
+
+  /** Both rows require a token — header shows "0 of 2 selected". */
+  twoTokenRequired: {
+    servers: [
+      mcpServer('needs-token-a', {
+        hasToken: false,
+        toolCount: 0,
+        status: 'unknown',
+      }),
+      mcpServer('needs-token-b', {
+        hasToken: false,
+        toolCount: 0,
+        status: 'unknown',
+      }),
+    ],
+  } satisfies McpServersListMock,
+
+  /** Connected + token + unknown API status → "Unknown" in Status column. */
+  unknownStatus: {
+    servers: [mcpServer('ambiguous-mcp', { status: 'unknown', toolCount: 99 })],
+  } satisfies McpServersListMock,
+
+  onlyTokenRequired: {
+    servers: [
+      mcpServer('needs-token', {
+        hasToken: false,
+        toolCount: 0,
+        status: 'unknown',
+      }),
+    ],
+  } satisfies McpServersListMock,
+};
+
+export const mockedMcpServersResponse: McpServersListMock =
+  mcpServerScenarios.default;

workspaces/lightspeed/packages/app-legacy/e2e-tests/fixtures/responses.ts

@@ -92,6 +92,15 @@ export const mockedShields = [
     provider_resource_id: 'test-shield-id',
   },
 ];
+
+export {
+  getExpectedMcpStatusDetailForMock,
+  mcpServer,
+  mcpServerScenarios,
+  mockedMcpServersResponse,
+  type McpServerMockEntry,
+  type McpServersListMock,
+} from './mcpServerMocks';
 const repeatedSentence =
   'OpenShift deployment is a way to manage applications on the OpenShift platform.';
 const openshiftLongParagraph = `${repeatedSentence} `.repeat(30);

workspaces/lightspeed/packages/app-legacy/e2e-tests/lightspeed.test.ts

@@ -23,6 +23,8 @@ import {
   botResponse,
   moreConversations,
   mockedShields,
+  mcpServerScenarios,
+  type McpServersListMock,
   thinkingContent,
   assistantResponse,
 } from './fixtures/responses';
@@ -48,7 +50,15 @@ import {
   expectEmptyChatHistory,
   expectConversationArea,
   chatStopButton,
+  verifyMcpSettingsPanel,
   waitForChatMessageLoadingHidden,
+  openMcpSettingsPanel,
+  closeMcpSettingsPanel,
+  mcpServerToggle,
+  mcpServerRow,
+  clickMcpServersStatusColumn,
+  clickMcpServersNameColumn,
+  mcpServersTableBodyRows,
 } from './pages/LightspeedPage';
 import {
   uploadFiles,
@@ -109,6 +119,7 @@ import {
   mockChatHistory,
   mockConversations,
   mockFeedbackStatus,
+  mockMcpServers,
   mockModels,
   mockQuery,
   mockQueryWithResponseDelay,
@@ -120,6 +131,7 @@ import {
   getTranslations,
 } from './utils/translations';
 import { runAccessibilityTests } from './utils/accessibility';
+import { skipUnlessLocales } from './utils/localeSkip';
 
 test.describe('Lightspeed tests', () => {
   const botQuery = 'Please respond';
@@ -138,6 +150,7 @@ test.describe('Lightspeed tests', () => {
     await mockChatHistory(sharedPage);
     await mockQuery(sharedPage, botQuery, conversations);
     await mockShields(sharedPage, mockedShields);
+    await mockMcpServers(sharedPage);
     await mockFeedbackStatus(sharedPage);
 
     await sharedPage.goto('/');
@@ -192,8 +205,103 @@ test.describe('Lightspeed tests', () => {
     });
   });
 
+  test.describe('Chatbot MCP settings', () => {
+    /** Applies mock + opens chatbot + runs panel assertions (single source for `mcpList` vs mock). */
+    async function runMcpPanelScenario(mcpList: McpServersListMock) {
+      await mockMcpServers(sharedPage, mcpList);
+      await openChatbot(sharedPage);
+      await verifyMcpSettingsPanel(sharedPage, translations, mcpList);
+    }
+
+    test.beforeEach(async ({}, testInfo) => {
+      skipUnlessLocales(
+        testInfo,
+        ['en'],
+        'Chatbot MCP settings uses English-only UI strings.',
+      );
+      await sharedPage.goto('/');
+    });
+
+    test.afterEach(async () => {
+      await mockMcpServers(sharedPage);
+    });
+
+    test('Overlay', async () => {
+      await expectBackstagePageVisible(sharedPage);
+      await openChatbot(sharedPage);
+      await verifyMcpSettingsPanel(sharedPage, translations);
+    });
+
+    test('Dock to Window', async () => {
+      await openChatbot(sharedPage);
+      await selectDisplayMode(sharedPage, translations, 'Dock to window');
+      await verifyMcpSettingsPanel(sharedPage, translations);
+    });
+
+    test('Fullscreen', async () => {
+      await openChatbot(sharedPage);
+      await selectDisplayMode(sharedPage, translations, 'Fullscreen');
+      await verifyMcpSettingsPanel(sharedPage, translations);
+    });
+
+    test('Empty list', async () => {
+      await runMcpPanelScenario(mcpServerScenarios.empty);
+    });
+
+    test.describe('Two-row mocks', () => {
+      test('All healthy', async () => {
+        await runMcpPanelScenario(mcpServerScenarios.allHealthy);
+      });
+
+      test('Failed + OK', async () => {
+        await runMcpPanelScenario(mcpServerScenarios.errorAndOk);
+      });
+
+      test('Disabled + active', async () => {
+        await runMcpPanelScenario(mcpServerScenarios.disabledAndOk);
+      });
+
+      test('Both need token', async () => {
+        await runMcpPanelScenario(mcpServerScenarios.twoTokenRequired);
+      });
+    });
+
+    test('Sort works as expected', async () => {
+      await mockMcpServers(sharedPage, mcpServerScenarios.allHealthy);
+      await openChatbot(sharedPage);
+      await openMcpSettingsPanel(sharedPage, translations);
+
+      const rows = mcpServersTableBodyRows(sharedPage);
+      await expect(rows.nth(0)).toContainText('alpha-mcp');
+      await expect(rows.nth(1)).toContainText('beta-mcp');
+
+      await clickMcpServersNameColumn(sharedPage);
+      await expect(rows.nth(0)).toContainText('beta-mcp');
+      await expect(rows.nth(1)).toContainText('alpha-mcp');
+
+      await closeMcpSettingsPanel(sharedPage);
+    });
+
+    test('Toggle works as expected', async () => {
+      const serverName = 'mcp-integration-tools';
+      await openChatbot(sharedPage);
+      await openMcpSettingsPanel(sharedPage, translations);
+
+      const row = mcpServerRow(sharedPage, serverName);
+      await clickMcpServersStatusColumn(sharedPage);
+      await mcpServerToggle(sharedPage, serverName).click();
+      await expect(row.getByText('Disabled', { exact: true })).toBeVisible();
+
+      await mcpServerToggle(sharedPage, serverName).click();
+      await expect(row.getByText('14 tools', { exact: true })).toBeVisible();
+
+      await closeMcpSettingsPanel(sharedPage);
+    });
+  });
+
   test('Lightspeed is available', async ({ browser }, testInfo) => {
-    expect(sharedPage.url()).toContain('/lightspeed');
+    await openLightspeed(sharedPage);
+    await expect(sharedPage).toHaveURL(/\/lightspeed/);
 
     const headings = sharedPage.getByRole('heading');
     await expect(headings.first()).toContainText(