fix(orchestrator-form): Review step with empty form data (#2834)

Empty pruned form data (e.g. display-only ActiveText) made generateReviewTableData return undefined and NestedReviewTable throw. Return {} from generateReviewTableData and guard NestedReviewTable. Add regression test and changeset.

Made-with: Cursor

Author: lokanandaprabhu

workspaces/orchestrator/.changeset/fix-review-empty-formdata.md

@@ -0,0 +1,5 @@
+---
+'@red-hat-developer-hub/backstage-plugin-orchestrator-form-react': patch
+---
+
+fix: avoid Review step crash when form data is empty (for example display-only `ActiveText` with no submitted values). `generateReviewTableData` returns `{}` instead of undefined, and `NestedReviewTable` handles missing data.

workspaces/orchestrator/plugins/orchestrator-form-react/src/components/NestedReviewTable.tsx

@@ -123,9 +123,10 @@ export const NestedReviewTable: React.FC<NestedReviewTableProps> = ({
   data,
 }) => {
   const { classes } = useStyles();
+  const safeData = data ?? {};
 
   // Group top-level sections
-  const sections: [string, JsonValue][] = Object.entries(data).filter(
+  const sections: [string, JsonValue][] = Object.entries(safeData).filter(
     ([_, value]) => value !== undefined,
   ) as [string, JsonValue][];
 

workspaces/orchestrator/plugins/orchestrator-form-react/src/utils/generateReviewTableData.test.ts

@@ -351,4 +351,21 @@ describe('mapSchemaToData', () => {
     const result = generateReviewTableData(schema, data);
     expect(result).toEqual(expectedResult);
   });
+
+  it('returns an empty object when form data is empty (e.g. display-only ActiveText)', () => {
+    const schema: JSONSchema7 = {
+      type: 'object',
+      title: 'Access request',
+      properties: {
+        infoMessage: {
+          type: 'string',
+          title: 'Info',
+          'ui:widget': 'ActiveText',
+        } as JSONSchema7,
+      },
+    };
+
+    const result = generateReviewTableData(schema, {});
+    expect(result).toEqual({});
+  });
 });

workspaces/orchestrator/plugins/orchestrator-form-react/src/utils/generateReviewTableData.ts

@@ -107,7 +107,8 @@ function generateReviewTableData(
     data,
     options?.includeHiddenFields ?? false,
   );
-  return result[''] as JsonObject;
+  const root = result[''] as JsonObject | undefined;
+  return root ?? {};
 }
 
 export default generateReviewTableData;