fix(scorecard): Enable sorting for all columns in entities table (#2648)

Author: Eswaraiahsapram

workspaces/scorecard/.changeset/chilly-eyes-serve.md

@@ -0,0 +1,5 @@
+---
+'@red-hat-developer-hub/backstage-plugin-scorecard': patch
+---
+
+Enable sorting for all other columns in entities table

workspaces/scorecard/plugins/scorecard/src/components/ScorecardPage/EntitiesTable/__tests__/EntitiesTableHeader.test.tsx

@@ -90,4 +90,45 @@ describe('EntitiesTableHeader', () => {
     });
     expect(sortLabel).toBeInTheDocument();
   });
+
+  it('should call onSortRequest with the correct column id when a different sortable header is clicked', async () => {
+    const onSortRequest = jest.fn();
+    render(
+      <table>
+        <EntitiesTableHeader {...defaultProps} onSortRequest={onSortRequest} />
+      </table>,
+    );
+
+    await userEvent.click(
+      screen.getByText('entitiesPage.entitiesTable.header.entity'),
+    );
+    expect(onSortRequest).toHaveBeenCalledWith('entityName');
+
+    await userEvent.click(
+      screen.getByText('entitiesPage.entitiesTable.header.lastUpdated'),
+    );
+    expect(onSortRequest).toHaveBeenCalledWith('timestamp');
+  });
+
+  it('should call onSortRequest again when clicking the already-active sorted column', async () => {
+    const onSortRequest = jest.fn();
+    render(
+      <table>
+        <EntitiesTableHeader
+          orderBy="status"
+          order="asc"
+          onSortRequest={onSortRequest}
+        />
+      </table>,
+    );
+
+    const metricHeader = screen.getByText(
+      'entitiesPage.entitiesTable.header.metric',
+    );
+    await userEvent.click(metricHeader);
+    await userEvent.click(metricHeader);
+
+    expect(onSortRequest).toHaveBeenCalledTimes(2);
+    expect(onSortRequest).toHaveBeenCalledWith('status');
+  });
 });

workspaces/scorecard/plugins/scorecard/src/utils/constants.ts

@@ -37,30 +37,30 @@ export const SCORECARD_ENTITIES_TABLE_HEADERS: readonly HeadCell[] = [
     id: 'metricValue',
     label: 'entitiesPage.entitiesTable.header.value',
     width: '8%',
-    sortable: false,
+    sortable: true,
   },
   {
     id: 'entityName',
     label: 'entitiesPage.entitiesTable.header.entity',
     width: '28%',
-    sortable: false,
+    sortable: true,
   },
   {
     id: 'owner',
     label: 'entitiesPage.entitiesTable.header.owner',
     width: '20%',
-    sortable: false,
+    sortable: true,
   },
   {
     id: 'entityKind',
     label: 'entitiesPage.entitiesTable.header.kind',
     width: '12%',
-    sortable: false,
+    sortable: true,
   },
   {
     id: 'timestamp',
     label: 'entitiesPage.entitiesTable.header.lastUpdated',
     width: '20%',
-    sortable: false,
+    sortable: true,
   },
 ];