fix(lightspeed): cleanup e2e tests and remove non-dev mode logic (#2259)

* fix(lightspeed): cleanup e2e tests and remove non-dev mode logic

- Remove non-dev mode conditional logic from tests (always use mocks)
- Fix i18n support for aria snapshots in verify default prompts test
- Update login helper to wait for page load
- Remove devMode parameter from helper functions
- Simplify models import (remove alias)
- Add fr project to playwright config

* fix(lightspeed): use generic files for multiple file upload test

- Remove locale-specific upload fixture files (en, fr)
- Use existing package.json files instead for multiple file upload test
- Delete empty uploads fixture folder

* fix(lightspeed): revert generic files and add it/ja upload fixtures

---------

Co-authored-by: HusneShabbir <husneshabbir447@gmail.com>

Author: HusneShabbir

workspaces/lightspeed/packages/app/e2e-tests/fixtures/uploads/it.upload1.json

@@ -0,0 +1,4 @@
+{
+  "lang": "it",
+  "number": 1
+}

workspaces/lightspeed/packages/app/e2e-tests/fixtures/uploads/it.upload2.json

@@ -0,0 +1,4 @@
+{
+  "lang": "it",
+  "number": 2
+}

workspaces/lightspeed/packages/app/e2e-tests/fixtures/uploads/ja.upload1.json

@@ -0,0 +1,4 @@
+{
+  "lang": "ja",
+  "number": 1
+}

workspaces/lightspeed/packages/app/e2e-tests/fixtures/uploads/ja.upload2.json

@@ -0,0 +1,4 @@
+{
+  "lang": "ja",
+  "number": 2
+}

workspaces/lightspeed/packages/app/e2e-tests/lightspeed.test.ts

@@ -16,7 +16,7 @@
 
 import { test, expect, Page } from '@playwright/test';
 import {
-  models as fakeModels,
+  models,
   conversations,
   contents,
   demoChatContent,
@@ -118,8 +118,6 @@ import { runAccessibilityTests } from './utils/accessibility';
 
 test.describe('Lightspeed tests', () => {
   const botQuery = 'Please respond';
-  const devMode = !process.env.PLAYWRIGHT_URL;
-  let models = fakeModels;
   let translations: LightspeedMessages;
   let sharedPage: Page;
   let locale: string;
@@ -130,21 +128,12 @@ test.describe('Lightspeed tests', () => {
     locale = await sharedPage.evaluate(() => globalThis.navigator.language);
     translations = getTranslations(locale);
 
-    if (!devMode) {
-      const response = await fetch(`${process.env.LIGHTSPEED_URL}/models`, {
-        headers: {
-          Authorization: `Bearer ${process.env.LIGHTSPEED_API_KEY}`,
-        },
-      });
-      models = (await response.json()).data;
-    } else {
-      await mockModels(sharedPage, models);
-      await mockConversations(sharedPage);
-      await mockChatHistory(sharedPage);
-      await mockQuery(sharedPage, botQuery, conversations);
-      await mockShields(sharedPage, mockedShields);
-      await mockFeedbackStatus(sharedPage);
-    }
+    await mockModels(sharedPage, models);
+    await mockConversations(sharedPage);
+    await mockChatHistory(sharedPage);
+    await mockQuery(sharedPage, botQuery, conversations);
+    await mockShields(sharedPage, mockedShields);
+    await mockFeedbackStatus(sharedPage);
 
     await sharedPage.goto('/');
     await login(sharedPage, process.env.RHDH_USER, process.env.RHDH_PASSWORD);
@@ -200,11 +189,6 @@ test.describe('Lightspeed tests', () => {
 
   test('Lightspeed is available', async ({ browser }, testInfo) => {
     expect(sharedPage.url()).toContain('/lightspeed');
-    if (devMode) {
-      expect(await sharedPage.title()).toContain(
-        translations['chatbox.header.title'],
-      );
-    }
 
     const headings = sharedPage.getByRole('heading');
     await expect(headings.first()).toContainText(
@@ -241,7 +225,7 @@ test.describe('Lightspeed tests', () => {
     browser,
   }, testInfo) => {
     await test.step('Verify initial state of sidebar', async () => {
-      await assertChatDialogInitialState(sharedPage, translations, devMode);
+      await assertChatDialogInitialState(sharedPage, translations);
     });
 
     await test.step('Close the sidebar and verify elements are hidden', async () => {
@@ -257,15 +241,22 @@ test.describe('Lightspeed tests', () => {
   });
 
   test('verify default prompts are visible', async () => {
+    const greeting = evaluateMessage(
+      translations['chatbox.welcome.greeting'],
+      translations['user.guest'],
+    );
     await expect(sharedPage.getByLabel('Scrollable message log'))
       .toMatchAriaSnapshot(`
-      - heading /${evaluateMessage(translations['chatbox.welcome.greeting'], '')}.+ ${translations['chatbox.welcome.description']}/ [level=1]
-      - button 
-      - text: ''
-      - button 
-      - text: ''
-      - button 
-      - text: ''
+      - region "Scrollable message log":
+        - 'heading "Info alert: ${translations['aria.important']}" [level=4]'
+        - text: ${translations['disclaimer.withValidation']}
+        - heading "${greeting} ${translations['chatbox.welcome.description']}" [level=1]
+        - button /.+/
+        - text: /.+/
+        - button /.+/
+        - text: /.+/
+        - button /.+/
+        - text: /.+/
     `);
     const messageLog = sharedPage.locator('div.pf-v6-c-card__title-text');
     const textContents = await messageLog.allTextContents();
@@ -333,14 +324,11 @@ test.describe('Lightspeed tests', () => {
     });
   });
 
-  const describeFn = devMode ? test.describe : test.describe.serial;
-  describeFn('Conversation', () => {
-    if (devMode) {
-      test.beforeEach(async () => {
-        await mockConversations(sharedPage, conversations, true);
-        await mockChatHistory(sharedPage, contents);
-      });
-    }
+  test.describe('Conversation', () => {
+    test.beforeEach(async () => {
+      await mockConversations(sharedPage, conversations, true);
+      await mockChatHistory(sharedPage, contents);
+    });
 
     test('Bot response, feedback submission, and copy to clipboard', async () => {
       await sendMessage(botQuery, sharedPage, translations);
@@ -352,17 +340,13 @@ test.describe('Lightspeed tests', () => {
       await expect(userMessage).toBeVisible();
       await expect(userMessage).toContainText(botQuery);
 
-      const response = devMode
-        ? botResponse
-        : `I'm the Red Hat Developer Hub Lightspeed assistant`;
-
       await expect(botMessage).toBeVisible();
-      await expect(botMessage).toContainText(response);
+      await expect(botMessage).toContainText(botResponse);
       await verifyFeedbackButtons(sharedPage);
-      await submitFeedback(sharedPage, 'Good response', devMode, translations);
-      await submitFeedback(sharedPage, 'Bad response', devMode, translations);
+      await submitFeedback(sharedPage, 'Good response', translations);
+      await submitFeedback(sharedPage, 'Bad response', translations);
       await copyButton.click();
-      await assertClipboardContains(sharedPage, response);
+      await assertClipboardContains(sharedPage, botResponse);
     });
 
     test('Conversation is created and shown in side panel', async () => {
@@ -390,17 +374,9 @@ test.describe('Lightspeed tests', () => {
     test('Verify scroll controls in Conversation', async ({
       browser,
     }, testInfo) => {
-      if (devMode) {
-        await mockChatHistory(sharedPage, demoChatContent);
-      }
+      await mockChatHistory(sharedPage, demoChatContent);
 
-      let message = demoChatContent[0].messages[0].content;
-      if (!devMode) {
-        message =
-          (await sharedPage
-            .locator('.pf-v6-c-card__body', { hasText: 'Tekton' })
-            .textContent()) || '';
-      }
+      const message = demoChatContent[0].messages[0].content;
       await sendMessage(message, sharedPage, translations, false);
 
       const jumpTopButton = sharedPage.getByRole('button', {
@@ -422,44 +398,28 @@ test.describe('Lightspeed tests', () => {
       await expect(jumpBottomButton).toBeVisible();
       await jumpBottomButton.click();
 
-      const responseText = devMode ? /OpenShift deployment/ : /Tekton/;
       const responseMessage = sharedPage
         .locator('div.pf-chatbot__message-response')
         .last();
-      await expect(responseMessage).toHaveText(responseText);
+      await expect(responseMessage).toHaveText(/OpenShift deployment/);
     });
 
     test('Filter and switch conversations', async () => {
-      if (devMode) {
-        await mockConversations(sharedPage, moreConversations);
-      }
+      await mockConversations(sharedPage, moreConversations);
       await sendMessage('test', sharedPage, translations);
       const sidePanel = sharedPage.locator('.pf-v6-c-drawer__panel-main');
 
       const currentChat = sidePanel.locator('li.pf-chatbot__menu-item--active');
-      await expect(currentChat).toHaveText(
-        devMode ? moreConversations[0].topic_summary : /<[\w\s]+topic[\w\s]*>/,
-      );
+      await expect(currentChat).toHaveText(moreConversations[0].topic_summary);
 
       const chats = sidePanel.locator('li.pf-chatbot__menu-item');
-      if (devMode) {
-        await expect(chats).toHaveCount(3);
-      } else {
-        expect(await chats.count()).toBeGreaterThanOrEqual(1);
-        await sharedPage
-          .getByRole('button', { name: translations['button.newChat'] })
-          .click();
-        await sendMessage('tell me about Backstage', sharedPage, translations);
-        await verifySidePanelConversation(sharedPage, translations);
-      }
+      await expect(chats).toHaveCount(3);
 
-      const searchText = devMode
-        ? moreConversations[1].topic_summary
-        : 'Backstage';
+      const searchText = moreConversations[1].topic_summary;
       const searchBox = sidePanel.getByPlaceholder(
         translations['chatbox.search.placeholder'],
       );
-      await searchBox.fill(devMode ? 'new' : 'Backstage');
+      await searchBox.fill('new');
       const validChat = sidePanel
         .locator('li.pf-chatbot__menu-item')
         .filter({ hasText: searchText })
@@ -479,18 +439,11 @@ test.describe('Lightspeed tests', () => {
       const userMessage = sharedPage.locator('.pf-chatbot__message--user');
       const botMessage = sharedPage.locator('.pf-chatbot__message--bot');
 
-      await expect(userMessage).toContainText(
-        devMode ? contents[0].messages[0].content : 'tell me about Backstage',
-      );
-      await expect(botMessage).toContainText(
-        devMode ? assistantResponse : 'Backstage',
-      );
+      await expect(userMessage).toContainText(contents[0].messages[0].content);
+      await expect(botMessage).toContainText(assistantResponse);
     });
 
-    const chatManagementDescribeFn = devMode
-      ? test.describe
-      : test.describe.skip;
-    chatManagementDescribeFn('Chat Management', () => {
+    test.describe('Chat Management', () => {
       const testChatName = 'Test Rename';
 
       test('Verify chat actions menu', async () => {

workspaces/lightspeed/packages/app/e2e-tests/utils/login.ts

@@ -16,7 +16,14 @@
 import { Page } from '@playwright/test';
 
 export const loginAsGuest = async (page: Page) => {
+  // Wait for the login page to be ready
+  await page
+    .getByRole('button', { name: 'Enter' })
+    .waitFor({ state: 'visible' });
   await page.getByRole('button', { name: 'Enter' }).click();
+  await page
+    .getByRole('heading', { name: 'Red Hat Catalog' })
+    .waitFor({ state: 'visible', timeout: 5000 });
 };
 
 export const keycloakLogin = async (

workspaces/lightspeed/packages/app/e2e-tests/utils/sidebar.ts

@@ -19,7 +19,6 @@ import { LightspeedMessages } from './translations';
 export async function assertChatDialogInitialState(
   page: Page,
   translations: LightspeedMessages,
-  devMode = true,
 ) {
   await expect(page.getByLabel('Chatbot', { exact: true })).toContainText(
     translations['chatbox.header.title'],
@@ -29,17 +28,15 @@ export async function assertChatDialogInitialState(
   ).toBeVisible();
   await assertDrawerState(page, 'open', translations);
 
-  if (devMode) {
-    await expect(page.getByLabel(translations['conversation.category.recent']))
-      .toMatchAriaSnapshot(`
+  await expect(page.getByLabel(translations['conversation.category.recent']))
+    .toMatchAriaSnapshot(`
       - heading "${translations['conversation.category.pinnedChats']}"
       - menu:
         - menuitem "${translations['chatbox.emptyState.noPinnedChats']}"
       - heading "${translations['conversation.category.recent']}"
       - menu:
         - menuitem "${translations['chatbox.emptyState.noRecentChats']}"
       `);
-  }
 }
 
 export async function closeChatDrawer(

workspaces/lightspeed/packages/app/e2e-tests/utils/testHelper.ts

@@ -85,7 +85,6 @@ export async function verifyFeedbackButtons(page: Page) {
 export async function submitFeedback(
   page: Page,
   ratingButtonName: string,
-  devMode: boolean,
   translations: LightspeedMessages,
 ) {
   // Click the Good/Bad response button
@@ -106,10 +105,8 @@ export async function submitFeedback(
 
   await quickFeedbackLabels.first().click();
 
-  if (devMode) {
-    // Mock API response for v1/feedback
-    await mockFeedbackReceived(page);
-  }
+  // Mock API response for v1/feedback
+  await mockFeedbackReceived(page);
 
   await feedbackCard
     .getByRole('button', { name: translations['feedback.form.submitWord'] })

workspaces/lightspeed/playwright.config.ts

@@ -61,22 +61,21 @@ export default defineConfig({
         locale: 'fr',
       },
     },
-    // TODO: Enable after translation bugs are fixed
-    // {
-    //   name: 'it',
-    //   testDir: 'packages/app/e2e-tests',
-    //   use: {
-    //     channel: 'chrome',
-    //     locale: 'it',
-    //   },
-    // },
-    // {
-    //   name: 'ja',
-    //   testDir: 'packages/app/e2e-tests',
-    //   use: {
-    //     channel: 'chrome',
-    //     locale: 'ja',
-    //   },
-    // },
+    {
+      name: 'it',
+      testDir: 'packages/app/e2e-tests',
+      use: {
+        channel: 'chrome',
+        locale: 'it',
+      },
+    },
+    {
+      name: 'ja',
+      testDir: 'packages/app/e2e-tests',
+      use: {
+        channel: 'chrome',
+        locale: 'ja',
+      },
+    },
   ],
 });