fix(global-header): update config.d.ts, update theme (#1027)

Author: logonoff

workspaces/global-header/.changeset/tidy-hairs-brush.md

@@ -0,0 +1,5 @@
+---
+'@red-hat-developer-hub/backstage-plugin-global-header': patch
+---
+
+Update config.d.ts to expect the updated app-config schema

workspaces/global-header/packages/app/package.json

@@ -51,7 +51,7 @@
     "@mui/material": "5.17.1",
     "@red-hat-developer-hub/backstage-plugin-global-header": "workspace:^",
     "@red-hat-developer-hub/backstage-plugin-global-header-test": "workspace:^",
-    "@red-hat-developer-hub/backstage-plugin-theme": "^0.9.0",
+    "@red-hat-developer-hub/backstage-plugin-theme": "^0.9.1",
     "react": "^18.0.2",
     "react-dom": "^18.0.2",
     "react-router": "^6.3.0",

workspaces/global-header/packages/app/src/components/Root/Root.tsx

@@ -121,6 +121,7 @@ export const Root = ({ children = null }: PropsWithChildren<{}>) => {
         />
       </div>
       <SidebarLayout
+        id="rhdh-sidebar-layout"
         aboveMainContentHeaderHeight={0}
         aboveSidebarHeaderHeight={64}
       >

workspaces/global-header/plugins/global-header/config.d.ts

@@ -21,10 +21,17 @@ declare module '@backstage/config' {
     app?: {
       branding?: {
         /**
-         * Base64 URI for the full logo
-         * @visibility frontend
+         * Base64 URI for the full logo. If the value is a string, it is used as the logo for both themes.
+         * @deepVisibility frontend
          */
-        fullLogo?: string;
+        fullLogo?:
+          | string
+          | {
+              /** Base64 URI for the logo in light theme */
+              light: string;
+              /** Base64 URI for the logo in dark theme */
+              dark: string;
+            };
       };
     };
   }

workspaces/global-header/plugins/global-header/package.json

@@ -68,7 +68,7 @@
     "@backstage/plugin-search-common": "^1.2.18",
     "@backstage/test-utils": "^1.7.8",
     "@openshift/dynamic-plugin-sdk": "^5.0.1",
-    "@red-hat-developer-hub/backstage-plugin-theme": "^0.9.0",
+    "@red-hat-developer-hub/backstage-plugin-theme": "^0.9.1",
     "@testing-library/jest-dom": "^6.0.0",
     "@testing-library/react": "^14.0.0",
     "@testing-library/user-event": "^14.0.0",

workspaces/global-header/yarn.lock

@@ -10938,7 +10938,7 @@ __metadata:
     "@mui/material": 5.17.1
     "@mui/styled-engine": 5.16.14
     "@openshift/dynamic-plugin-sdk": ^5.0.1
-    "@red-hat-developer-hub/backstage-plugin-theme": ^0.9.0
+    "@red-hat-developer-hub/backstage-plugin-theme": ^0.9.1
     "@scalprum/react-core": 0.9.5
     "@testing-library/jest-dom": ^6.0.0
     "@testing-library/react": ^14.0.0
@@ -10953,9 +10953,9 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@red-hat-developer-hub/backstage-plugin-theme@npm:^0.9.0":
-  version: 0.9.0
-  resolution: "@red-hat-developer-hub/backstage-plugin-theme@npm:0.9.0"
+"@red-hat-developer-hub/backstage-plugin-theme@npm:^0.9.1":
+  version: 0.9.1
+  resolution: "@red-hat-developer-hub/backstage-plugin-theme@npm:0.9.1"
   dependencies:
     "@mui/icons-material": ^5.17.1
   peerDependencies:
@@ -10965,7 +10965,7 @@ __metadata:
     "@mui/icons-material": ^5.17.1
     "@mui/material": ^5.0.0
     react: ^16.13.1 || ^17.0.0 || ^18.0.0
-  checksum: 365e81ba8af0fe38587e21bd842ede6eb6ee2d1590dbad26c3e5e6ca42c885b4e19de3cfc9435f43113f67960cf57c4614011596d4332def1bac93b9a6199860
+  checksum: 876923b59c7f7bd6cf56218004770dd5b9c34873ca0a04f7ae9b6b9cbe33214de9f867d27702045785bd865cdc7dee23277cb58711447b5859bd1dae1d4a66db
   languageName: node
   linkType: hard
 
@@ -15850,7 +15850,7 @@ __metadata:
     "@playwright/test": 1.53.0
     "@red-hat-developer-hub/backstage-plugin-global-header": "workspace:^"
     "@red-hat-developer-hub/backstage-plugin-global-header-test": "workspace:^"
-    "@red-hat-developer-hub/backstage-plugin-theme": ^0.9.0
+    "@red-hat-developer-hub/backstage-plugin-theme": ^0.9.1
     "@testing-library/dom": ^9.0.0
     "@testing-library/jest-dom": ^6.0.0
     "@testing-library/react": ^14.0.0