remove unsupported xml file type from lightspeed (#1749)

karthikjeeyar · web-flow · commit d8bb6503f81e · 2025-11-11T11:32:24.000+05:30
diff --git a/workspaces/lightspeed/.changeset/tiny-turkeys-cough.md b/workspaces/lightspeed/.changeset/tiny-turkeys-cough.md
@@ -0,0 +1,5 @@
+---
+'@red-hat-developer-hub/backstage-plugin-lightspeed': patch
+---
+
+Remove unsupported file type from lightspeed
diff --git a/workspaces/lightspeed/packages/app/e2e-tests/utils/fileUpload.ts b/workspaces/lightspeed/packages/app/e2e-tests/utils/fileUpload.ts
@@ -15,7 +15,7 @@
  */
 import { Page, Locator, FileChooser, expect } from '@playwright/test';
 
-export const supportedFileTypes = ['.txt', '.yaml', '.json', '.xml'];
+export const supportedFileTypes = ['.txt', '.yaml', '.json'];
 
 export async function triggerFileChooser(
   page: Page,
@@ -83,7 +83,7 @@ export async function validateSuccessfulUpload(page: Page, fileName: string) {
 export async function validateFailedUpload(page: Page) {
   const alertHeader = page.getByText('File upload failed');
   const alertText = page.getByText(
-    'Unsupported file type. Supported types are: .txt, .yaml, .json and .xml.',
+    'Unsupported file type. Supported types are: .txt, .yaml, and .json.',
   );
 
   await expect(alertHeader).toBeVisible();
diff --git a/workspaces/lightspeed/packages/app/e2e-tests/utils/testHelper.ts b/workspaces/lightspeed/packages/app/e2e-tests/utils/testHelper.ts
@@ -30,7 +30,7 @@ export const sendMessage = async (
   waitForResponse = true,
 ) => {
   const inputLocator = page.getByRole('textbox', {
-    name: 'Send a message and optionally upload a JSON, YAML, TXT, or XML file...',
+    name: 'Send a message and optionally upload a JSON, YAML, or TXT file...',
   });
   await inputLocator.fill(message);
   const sendButton = page.getByRole('button', { name: 'Send' });
diff --git a/workspaces/lightspeed/plugins/lightspeed/src/components/__tests__/LightspeedChat.test.tsx b/workspaces/lightspeed/plugins/lightspeed/src/components/__tests__/LightspeedChat.test.tsx
@@ -211,7 +211,7 @@ describe('LightspeedChat', () => {
     const input = screen.getByTestId('attachment-input') as HTMLInputElement;
     expect(input).toHaveAttribute(
       'accept',
-      'text/plain,.txt,application/json,.json,application/yaml,.yaml,.yml,application/xml,.xml',
+      'text/plain,.txt,application/json,.json,application/yaml,.yaml,.yml',
     );
   });
 
@@ -244,7 +244,7 @@ describe('LightspeedChat', () => {
 
     expect(
       screen.getByText(
-        'Unsupported file type. Supported types are: .txt, .yaml, .json and .xml.',
+        'Unsupported file type. Supported types are: .txt, .yaml, and .json.',
       ),
     ).toBeInTheDocument();
   });
diff --git a/workspaces/lightspeed/plugins/lightspeed/src/const.ts b/workspaces/lightspeed/plugins/lightspeed/src/const.ts
@@ -31,7 +31,6 @@ export const supportedFileTypes = {
   'text/plain': ['.txt'],
   'application/json': ['.json'],
   'application/yaml': ['.yaml', '.yml'],
-  'application/xml': ['.xml'],
 };
 
 export const DEFAULT_SAMPLE_PROMPTS: SamplePrompts = [
diff --git a/workspaces/lightspeed/plugins/lightspeed/src/translations/de.ts b/workspaces/lightspeed/plugins/lightspeed/src/translations/de.ts
@@ -108,10 +108,10 @@ const lightspeedTranslationDe = createTranslationMessages({
     'chatbox.welcome.greeting': 'Hallo, {{userName}}',
     'chatbox.welcome.description': 'Wie kann ich Ihnen heute helfen?',
     'chatbox.message.placeholder':
-      'Senden Sie eine Nachricht und laden Sie optional eine JSON-, YAML-, TXT- oder XML-Datei hoch...',
+      'Senden Sie eine Nachricht und laden Sie optional eine JSON-, YAML-, oder TXT-Datei hoch...',
     'chatbox.fileUpload.failed': 'Datei-Upload fehlgeschlagen',
     'chatbox.fileUpload.infoText':
-      'Unterstützte Dateitypen sind: .txt, .yaml, .json und .xml. Die maximale Dateigröße beträgt 25 MB.',
+      'Unterstützte Dateitypen sind: .txt, .yaml, und .json. Die maximale Dateigröße beträgt 25 MB.',
 
     // Accessibility and ARIA labels
     'aria.chatbotSelector': 'Chatbot-Auswahl',
@@ -154,7 +154,7 @@ const lightspeedTranslationDe = createTranslationMessages({
     'file.upload.error.alreadyExists': 'Die Datei existiert bereits.',
     'file.upload.error.multipleFiles': 'Mehr als eine Datei hochgeladen.',
     'file.upload.error.unsupportedType':
-      'Nicht unterstützter Dateityp. Unterstützte Typen sind: .txt, .yaml, .json und .xml.',
+      'Nicht unterstützter Dateityp. Unterstützte Typen sind: .txt, .yaml, und .json.',
     'file.upload.error.fileTooLarge':
       'Ihre Dateigröße ist zu groß. Bitte stellen Sie sicher, dass Ihre Datei kleiner als 25 MB ist.',
     'file.upload.error.readFailed':
diff --git a/workspaces/lightspeed/plugins/lightspeed/src/translations/es.ts b/workspaces/lightspeed/plugins/lightspeed/src/translations/es.ts
@@ -112,10 +112,10 @@ const lightspeedTranslationEs = createTranslationMessages({
     'chatbox.welcome.greeting': 'Hola, {{userName}}',
     'chatbox.welcome.description': '¿Cómo puedo ayudarte hoy?',
     'chatbox.message.placeholder':
-      'Envía un mensaje y opcionalmente sube un archivo JSON, YAML, TXT o XML...',
+      'Envía un mensaje y opcionalmente sube un archivo JSON, YAML, o TXT...',
     'chatbox.fileUpload.failed': 'La carga del archivo falló',
     'chatbox.fileUpload.infoText':
-      'Los tipos de archivo soportados son: .txt, .yaml, .json y .xml. El tamaño máximo del archivo es 25 MB.',
+      'Los tipos de archivo soportados son: .txt, .yaml, y .json. El tamaño máximo del archivo es 25 MB.',
 
     // Accessibility and ARIA labels
     'aria.chatbotSelector': 'Selector de chatbot',
@@ -158,7 +158,7 @@ const lightspeedTranslationEs = createTranslationMessages({
     'file.upload.error.alreadyExists': 'El archivo ya existe.',
     'file.upload.error.multipleFiles': 'Se subió más de un archivo.',
     'file.upload.error.unsupportedType':
-      'Tipo de archivo no soportado. Los tipos soportados son: .txt, .yaml, .json y .xml.',
+      'Tipo de archivo no soportado. Los tipos soportados son: .txt, .yaml, y .json.',
     'file.upload.error.fileTooLarge':
       'El tamaño de tu archivo es demasiado grande. Por favor asegúrate de que tu archivo sea menor a 25 MB.',
     'file.upload.error.readFailed':
diff --git a/workspaces/lightspeed/plugins/lightspeed/src/translations/fr.ts b/workspaces/lightspeed/plugins/lightspeed/src/translations/fr.ts
@@ -111,10 +111,10 @@ const lightspeedTranslationFr = createTranslationMessages({
     'chatbox.welcome.greeting': 'Bonjour, {{userName}}',
     'chatbox.welcome.description': "Comment puis-je vous aider aujourd'hui ?",
     'chatbox.message.placeholder':
-      'Envoyez un message et téléchargez optionnellement un fichier JSON, YAML, TXT ou XML...',
+      'Envoyez un message et téléchargez optionnellement un fichier JSON, YAML, ou TXT...',
     'chatbox.fileUpload.failed': 'Le téléchargement du fichier a échoué',
     'chatbox.fileUpload.infoText':
-      'Les types de fichiers pris en charge sont : .txt, .yaml, .json et .xml. La taille maximale du fichier est de 25 Mo.',
+      'Les types de fichiers pris en charge sont : .txt, .yaml, et .json. La taille maximale du fichier est de 25 Mo.',
 
     // Accessibility and ARIA labels
     'aria.chatbotSelector': 'Sélecteur de chatbot',
@@ -157,7 +157,7 @@ const lightspeedTranslationFr = createTranslationMessages({
     'file.upload.error.alreadyExists': 'Le fichier existe déjà.',
     'file.upload.error.multipleFiles': "Plus d'un fichier a été téléchargé.",
     'file.upload.error.unsupportedType':
-      'Type de fichier non pris en charge. Les types pris en charge sont : .txt, .yaml, .json et .xml.',
+      'Type de fichier non pris en charge. Les types pris en charge sont : .txt, .yaml, et .json.',
     'file.upload.error.fileTooLarge':
       'La taille de votre fichier est trop importante. Veuillez vous assurer que votre fichier fait moins de 25 Mo.',
     'file.upload.error.readFailed':
diff --git a/workspaces/lightspeed/plugins/lightspeed/src/translations/ref.ts b/workspaces/lightspeed/plugins/lightspeed/src/translations/ref.ts
@@ -105,10 +105,10 @@ export const lightspeedMessages = {
   'chatbox.welcome.greeting': 'Hello, {{userName}}',
   'chatbox.welcome.description': 'How can I help you today?',
   'chatbox.message.placeholder':
-    'Send a message and optionally upload a JSON, YAML, TXT, or XML file...',
+    'Send a message and optionally upload a JSON, YAML, or TXT file...',
   'chatbox.fileUpload.failed': 'File upload failed',
   'chatbox.fileUpload.infoText':
-    'Supported file types are: .txt, .yaml, .json and .xml. The maximum file size is 25 MB.',
+    'Supported file types are: .txt, .yaml, and .json. The maximum file size is 25 MB.',
 
   // Accessibility and ARIA labels
   'aria.chatbotSelector': 'Chatbot selector',
@@ -151,7 +151,7 @@ export const lightspeedMessages = {
   'file.upload.error.alreadyExists': 'File already exists.',
   'file.upload.error.multipleFiles': 'Uploaded more than one file.',
   'file.upload.error.unsupportedType':
-    'Unsupported file type. Supported types are: .txt, .yaml, .json and .xml.',
+    'Unsupported file type. Supported types are: .txt, .yaml, and .json.',
   'file.upload.error.fileTooLarge':
     'Your file size is too large. Please ensure that your file is less than 25 MB.',
   'file.upload.error.readFailed': 'Failed to read file: {{errorMessage}}',
diff --git a/workspaces/lightspeed/plugins/lightspeed/src/types.ts b/workspaces/lightspeed/plugins/lightspeed/src/types.ts
@@ -88,7 +88,6 @@ export enum SupportedFileType {
   JSON = 'application/json',
   YAML = 'application/x-yaml',
   TEXT = 'text/plain',
-  XML = 'text/xml',
 }
 export interface FileContent {
   content: string;
diff --git a/workspaces/lightspeed/plugins/lightspeed/src/utils/__tests__/attachment-utils.test.ts b/workspaces/lightspeed/plugins/lightspeed/src/utils/__tests__/attachment-utils.test.ts
@@ -50,13 +50,6 @@ describe('isSupportedFileType', () => {
     expect(isSupportedFileType(file)).toBe(true);
   });
 
-  it('should return true for XML file type', () => {
-    const xmlFile = new File(['<note>Test</note>'], 'test.xml', {
-      type: 'application/xml',
-    });
-    expect(isSupportedFileType(xmlFile)).toBe(true);
-  });
-
   it('should return false for unsupported file type', () => {
     const file = new File(['<html></html>'], 'test.html', {
       type: 'text/html',
diff --git a/workspaces/lightspeed/plugins/lightspeed/src/utils/attachment-utils.ts b/workspaces/lightspeed/plugins/lightspeed/src/utils/attachment-utils.ts
@@ -22,9 +22,8 @@ export const isSupportedFileType = (file: File) => {
     file.name.endsWith('.yaml') ||
     file.name.endsWith('.yml');
   const isText = file.type === SupportedFileType.TEXT;
-  const isXml = file.name.endsWith('.xml');
 
-  return isJson || isYaml || isText || isXml;
+  return isJson || isYaml || isText;
 };
 
 export const readFileAsText = (file: File): Promise<string | null> =>
@@ -39,8 +38,6 @@ export const sanitizeFileType = (fileContent: FileContent): string => {
   switch (fileContent.type) {
     case SupportedFileType.YAML:
       return 'application/yaml';
-    case SupportedFileType.XML:
-      return 'application/xml';
     default:
       return fileContent.type;
   }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@red-hat-developer-hub/backstage-plugin-lightspeed': patch
 +---
++
 +Remove unsupported file type from lightspeed
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,6 @@ export enum SupportedFileType {`
`88`	`88`	`JSON = 'application/json',`
`89`	`89`	`YAML = 'application/x-yaml',`
`90`	`90`	`TEXT = 'text/plain',`
`91`		`- XML = 'text/xml',`
`92`	`91`	`}`
`93`	`92`	`export interface FileContent {`
`94`	`93`	`content: string;`