Add collecting build file patterns test

Refactoring

Signed-off-by: Siarhei Leanavets <Siarhei_Leanavets1@epam.com>

Author: LeonovecSergey

src/plugin.ts

@@ -3,9 +3,9 @@
 import * as vscode from 'vscode';
 import * as path from 'path';
 import { Commands } from './commands';
-import { buildFilePatterns } from './standardLanguageClient';
 
 let existingExtensions: Array<string>;
+export let buildFilePatterns: Array<string>;
 
 export function collectJavaExtensions(extensions: readonly vscode.Extension<any>[]): string[] {
 	const result = [];
@@ -40,6 +40,7 @@ export function collectBuildFilePattern(extensions: readonly vscode.Extension<an
 			}
 		}
 	}
+	buildFilePatterns = result.slice();
 	return result;
 }
 
@@ -60,12 +61,12 @@ function isContributedPartUpdated(newContributedPart: Array<string>, oldContribu
 	if (!oldContributedPart) {
 		return false;
 	}
-	const oldExtensions = new Set(oldContributedPart.slice());
-	const newExtensions = newContributedPart;
-	const hasChanged = (oldExtensions.size !== newExtensions.length);
+	const oldContribution = new Set(oldContributedPart.slice());
+	const newContribution = newContributedPart;
+	const hasChanged = (oldContribution.size !== newContribution.length);
 	if (!hasChanged) {
-		for (const newExtension of newExtensions) {
-			if (!oldExtensions.has(newExtension)) {
+		for (const newExtension of newContribution) {
+			if (!oldContribution.has(newExtension)) {
 				return true;
 			}
 		}

src/standardLanguageClient.ts

@@ -28,10 +28,10 @@ import { markdownPreviewProvider } from "./markdownPreviewProvider";
 import { RefactorDocumentProvider, javaRefactorKinds } from "./codeActionProvider";
 import { typeHierarchyTree } from "./typeHierarchy/typeHierarchyTree";
 import { TypeHierarchyDirection, TypeHierarchyItem } from "./typeHierarchy/protocol";
+import { buildFilePatterns } from './plugin';
 
 const extensionName = 'Language Support for Java';
 const GRADLE_CHECKSUM = "gradle/checksum/prompt";
-export let buildFilePatterns: Array<string>;
 
 export class StandardLanguageClient {
 
@@ -203,7 +203,7 @@ export class StandardLanguageClient {
 		this.registerCommandsForStandardServer(context, jdtEventEmitter);
 		fileEventHandler.registerFileEventHandlers(this.languageClient, context);
 
-		buildFilePatterns = collectBuildFilePattern(extensions.all);
+		collectBuildFilePattern(extensions.all);
 
 		this.status = ClientStatus.Initialized;
 	}

test/standard-mode-suite/extension.test.ts

@@ -104,6 +104,26 @@ suite('Java Language Extension - Standard', () => {
 		assert.equal(vmArgs[2], '-Dfoo=Some "crazy" stuff');
 	});
 
+	test('should collect build file pattenrs extensions', () => {
+		const packageJSON = JSON.parse(fs.readFileSync(path.join(__dirname, '../../../test/resources/packageExample.json'), 'utf8'));
+		const fakedExtension = {
+			id: 'test',
+			extensionUri: null,
+			extensionPath: '',
+			isActive: true,
+			packageJSON,
+			exports: '',
+			activate: null,
+			extensionKind: vscode.ExtensionKind.Workspace
+		};
+
+		const extensions = [fakedExtension];
+		const result = plugin.collectBuildFilePattern(extensions);
+		assert(result.length === 2);
+		assert(result[0].endsWith("^pom.xml$"));
+		assert(result[1].endsWith(".*\\.gradle$"));
+	});
+
 	test('should collect java extensions', () => {
 		const packageJSON = JSON.parse(fs.readFileSync(path.join(__dirname, '../../../test/resources/packageExample.json'), 'utf8'));
 		const fakedExtension = {