Show the error status when imported projects having errors (#2244)

* Show project status in the status bar

Signed-off-by: sheche <sheche@microsoft.com>

Author: jdneo

src/serverStatus.ts

@@ -5,6 +5,7 @@ import { serverTasks } from "./serverTasks";
 
 export enum ServerStatusKind {
 	Ready = "Ready",
+	Warning = "Warning",
 	Error = "Error",
 	Busy = "Busy",
 }
@@ -24,6 +25,8 @@ function fireEvent() {
 
 export namespace serverStatus {
 
+	let hasError: boolean = false;
+
 	export const onServerStatusChanged = _emitter.event;
 
 	export function initialize() {
@@ -38,7 +41,21 @@ export namespace serverStatus {
 			throw new Error("Busy status cannot be set directly.");
 		}
 
+		if (status === ServerStatusKind.Error || status === ServerStatusKind.Warning) {
+			hasError = true;
+		} else if (hasError) {
+			return;
+		}
+
 		_status = status;
 		fireEvent();
 	}
+
+	export function hasErrors() {
+		return hasError;
+	}
+
+	export function errorResolved() {
+		hasError = false;
+	}
 }

src/serverStatusBarProvider.ts

@@ -55,10 +55,19 @@ class ServerStatusBarProvider implements Disposable {
 
 	public setError(): void {
 		this.statusBarItem.text = StatusIcon.Error;
+		this.statusBarItem.command = Commands.OPEN_LOGS;
+	}
+
+	public setWarning(): void {
+		this.statusBarItem.text = StatusIcon.Warning;
+		this.statusBarItem.command = "workbench.panel.markers.view.focus";
+		this.statusBarItem.tooltip = "Errors occurred in project configurations, click to show the PROBLEMS panel";
 	}
 
 	public setReady(): void {
 		this.statusBarItem.text = StatusIcon.Ready;
+		this.statusBarItem.command = Commands.SHOW_SERVER_TASK_STATUS;
+		this.statusBarItem.tooltip = "ServiceReady";
 	}
 
 	public updateTooltip(tooltip: string): void {
@@ -74,6 +83,7 @@ enum StatusIcon {
 	LightWeight = "$(rocket)",
 	Busy = "$(sync~spin)",
 	Ready = "$(thumbsup)",
+	Warning = "$(thumbsdown)",
 	Error = "$(thumbsdown)"
 }
 

src/standardLanguageClient.ts

@@ -62,6 +62,8 @@ export class StandardLanguageClient {
 				serverStatusBarProvider.setBusy();
 			} else if (status === ServerStatusKind.Error) {
 				serverStatusBarProvider.setError();
+			} else if (status === ServerStatusKind.Warning) {
+				serverStatusBarProvider.setWarning();
 			} else {
 				serverStatusBarProvider.setReady();
 			}
@@ -116,12 +118,23 @@ export class StandardLanguageClient {
 						apiManager.updateStatus(ClientStatus.Error);
 						resolve(apiManager.getApiInstance());
 						break;
+					case 'ProjectStatus':
+						if (report.message === "WARNING") {
+							serverStatus.updateServerStatus(ServerStatusKind.Warning);
+						} else if (report.message === "OK") {
+							this.status = ClientStatus.Started;
+							serverStatus.errorResolved();
+							serverStatus.updateServerStatus(ServerStatusKind.Ready);
+						}
+						return;
 					case 'Starting':
 					case 'Message':
 						// message goes to progress report instead
 						break;
 				}
-				serverStatusBarProvider.updateTooltip(report.message);
+				if (!serverStatus.hasErrors()) {
+					serverStatusBarProvider.updateTooltip(report.message);
+				}
 			});
 
 			this.languageClient.onNotification(ProgressReportNotification.type, (progress) => {
@@ -453,22 +466,31 @@ export class StandardLanguageClient {
 async function showImportFinishNotification(context: ExtensionContext) {
 	const neverShow: boolean | undefined = context.globalState.get<boolean>("java.neverShowImportFinishNotification");
 	if (!neverShow) {
-		const projectUris: string[] = await commands.executeCommand<string[]>(Commands.EXECUTE_WORKSPACE_COMMAND, Commands.GET_ALL_JAVA_PROJECTS);
-		if (projectUris.length === 0 || (projectUris.length === 1 && projectUris[0].includes("jdt.ls-java-project"))) {
-			return;
+		let choice: string | undefined;
+		const options = ["Don't show again"];
+		if (serverStatus.hasErrors()) {
+			options.unshift("Show errors");
+			choice = await window.showWarningMessage("Errors occurred during import of Java projects.", ...options);
+		} else {
+			const projectUris: string[] = await commands.executeCommand<string[]>(Commands.EXECUTE_WORKSPACE_COMMAND, Commands.GET_ALL_JAVA_PROJECTS);
+			if (projectUris.length === 0 || (projectUris.length === 1 && projectUris[0].includes("jdt.ls-java-project"))) {
+				return;
+			}
+
+			if (extensions.getExtension("vscjava.vscode-java-dependency")) {
+				options.unshift("View projects");
+			}
+
+			choice = await window.showInformationMessage("Projects are imported into workspace.", ...options);
 		}
 
-		const options = ["Don't show again"];
-		if (extensions.getExtension("vscjava.vscode-java-dependency")) {
-			options.unshift("View projects");
+		if (choice === "Don't show again") {
+			context.globalState.update("java.neverShowImportFinishNotification", true);
+		} else if (choice === "View projects") {
+			commands.executeCommand("javaProjectExplorer.focus");
+		} else if (choice === "Show errors") {
+			commands.executeCommand("workbench.panel.markers.view.focus");
 		}
-		window.showInformationMessage("Projects are imported into workspace.", ...options).then((choice) => {
-			if (choice === "Don't show again") {
-				context.globalState.update("java.neverShowImportFinishNotification", true);
-			} else if (choice === "View projects") {
-				commands.executeCommand("javaProjectExplorer.focus");
-			}
-		});
 	}
 }