Enable Source Action: Generate Constructors

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

Author: testforstephen

src/commands.ts

@@ -130,4 +130,8 @@ export namespace Commands {
      * Generate Getters and Setters.
      */
     export const GENERATE_ACCESSORS_PROMPT = 'java.action.generateAccessorsPrompt';
+    /**
+     * Generate Constructors.
+     */
+    export const GENERATE_CONSTRUCTORS_PROMPT = 'java.action.generateConstructorsPrompt';
 }

src/extension.ts

@@ -70,6 +70,7 @@ export function activate(context: ExtensionContext): Promise<ExtensionAPI> {
 							advancedOrganizeImportsSupport: true,
 							generateToStringPromptSupport: true,
 							advancedGenerateAccessorsSupport: true,
+							generateConstructorsPromptSupport: true,
 						},
 						triggerFiles: getTriggerFiles()
 					},

src/protocol.ts

@@ -148,15 +148,15 @@ export namespace AddOverridableMethodsRequest {
     export const type = new RequestType<AddOverridableMethodParams, WorkspaceEdit, void, void>('java/addOverridableMethods');
 }
 
-export interface VariableField {
+export interface VariableBinding {
     bindingKey: string;
     name: string;
     type: string;
 }
 
 export interface CheckHashCodeEqualsResponse {
     type: string;
-    fields: VariableField[];
+    fields: VariableBinding[];
     existingMethods: string[];
 }
 
@@ -166,7 +166,7 @@ export namespace CheckHashCodeEqualsStatusRequest {
 
 export interface GenerateHashCodeEqualsParams {
     context: CodeActionParams;
-    fields: VariableField[];
+    fields: VariableBinding[];
     regenerate: boolean;
 }
 
@@ -190,7 +190,7 @@ export interface ImportSelection {
 
 export interface CheckToStringResponse {
     type: string;
-    fields: VariableField[];
+    fields: VariableBinding[];
     exists: boolean;
 }
 
@@ -200,7 +200,7 @@ export namespace CheckToStringStatusRequest {
 
 export interface GenerateToStringParams {
     context: CodeActionParams;
-    fields: VariableField[];
+    fields: VariableBinding[];
 }
 
 export namespace GenerateToStringRequest {
@@ -226,3 +226,28 @@ export interface GenerateAccessorsParams {
 export namespace GenerateAccessorsRequest {
     export const type = new RequestType<GenerateAccessorsParams, WorkspaceEdit, void, void>('java/generateAccessors');
 }
+
+export interface MethodBinding {
+    bindingKey: string;
+    name: string;
+    parameters: string[];
+}
+
+export interface CheckConstructorsResponse {
+    constructors: MethodBinding[];
+    fields: VariableBinding[];
+}
+
+export namespace CheckConstructorStatusRequest {
+    export const type = new RequestType<CodeActionParams, CheckConstructorsResponse, void, void>('java/checkConstructorsStatus');
+}
+
+export interface GenerateConstructorsParams {
+    context: CodeActionParams;
+    constructors: MethodBinding[];
+    fields: VariableBinding[];
+}
+
+export namespace GenerateConstructorsRequest {
+    export const type = new RequestType<GenerateConstructorsParams, WorkspaceEdit, void, void>('java/generateConstructors');
+}

src/sourceAction.ts

@@ -5,7 +5,7 @@ import { CodeActionParams, LanguageClient } from 'vscode-languageclient';
 import { Commands } from './commands';
 import { applyWorkspaceEdit } from './extension';
 import { ListOverridableMethodsRequest, AddOverridableMethodsRequest, CheckHashCodeEqualsStatusRequest, GenerateHashCodeEqualsRequest,
-OrganizeImportsRequest, ImportCandidate, ImportSelection, GenerateToStringRequest, CheckToStringStatusRequest, VariableField, ResolveUnimplementedAccessorsRequest, GenerateAccessorsRequest } from './protocol';
+OrganizeImportsRequest, ImportCandidate, ImportSelection, GenerateToStringRequest, CheckToStringStatusRequest, VariableBinding, ResolveUnimplementedAccessorsRequest, GenerateAccessorsRequest, CheckConstructorStatusRequest, GenerateConstructorsRequest } from './protocol';
 
 export function registerCommands(languageClient: LanguageClient, context: ExtensionContext) {
     registerOverrideMethodsCommand(languageClient, context);
@@ -14,6 +14,7 @@ export function registerCommands(languageClient: LanguageClient, context: Extens
     registerChooseImportCommand(context);
     registerGenerateToStringCommand(languageClient, context);
     registerGenerateAccessorsCommand(languageClient, context);
+    registerGenerateConstructorsCommand(languageClient, context);
 }
 
 function registerOverrideMethodsCommand(languageClient: LanguageClient, context: ExtensionContext): void {
@@ -176,7 +177,7 @@ function registerGenerateToStringCommand(languageClient: LanguageClient, context
             }
         }
 
-        let fields: VariableField[] = [];
+        let fields: VariableBinding[] = [];
         if (result.fields && result.fields.length) {
             const fieldItems = result.fields.map((field) => {
                 return {
@@ -240,3 +241,57 @@ function registerGenerateAccessorsCommand(languageClient: LanguageClient, contex
         applyWorkspaceEdit(workspaceEdit, languageClient);
     }));
 }
+
+function registerGenerateConstructorsCommand(languageClient: LanguageClient, context: ExtensionContext): void {
+    context.subscriptions.push(commands.registerCommand(Commands.GENERATE_CONSTRUCTORS_PROMPT, async (params: CodeActionParams) => {
+        const status = await languageClient.sendRequest(CheckConstructorStatusRequest.type, params);
+        if (!status || !status.constructors || !status.constructors.length) {
+            return;
+        }
+
+        let selectedConstructors = status.constructors;
+        let selectedFields = [];
+        if (status.constructors.length > 1) {
+            const constructorItems = status.constructors.map((constructor) => {
+                return {
+                    label: `${constructor.name}(${constructor.parameters.join(',')})`,
+                    originalConstructor: constructor,
+                };
+            });
+            const selectedConstructorItems = await window.showQuickPick(constructorItems, {
+                canPickMany: true,
+                placeHolder: 'Select super class constructor(s).',
+            });
+            if (!selectedConstructorItems || !selectedConstructorItems.length) {
+                return;
+            }
+
+            selectedConstructors = selectedConstructorItems.map(item => item.originalConstructor);
+        }
+
+        if (status.fields.length) {
+            const fieldItems = status.fields.map((field) => {
+                return {
+                    label: `${field.name}: ${field.type}`,
+                    originalField: field,
+                };
+            });
+            const selectedFieldItems = await window.showQuickPick(fieldItems, {
+                canPickMany: true,
+                placeHolder: 'Select fields to initialize by constructor(s).',
+            });
+            if (!selectedFieldItems) {
+                return;
+            }
+
+            selectedFields = selectedFieldItems.map(item => item.originalField);
+        }
+
+        const workspaceEdit = await languageClient.sendRequest(GenerateConstructorsRequest.type, {
+            context: params,
+            constructors: selectedConstructors,
+            fields: selectedFields,
+        });
+        applyWorkspaceEdit(workspaceEdit, languageClient);
+    }));
+}

test/extension.test.ts

@@ -47,7 +47,8 @@ suite('Java Language Extension', () => {
 				Commands.ORGANIZE_IMPORTS,
 				Commands.CHOOSE_IMPORTS,
 				Commands.GENERATE_TOSTRING_PROMPT,
-				Commands.GENERATE_ACCESSORS_PROMPT
+				Commands.GENERATE_ACCESSORS_PROMPT,
+				Commands.GENERATE_CONSTRUCTORS_PROMPT,
 			];
 			const foundJavaCommands = commands.filter(function(value) {
 				return JAVA_COMMANDS.indexOf(value)>=0 || value.startsWith('java.');