Add a PR-time check for non-standard NPM registries (#3134)

* Add a script for checking non-standard NPM registries
* github/workflows/pr-verify: run repo:check after install

Author: fsouza

.github/workflows/pr-verify.yml

@@ -24,6 +24,7 @@ jobs:
       - run: wget http://download.eclipse.org/jdtls/snapshots/jdt-language-server-latest.tar.gz
       - run: mkdir server && tar -xvzf jdt-language-server-latest.tar.gz -C ./server && rm jdt-language-server-latest.tar.gz
       - run: npm install
+      - run: npm run repo:check
       - run: npm run compile
       - run: npm run vscode:prepublish
       - run: vsce package

gulpfile.js

@@ -14,6 +14,10 @@ const originalTestFolder = path.join(__dirname, 'test', 'resources', 'projects',
 const tempTestFolder = path.join(__dirname, 'test-temp');
 const testSettings = path.join(tempTestFolder, '.vscode', 'settings.json');
 const JDT_LS_SNAPSHOT_URL = "http://download.eclipse.org/jdtls/snapshots/jdt-language-server-latest.tar.gz"
+const NON_NPM_REPOSITORY_RE = new RegExp(
+	String.raw`"resolved":\s*"https://.+/registry.npmjs.org/`,
+	"g"
+);
 //...
 
 gulp.task('clean_jre', function (done) {
@@ -216,6 +220,32 @@ gulp.task('prepare_pre_release', function (done) {
 	done();
 });
 
+gulp.task('repo_check', function (done) {
+	const data = fse.readFileSync("./package-lock.json", { encoding: "utf-8" });
+
+	if (NON_NPM_REPOSITORY_RE.test(data)) {
+		done(new Error("Found references to the internal registry in the file package-lock.json. Please fix it with 'npm run repo:fix'"));
+	} else {
+		done();
+	}
+});
+
+gulp.task('repo_fix', function (done) {
+	const data = fse.readFileSync("./package-lock.json", { encoding: "utf-8" });
+	const newData = data.replace(NON_NPM_REPOSITORY_RE, `"resolved": "https://registry.npmjs.org/`);
+
+	if (data !== newData) {
+		fse.writeFileSync("./package-lock.json", newData, {
+			encoding: "utf-8",
+		});
+		console.log(`successfully fixed package-lock.json`);
+	} else {
+		console.log("nothing to fix");
+	}
+
+	done();
+});
+
 function isWin() {
 	return /^win/.test(process.platform);
 }
@@ -252,4 +282,4 @@ function build_server_fn(){
 	gulp.src(server_dir + '/org.eclipse.jdt.ls.product/distro/*.tar.gz')
 		.pipe(decompress())
 		.pipe(gulp.dest('./server'));
-}
+}

package.json

@@ -1448,7 +1448,9 @@
     "build": "./node_modules/.bin/gulp build_or_download",
     "fast-build-server": "./node_modules/.bin/gulp dev_server",
     "watch-server": "./node_modules/.bin/gulp watch_server",
-    "eslint": "eslint --ignore-path .eslintignore --ext .js,.ts,.tsx ."
+    "eslint": "eslint --ignore-path .eslintignore --ext .js,.ts,.tsx .",
+    "repo:check": "./node_modules/.bin/gulp repo_check",
+    "repo:fix": "./node_modules/.bin/gulp repo_fix"
   },
   "devDependencies": {
     "@types/fs-extra": "^8.0.0",