Merge pull request #22112 from WeiTheShinobi/simplify_drop_may_danble_check

ChayimFriedman2 · web-flow · commit f381976fa67d · 2026-04-20T16:23:30.000Z
Simplify `drop_maybe_dangle` function.
diff --git a/crates/hir/src/lib.rs b/crates/hir/src/lib.rs
@@ -881,7 +881,6 @@ impl Module {
             }
 
             let drop_maybe_dangle = (|| {
-                // FIXME: This can be simplified a lot by exposing hir-ty's utils.rs::Generics helper
                 let trait_ = trait_?;
                 let drop_trait = interner.lang_items().Drop?;
                 if drop_trait != trait_.into() {

Original file line number	Diff line number	Diff line change
`@@ -881,7 +881,6 @@ impl Module {`
`881`	`881`	`}`
`882`	`882`
`883`	`883`	`let drop_maybe_dangle = (\|\| {`
`884`		`- // FIXME: This can be simplified a lot by exposing hir-ty's utils.rs::Generics helper`
`885`	`884`	`let trait_ = trait_?;`
`886`	`885`	`let drop_trait = interner.lang_items().Drop?;`
`887`	`886`	`if drop_trait != trait_.into() {`