Skip to content

Commit b05ef4f

Browse files
SK-3026 fix workfow
1 parent 1bdb24b commit b05ef4f

3 files changed

Lines changed: 16 additions & 2 deletions

File tree

‎.github/workflows/internal-release.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,3 +61,5 @@ jobs:
6161
skyflow-credentials: ${{ secrets.SKYFLOW_CREDENTIALS }}
6262
test-expired-token: ${{ secrets.TEST_EXPIRED_TOKEN }}
6363
test-reusable-token: ${{ secrets.TEST_REUSABLE_TOKEN }}
64+
pat-actions: ${{ secrets.PAT_ACTIONS }}
65+
test-credentials-file-string: ${{ secrets.TEST_CREDENTIALS_FILE_STRING }}

‎.github/workflows/release.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,3 +88,5 @@ jobs:
8888
skyflow-credentials: ${{ secrets.SKYFLOW_CREDENTIALS }}
8989
test-expired-token: ${{ secrets.TEST_EXPIRED_TOKEN }}
9090
test-reusable-token: ${{ secrets.TEST_REUSABLE_TOKEN }}
91+
pat-actions: ${{ secrets.PAT_ACTIONS }}
92+
test-credentials-file-string: ${{ secrets.TEST_CREDENTIALS_FILE_STRING }}

‎.github/workflows/shared-build-and-deploy.yml‎

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,16 @@ on:
8787
test-reusable-token:
8888
required: true
8989

90+
# Reusable workflows do NOT inherit the caller's secrets: anything referenced below must be
91+
# declared here AND passed by every caller, otherwise it silently resolves to an empty string.
92+
# An empty `token:` is what made actions/checkout fail with
93+
# "Error: Input required and not supplied: token".
94+
pat-actions:
95+
required: true
96+
97+
test-credentials-file-string:
98+
required: true
99+
90100
jobs:
91101
publish:
92102
runs-on: ubuntu-latest
@@ -98,7 +108,7 @@ jobs:
98108
# checkout and reused for the automated version-bump push below, so
99109
# that push satisfies the branch-protection ruleset's repo-admin
100110
# bypass (github-actions[bot] is not a bypass actor). See SK-2986.
101-
token: ${{ secrets.PAT_ACTIONS }}
111+
token: ${{ secrets.pat-actions }}
102112

103113
- name: Set up maven or jfrog repository
104114
uses: actions/setup-java@v4
@@ -212,7 +222,7 @@ jobs:
212222
uses: jsdaniell/create-json@1.1.2
213223
with:
214224
name: "credentials.json"
215-
json: ${{ secrets.TEST_CREDENTIALS_FILE_STRING }}
225+
json: ${{ secrets.test-credentials-file-string }}
216226

217227
# Tests load these with Dotenv.load()/relative paths, which resolve
218228
# against the *module* directory - Maven runs each module's tests with

0 commit comments

Comments
 (0)