feat: support OCI images without platform tags (#738)

- Upgrade @snyk/docker-registry-v2-client from 2.23.0 to 2.24.0
- Add test for snykgoof/oci-goof:ociNoPlatformTag

Author: adrobuta

package-lock.json

@@ -30,7 +30,7 @@
   "dependencies": {
     "@snyk/composer-lockfile-parser": "^1.4.1",
     "@snyk/dep-graph": "^2.10.0",
-    "@snyk/docker-registry-v2-client": "^2.23.0",
+    "@snyk/docker-registry-v2-client": "^2.24.0",
     "@snyk/rpm-parser": "^3.4.0",
     "@snyk/snyk-docker-pull": "^3.15.0",
     "@swimlane/docker-reference": "^2.0.1",

package.json

@@ -1,4 +1,5 @@
 import { scan } from "../../../lib/index";
+import { execute } from "../../../lib/sub-process";
 
 describe("handles bad input being provided", () => {
   it("should reject when provided with a non-existent image and tag", async () => {
@@ -9,3 +10,30 @@ describe("handles bad input being provided", () => {
     ).rejects.toEqual(Error("authentication required"));
   });
 });
+
+describe("OCI images without platform tags", () => {
+  afterAll(async () => {
+    await execute("docker", [
+      "image",
+      "rm",
+      "snykgoof/oci-goof:ociNoPlatformTag",
+    ]).catch(() => {
+      console.error(`tests teardown failed to remove docker image`);
+    });
+  });
+
+  it("should correctly scan an OCI image without platform information in the tag", async () => {
+    const image = "snykgoof/oci-goof:ociNoPlatformTag";
+
+    const pluginResult = await scan({
+      path: image,
+      username: process.env.DOCKER_HUB_USERNAME,
+      password: process.env.DOCKER_HUB_PASSWORD,
+    });
+
+    expect(pluginResult.scanResults).toBeDefined();
+    expect(pluginResult.scanResults.length).toBeGreaterThan(0);
+    expect(pluginResult.scanResults[0].facts).toBeDefined();
+    expect(pluginResult.scanResults[0].facts.length).toBeGreaterThan(0);
+  });
+});