fix: only consider top-level projects [IDE-803] (#236)

fix: only consider top-level projects

Author: bastiandoetsch

plugin/src/main/java/io/snyk/eclipse/plugin/utils/ResourceUtils.java

@@ -4,7 +4,15 @@
 import java.io.InputStream;
 import java.net.URL;
 import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Base64;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.List;
+import java.util.Set;
+import java.util.TreeSet;
+import java.util.stream.Collectors;
 
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.resources.IResource;
@@ -14,6 +22,15 @@
 
 public class ResourceUtils {
 
+	private static final Comparator<IProject> projectByPathComparator = new Comparator<IProject>() {		
+		@Override
+		public int compare(IProject o1, IProject o2) {
+			Path fullPath = ResourceUtils.getFullPath(o1);
+			Path fullPath2 = ResourceUtils.getFullPath(o2);
+			return fullPath.compareTo(fullPath2);
+		}
+	};
+
 	public ResourceUtils() {
 	}
 
@@ -45,18 +62,48 @@ private static byte[] getImageDataFromUrl(URL imageUrl) {
 		}
 	}
 
-	public static Path getFullPath(IResource resource) {	
+	public static Path getFullPath(IResource resource) {
 		return resource.getLocation().toPath().toAbsolutePath();
 	}
 
 	public static IProject getProjectByPath(Path path) {
-		var projects = ResourcesPlugin.getWorkspace().getRoot().getProjects();
+		var projects = getAccessibleTopLevelProjects();
+		
 		for (IProject iProject : projects) {
 			Path projectPath = ResourceUtils.getFullPath(iProject);
-			if (iProject.isAccessible() && path.normalize().startsWith(projectPath)) {
+			if (path.normalize().startsWith(projectPath)) {
 				return iProject;
 			}
 		}
 		return null;
 	}
+
+	public static List<IProject> getAccessibleTopLevelProjects() {
+		var projects = Arrays.stream(ResourcesPlugin.getWorkspace().getRoot().getProjects())
+				.filter((project) -> {
+					return project.isAccessible() 
+							&& !project.isDerived() 
+							&& !project.isHidden();
+				})
+				.sorted(projectByPathComparator)
+				.collect(Collectors.toList());
+		
+		Set<IProject> topLevel = new TreeSet<>(projectByPathComparator);
+		boolean add = true;
+		for (IProject iProject : projects) {
+			var projectPath = ResourceUtils.getFullPath(iProject);
+			for (IProject tp : topLevel) {
+				var topLevelPath = ResourceUtils.getFullPath(tp);
+				if (projectPath.startsWith(topLevelPath)) {
+					add = false;
+					break;
+				}
+			}
+			if (add) {
+				topLevel.add(iProject);
+			}
+		}
+		
+		return new ArrayList<>(topLevel);
+	}
 }

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/RootNode.java

@@ -1,12 +1,9 @@
 package io.snyk.eclipse.plugin.views.snyktoolview;
 
 import java.nio.file.Path;
-import java.util.Arrays;
 import java.util.List;
-import java.util.stream.Collectors;
 
 import org.eclipse.core.resources.IProject;
-import org.eclipse.core.resources.ResourcesPlugin;
 
 import io.snyk.eclipse.plugin.utils.ResourceUtils;
 
@@ -18,10 +15,7 @@ public RootNode() {
 
 	public void reset() {
 		super.reset();
-
-		var workspace = ResourcesPlugin.getWorkspace();
-		IProject[] allProjects = workspace.getRoot().getProjects();
-		List<IProject> openProjects = Arrays.stream(allProjects).filter(IProject::isOpen).collect(Collectors.toList());
+		List<IProject> openProjects = ResourceUtils.getAccessibleTopLevelProjects();
 
 		for (IProject project : openProjects) {
 			Path path = ResourceUtils.getFullPath(project);

plugin/src/main/java/io/snyk/languageserver/protocolextension/SdkHelper.java

@@ -7,6 +7,7 @@
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Path;
 import java.nio.file.Paths;
+import javax.xml.XMLConstants;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
@@ -84,6 +85,7 @@ private String getPyDevInterpreterName(String projectPath) throws IOException {
 		}
 		try {
 			DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
+			factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
 			DocumentBuilder builder = factory.newDocumentBuilder();
 			Document document = builder.parse(pydevProjectFile);