feat: add ToS and privacy, remove old legacy view [IDE-810] [IDE-713] (#237)

* feat: add ToS and privacy, remove old legacy view

* chore: remove legacy view from plugin.xml

* chore: update theme id for background colors

Author: bastiandoetsch

plugin/plugin.xml

@@ -8,14 +8,6 @@
             name="%category.name"
             id="io.snyk.eclipse.plugin">
         </category>
-        <view
-            id="io.snyk.eclipse.plugin.views.SnykView"
-            name="%view.name"
-            icon="icons/patch.png"
-            class="io.snyk.eclipse.plugin.views.SnykView"
-            category="io.snyk.eclipse.plugin"
-            inject="true">
-        </view>
         <view
             id="io.snyk.eclipse.plugin.views.snyktoolview"
             name="%toolView.name"
@@ -28,14 +20,12 @@
     <extension point="org.eclipse.ui.perspectiveExtensions">
         <perspectiveExtension
             targetID="org.eclipse.jdt.ui.JavaPerspective">
-            <view
-                id="io.snyk.eclipse.plugin.views.SnykView"
-                relative="org.eclipse.ui.views.ProblemView"
-                relationship="right"
-                ratio="0.5">
+            <view 
+            	id="io.snyk.eclipse.plugin.views.snyktoolview" 
+            	ratio="0.5" 
+            	relative="org.eclipse.ui.views.ProblemView"
+                relationship="right">
             </view>
-            <!-- <view id="io.snyk.eclipse.plugin.views.snyktoolview" ratio="0.5"> 
-                </view> -->
         </perspectiveExtension>
     </extension>
     <extension point="org.eclipse.help.contexts">

plugin/src/main/java/io/snyk/eclipse/plugin/SnykStartup.java

@@ -20,13 +20,11 @@
 import org.eclipse.ui.IStartup;
 import org.eclipse.ui.IWorkbench;
 import org.eclipse.ui.IWorkbenchPage;
-import org.eclipse.ui.IWorkbenchWindow;
 import org.eclipse.ui.PartInitException;
 import org.eclipse.ui.PlatformUI;
 
 import io.snyk.eclipse.plugin.properties.preferences.Preferences;
 import io.snyk.eclipse.plugin.utils.SnykLogger;
-import io.snyk.eclipse.plugin.views.SnykView;
 import io.snyk.eclipse.plugin.views.snyktoolview.ISnykToolView;
 import io.snyk.eclipse.plugin.views.snyktoolview.SnykToolView;
 import io.snyk.eclipse.plugin.wizards.SnykWizard;
@@ -38,16 +36,12 @@
 
 public class SnykStartup implements IStartup {
 	private static LsRuntimeEnvironment runtimeEnvironment;
-	private SnykView snykView = null;
 	private static SnykToolView snykToolView = null;
 	private static boolean downloading = true;
 	private static ILog logger;
 
-	private static SnykStartup instance;
-
 	@Override
 	public void earlyStartup() {
-		instance = this;
 		if (logger == null) {
 			logger = Platform.getLog(getClass());
 		}
@@ -98,26 +92,6 @@ private void startLanguageServer() {
 		initJob.schedule();
 	}
 
-	public static SnykView getSnykView() {
-		if (instance.snykView == null) {
-			IWorkbench workbench = PlatformUI.getWorkbench();
-
-			workbench.getDisplay().syncExec(() -> {
-				IWorkbenchWindow workbenchWindow = workbench.getActiveWorkbenchWindow();
-
-				if (workbenchWindow != null) {
-					try {
-						instance.snykView = SnykView.getInstance();
-					} catch (PartInitException partInitException) {
-						logError(partInitException);
-					}
-				}
-			});
-		}
-
-		return instance.snykView;
-	}
-
 	public static ISnykToolView getView() {
 		IWorkbench workbench = PlatformUI.getWorkbench();