fix: removes filetreenodes if they have no visiable issuenodes

Author: acke

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/TreeFilterManager.java

@@ -83,6 +83,7 @@ private void updateTree(TreeViewer treeView) {
 		treeView.getControl().setRedraw(false);
 		treeView.refresh();
 		treeView.getControl().setRedraw(true);
+		treeView.expandAll();
 	}
 
 }

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/TreeViewerFilter.java

@@ -4,6 +4,7 @@
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.function.Predicate;
 
+import org.eclipse.jface.viewers.ITreeContentProvider;
 import org.eclipse.jface.viewers.TreeViewer;
 import org.eclipse.jface.viewers.Viewer;
 import org.eclipse.jface.viewers.ViewerFilter;
@@ -19,22 +20,39 @@ public TreeViewerFilter() {
 
 	@Override
 	public boolean select(Viewer viewer, Object parentElement, Object element) {
-		if (!(element instanceof IssueTreeNode) || !(viewer instanceof TreeViewer))
-			return true;
-
-		IssueTreeNode IssueTreeNode = (IssueTreeNode) element;
-		var issue = IssueTreeNode.getIssue();
-		if (issue == null) {
-			return true;
-		}
-
-		for (var kv : this.filters.entrySet()) {
-			var filter = kv.getValue();
-			if (!filter.test(issue)) {
-				return false;
-			}
-		}
-		return true;
+	    if (element instanceof FileTreeNode) {
+	        return hasVisibleChildren((FileTreeNode) element, viewer);
+	    }
+	    
+	    if (!(element instanceof IssueTreeNode) || !(viewer instanceof TreeViewer)) {
+	        return true;
+	    }
+
+	    return isIssueVisible((IssueTreeNode) element);
+	}
+
+	private boolean hasVisibleChildren(FileTreeNode fileNode, Viewer viewer) {
+	    Object[] children = ((ITreeContentProvider) ((TreeViewer) viewer).getContentProvider()).getChildren(fileNode);
+	    for (Object child : children) {
+	        if (child instanceof IssueTreeNode && isIssueVisible((IssueTreeNode) child)) {
+	            return true;
+	        }
+	    }
+	    return false;
+	}
+
+	private boolean isIssueVisible(IssueTreeNode issueNode) {
+	    Issue issue = issueNode.getIssue();
+	    if (issue == null) {
+	        return true;
+	    }
+
+	    for (var filter : this.filters.values()) {
+	        if (!filter.test(issue)) {
+	            return false;
+	        }
+	    }
+	    return true;
 	}
 
 	public void setFilterPredicate(String filterName, Predicate<? super Issue> predicate) {

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/filters/FixableFilter.java

@@ -24,6 +24,5 @@ public void applyFilter() {
 		} else {
 			this.filterManager.removeTreeFilter(this.preferenceKey);
 		}
-
 	}
 }