Skip to content

Commit 24a0295

Browse files
authored
Merge pull request #177 from snyk/chore/IDE-356_update-release-process
fix: s3 publishing
2 parents 3470750 + 6a3aba7 commit 24a0295

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

.github/upload-to-s3.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# limitations under the License.
1616
#
1717

18-
set -euo pipefail
18+
set -exo pipefail
1919

2020
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
2121
# shellcheck disable=SC2002
@@ -49,7 +49,7 @@ function uploadFile() {
4949
[ ! -d "$FILENAME_SRC" ] && echo "Directory $FILENAME_SRC does not exist." && exit 1
5050

5151
# shellcheck disable=SC2086
52-
aws s3 cp --recursive $DRY_RUN "$FILENAME_SRC" "s3://$AWS_S3_BUCKET_NAME/$BASE/$FILENAME_DST"
52+
aws s3 cp $DEBUG --recursive $DRY_RUN "$FILENAME_SRC" "s3://$AWS_S3_BUCKET_NAME/$BASE/$FILENAME_DST"
5353
}
5454

5555
# publish repo

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,6 @@ jobs:
5454
AWS_S3_BUCKET_NAME: ${{ secrets.AWS_S3_BUCKET_NAME }}
5555
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
5656
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
57+
AWS_REGION: us-east-1
5758
run: |
5859
.github/upload-to-s3.sh preview

.github/workflows/release.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ jobs:
5252
- name: Create release
5353
if: ${{ !env.ACT }}
5454
id: create_release
55+
env:
56+
GH_TOKEN: ${{ github.token }}
5557
run: gh release create ${{ steps.createTag.outputs.tagName }} --generate-notes $(find . -name 'update-site-*.zip')
5658

5759
- name: Upload binaries to static.snyk.io
@@ -60,5 +62,6 @@ jobs:
6062
AWS_S3_BUCKET_NAME: ${{ secrets.AWS_S3_BUCKET_NAME }}
6163
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
6264
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
65+
AWS_REGION: us-east-1
6366
run: |
6467
.github/upload-to-s3.sh stable

0 commit comments

Comments
 (0)