Skip to content

Commit 2e6e18e

Browse files
ackeacke
committed
fix: lint improvements
1 parent ba7515a commit 2e6e18e

File tree

3 files changed

+48
-42
lines changed

3 files changed

+48
-42
lines changed

‎plugin/src/main/java/io/snyk/eclipse/plugin/domain/ProductConstants.java‎

Lines changed: 44 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -2,42 +2,48 @@
22

33
import java.util.Map;
44

5-
public interface ProductConstants {
6-
String SCAN_STATE_IN_PROGRESS = "inProgress";
7-
String SCAN_STATE_SUCCESS = "success";
8-
String SCAN_STATE_ERROR = "error";
9-
10-
String SCAN_PARAMS_OSS = "oss";
11-
String SCAN_PARAMS_CODE = "code";
12-
String SCAN_PARAMS_IAC = "iac";
13-
14-
String DIAGNOSTIC_SOURCE_SNYK_OSS = "Snyk Open Source";
15-
String DIAGNOSTIC_SOURCE_SNYK_CODE = "Snyk Code";
16-
String DIAGNOSTIC_SOURCE_SNYK_IAC = "Snyk IaC";
17-
18-
String DISPLAYED_OSS = "Snyk Open Source";
19-
String DISPLAYED_CODE_SECURITY = "Code Security";
20-
String DISPLAYED_CODE_QUALITY = "Code Quality";
21-
String DISPLAYED_IAC = "Configuration";
22-
23-
String SEVERITY_CRITICAL = "critical";
24-
String SEVERITY_HIGH = "high";
25-
String SEVERITY_MEDIUM = "medium";
26-
String SEVERITY_LOW = "low";
27-
28-
String FILTERABLE_ISSUE_OPEN_SOURCE = "Open Source";
29-
String FILTERABLE_ISSUE_CODE_SECURITY = "Code Security";
30-
String FILTERABLE_ISSUE_CODE_QUALITY = "Code Quality";
31-
String FILTERABLE_ISSUE_INFRASTRUCTURE_AS_CODE = "Infrastructure As Code";
32-
33-
Map<String, String> FILTERABLE_ISSUE_TYPE_TO_DISPLAY = Map.of(FILTERABLE_ISSUE_CODE_QUALITY, DISPLAYED_CODE_QUALITY,
34-
FILTERABLE_ISSUE_CODE_SECURITY, DISPLAYED_CODE_SECURITY, FILTERABLE_ISSUE_INFRASTRUCTURE_AS_CODE,
35-
DISPLAYED_IAC, FILTERABLE_ISSUE_OPEN_SOURCE, DISPLAYED_OSS);
36-
37-
Map<String, String> LSP_SOURCE_TO_SCAN_PARAMS = Map.of(DIAGNOSTIC_SOURCE_SNYK_CODE, SCAN_PARAMS_CODE,
38-
DIAGNOSTIC_SOURCE_SNYK_IAC, SCAN_PARAMS_IAC, DIAGNOSTIC_SOURCE_SNYK_OSS, SCAN_PARAMS_OSS);
39-
40-
// code cannot be mapped easily
41-
Map<String, String> SCAN_PARAMS_TO_DISPLAYED = Map.of(SCAN_PARAMS_OSS, DISPLAYED_OSS, SCAN_PARAMS_IAC,
42-
DISPLAYED_IAC);
5+
public final class ProductConstants {
6+
7+
public static final String SCAN_STATE_IN_PROGRESS = "inProgress";
8+
public static final String SCAN_STATE_SUCCESS = "success";
9+
public static final String SCAN_STATE_ERROR = "error";
10+
11+
public static final String SCAN_PARAMS_OSS = "oss";
12+
public static final String SCAN_PARAMS_CODE = "code";
13+
public static final String SCAN_PARAMS_IAC = "iac";
14+
15+
public static final String DIAGNOSTIC_SOURCE_SNYK_OSS = "Snyk Open Source";
16+
public static final String DIAGNOSTIC_SOURCE_SNYK_CODE = "Snyk Code";
17+
public static final String DIAGNOSTIC_SOURCE_SNYK_IAC = "Snyk IaC";
18+
19+
public static final String DISPLAYED_OSS = "Snyk Open Source";
20+
public static final String DISPLAYED_CODE_SECURITY = "Code Security";
21+
public static final String DISPLAYED_CODE_QUALITY = "Code Quality";
22+
public static final String DISPLAYED_IAC = "Configuration";
23+
24+
public static final String SEVERITY_CRITICAL = "critical";
25+
public static final String SEVERITY_HIGH = "high";
26+
public static final String SEVERITY_MEDIUM = "medium";
27+
public static final String SEVERITY_LOW = "low";
28+
29+
public static final String FILTERABLE_ISSUE_OPEN_SOURCE = "Open Source";
30+
public static final String FILTERABLE_ISSUE_CODE_SECURITY = "Code Security";
31+
public static final String FILTERABLE_ISSUE_CODE_QUALITY = "Code Quality";
32+
public static final String FILTERABLE_ISSUE_INFRASTRUCTURE_AS_CODE = "Infrastructure As Code";
33+
34+
public static final Map<String, String> FILTERABLE_ISSUE_TYPE_TO_DISPLAY = Map.of(
35+
FILTERABLE_ISSUE_CODE_QUALITY, DISPLAYED_CODE_QUALITY,
36+
FILTERABLE_ISSUE_CODE_SECURITY, DISPLAYED_CODE_SECURITY,
37+
FILTERABLE_ISSUE_INFRASTRUCTURE_AS_CODE, DISPLAYED_IAC,
38+
FILTERABLE_ISSUE_OPEN_SOURCE, DISPLAYED_OSS);
39+
40+
public static final Map<String, String> LSP_SOURCE_TO_SCAN_PARAMS = Map.of(
41+
DIAGNOSTIC_SOURCE_SNYK_CODE, SCAN_PARAMS_CODE,
42+
DIAGNOSTIC_SOURCE_SNYK_IAC, SCAN_PARAMS_IAC,
43+
DIAGNOSTIC_SOURCE_SNYK_OSS, SCAN_PARAMS_OSS);
44+
45+
// code cannot be mapped easily
46+
public static final Map<String, String> SCAN_PARAMS_TO_DISPLAYED = Map.of(
47+
SCAN_PARAMS_OSS, DISPLAYED_OSS,
48+
SCAN_PARAMS_IAC, DISPLAYED_IAC);
4349
}

‎plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/IssueTreeNode.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public class IssueTreeNode extends BaseTreeNode {
1111

1212
public IssueTreeNode(Issue issue) {
1313
super(issue);
14-
this.setIssue(issue);
14+
this.issue = issue;
1515
}
1616

1717
@Override

‎plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/filters/BaseFilter.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
import io.snyk.eclipse.plugin.preferences.Preferences;
66
import io.snyk.eclipse.plugin.views.snyktoolview.TreeFilterManager;
77

8-
@SuppressWarnings({ "rawtypes", "PMD.AbstractClassWithoutAbstractMethod" })
9-
public abstract class BaseFilter {
8+
@SuppressWarnings({ "rawtypes"})
9+
public class BaseFilter {
1010
protected Preferences preferences = Preferences.getInstance();
1111
protected TreeFilterManager filterManager;
1212
protected String filterName;
1313
protected Predicate predicate;
1414

15-
public BaseFilter(String filterName, Predicate predicate, TreeFilterManager tfm) {
15+
protected BaseFilter(String filterName, Predicate predicate, TreeFilterManager tfm) {
1616
this.filterName = filterName;
1717
this.predicate = predicate;
1818
this.filterManager = tfm;

0 commit comments

Comments
 (0)