fix: code review improvements

Author: acke

plugin/src/main/java/io/snyk/eclipse/plugin/html/BaseHtmlProvider.java

@@ -6,7 +6,6 @@
 
 import org.eclipse.core.runtime.Platform;
 import org.eclipse.jface.resource.ColorRegistry;
-import org.eclipse.jface.resource.FontRegistry;
 import org.eclipse.jface.resource.JFaceResources;
 import org.eclipse.swt.graphics.Color;
 import org.eclipse.swt.graphics.RGB;
@@ -142,8 +141,10 @@ private String getScaledFontSize() {
 		} catch (IllegalStateException e) {
 			defaultHeight = 13;
 		}
-		// Language server HTML assumes a base font size of 10px. The default Eclipse font size is 17px (13pt), so we
-		// apply a scaling factor here. This ensures that HTML fonts scale correctly if the user changes the text size.
+		// Language server HTML assumes a base font size of 10px. The default Eclipse
+		// font size is 17px (13pt), so we
+		// apply a scaling factor here. This ensures that HTML fonts scale correctly if
+		// the user changes the text size.
 		int scaledHeight = (int) (defaultHeight / 1.7);
 		return scaledHeight + "pt";
 	}

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/ISnykToolView.java

@@ -128,5 +128,5 @@ static String getPlural(long count) {
 	 */
 	abstract void disableDelta();
 
-	abstract void selectTreeNode(Issue issue, String product);
+	abstract void selectTreeNode(Issue issue);
 }

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/SnykToolView.java

@@ -480,12 +480,12 @@ protected void outputCommandResult(Object result) {
 	}
 
 	@Override
-	public void selectTreeNode(Issue issue, String product) {
+	public void selectTreeNode(Issue issue) {
 		ProductTreeNode productNode = getProductNode(ProductConstants.DISPLAYED_CODE_SECURITY, issue.filePath());
-		drillDown((TreeNode) productNode, issue);
+		selectTreenodeForIssue((TreeNode) productNode, issue);
 	}
 
-	private void drillDown(TreeNode currentParent, Issue issue) {
+	private void selectTreenodeForIssue(TreeNode currentParent, Issue issue) {
 		for (Object child : currentParent.getChildren()) {
 			TreeNode childNode = (TreeNode) child;
 
@@ -495,7 +495,7 @@ private void drillDown(TreeNode currentParent, Issue issue) {
 			}
 
 			if (childNode.getChildren() != null && childNode.getChildren().length != 0) {
-				drillDown(childNode, issue);
+				selectTreenodeForIssue(childNode, issue);
 			}
 		}
 	}