fix: added unit tests

Author: acke

plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java

@@ -454,19 +454,33 @@ public Issue getIssueFromCache(URI uri) {
 	}
 
 	public String getDecodedParam(URI uri, String paramName) {
-		Map<String, String> paramMap = parseQueryString(uri.getQuery());
+		String query = uri.getQuery();
+		if (query == null || query.isEmpty()) {
+			return null;
+		}
+
+		Map<String, String> paramMap = parseQueryString(query);
+		String value = paramMap.get(paramName);
+
+		if (value == null) {
+			return null;
+		}
 
 		try {
-			return URLDecoder.decode(paramMap.get(paramName), "UTF-8");
+			return URLDecoder.decode(value, "UTF-8");
 		} catch (UnsupportedEncodingException e) {
 			SnykLogger.logError(e);
+			return null;
 		}
-		return null;
 	}
 
-	private static Map<String, String> parseQueryString(String queryString) {
+	public static Map<String, String> parseQueryString(String queryString) {
 		Map<String, String> paramMap = new HashMap<>();
 
+		if (queryString == null || queryString.isEmpty()) {
+			return paramMap;
+		}
+
 		for (String param : queryString.split("&")) {
 			if (!param.isEmpty()) {
 				String[] keyValue = param.split("=");

tests/src/test/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClientTest.java

@@ -11,6 +11,7 @@
 import static io.snyk.eclipse.plugin.views.snyktoolview.ISnykToolView.CONGRATS_NO_ISSUES_FOUND;
 import static io.snyk.eclipse.plugin.views.snyktoolview.ISnykToolView.getPlural;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.mockStatic;
@@ -24,10 +25,12 @@
 import java.io.File;
 import java.io.IOException;
 import java.net.URI;
+import java.net.URISyntaxException;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.Collection;
 import java.util.HashSet;
+import java.util.Map;
 import java.util.Set;
 import java.util.function.Consumer;
 
@@ -73,6 +76,10 @@ class SnykExtendedLanguageClientTest extends LsBaseTest {
 
 	private ISnykToolView toolWindowMock;
 
+	private URI uri;
+	private String paramName;
+//    private SnykLogger loggerMock;
+
 	@BeforeEach
 	protected void setUp() {
 		super.setUp();
@@ -187,12 +194,11 @@ void testPublishDiagnosticsShouldChangeCache() {
 		var folderPath = "/a/b";
 		var uri = "file://" + folderPath + "/c/";
 
-		if(SystemUtils.IS_OS_WINDOWS) {
+		if (SystemUtils.IS_OS_WINDOWS) {
 			folderPath = "C://a/b";
 			uri = "file:///" + folderPath + "/c/";
 		}
 
-
 		File pathFromUri = LSPEclipseUtils.fromUri(URI.create(uri));
 		var filePath = pathFromUri.getAbsolutePath();
 		var issueCache = new SnykIssueCache(Paths.get(folderPath));
@@ -584,4 +590,45 @@ void testGetTotal() throws IOException {
 	private AdditionalData getSecurityIssue() {
 		return Instancio.of(AdditionalData.class).set(Select.field(AdditionalData::isSecurityType), true).create();
 	}
+
+	@Test
+	public void getDecodedParam_Returns_Parameter_Value_If_Present_In_Query_String() throws Exception {
+		cut = new SnykExtendedLanguageClient();
+		String query = "product=Snyk+Code&issueId=7642f506c568056a7090d3ceb7b3c2e0&action=showInDetailPanel";
+		URI uriWithQuery = new URI("snyk://path/to/resource?" + query);
+
+		Map<String, String> paramMapMock = java.util.Collections.singletonMap("issueId",
+				"7642f506c568056a7090d3ceb7b3c2e0");
+
+		var result = cut.getDecodedParam(uriWithQuery, "issueId");
+		assertEquals("7642f506c568056a7090d3ceb7b3c2e0", result);
+
+		// Test action parameter
+		result = cut.getDecodedParam(uriWithQuery, "action");
+		assertEquals("showInDetailPanel", result);
+
+		// Test product parameter
+		result = cut.getDecodedParam(uriWithQuery, "product");
+		assertEquals("Snyk Code", result);
+	}
+
+	@Test
+	public void parseQueryString_Returns_Parameters_In_Query_String() throws Exception {
+		cut = new SnykExtendedLanguageClient();
+		String query = "product=Snyk+Code&issueId=7642f506c568056a7090d3ceb7b3c2e0&action=showInDetailPanel";
+		URI uriWithQuery = new URI("snyk://path/to/resource?" + query);
+
+		var result = cut.parseQueryString(uriWithQuery.getQuery());
+		assertEquals(3, result.size());
+	}
+
+	@Test
+	public void parseQueryString_Returns_Empty_Map_If_Query_String_Is_Empty() throws URISyntaxException {
+		cut = new SnykExtendedLanguageClient();
+		URI uriWithoutQuery = new URI("snyk://path/to/resource");
+
+		var result = cut.parseQueryString(null);
+		assertTrue(result.isEmpty());
+	}
+
 }