fix: fix additional lint errors

Author: acke

plugin/src/main/java/io/snyk/eclipse/plugin/SnykStartup.java

@@ -35,7 +35,7 @@
 
 public class SnykStartup implements IStartup {
 	private static LsRuntimeEnvironment runtimeEnvironment;
-	private static SnykToolView snykToolView = null;
+	private static SnykToolView snykToolView;
 	private static boolean downloading = true;
 	private static ILog logger;
 
@@ -116,7 +116,7 @@ private boolean downloadLS() {
 				basicFileAttributes = Files.readAttributes(lsFile.toPath(), BasicFileAttributes.class);
 				Instant lastModified = basicFileAttributes.lastModifiedTime().toInstant();
 				boolean needsUpdate = lastModified.isBefore(Instant.now().minus(4, ChronoUnit.DAYS))
-						|| !Preferences.getInstance().getLspVersion().equals(LsBinaries.REQUIRED_LS_PROTOCOL_VERSION);
+						|| !LsBinaries.REQUIRED_LS_PROTOCOL_VERSION.equals(Preferences.getInstance().getLspVersion());
 				logger.info(
 						String.format("LS: Needs update? %s. Required LSP version=%s, actual version=%s", needsUpdate,
 								LsBinaries.REQUIRED_LS_PROTOCOL_VERSION, Preferences.getInstance().getLspVersion()));

plugin/src/main/java/io/snyk/eclipse/plugin/html/CodeHtmlProvider.java

@@ -65,12 +65,12 @@ private String getThemeScript() {
 
     @Override
     public String replaceCssVariables(String html) {
-        html = super.replaceCssVariables(html);
+        String htmlStyled = super.replaceCssVariables(html);
 
         // Replace CSS variables with actual color values
-        html = html.replace("var(--example-line-removed-color)", super.getColorAsHex("DELETION_COLOR", "#ff0000"));
-        html = html.replace("var(--example-line-added-color)", super.getColorAsHex("ADDITION_COLOR", "#00ff00"));
+        htmlStyled = htmlStyled.replace("var(--example-line-removed-color)", super.getColorAsHex("DELETION_COLOR", "#ff0000"));
+        htmlStyled = htmlStyled.replace("var(--example-line-added-color)", super.getColorAsHex("ADDITION_COLOR", "#00ff00"));
 
-        return html;
+        return htmlStyled;
     }
 }

plugin/src/main/java/io/snyk/eclipse/plugin/html/HtmlProviderFactory.java

@@ -3,18 +3,18 @@
 import io.snyk.eclipse.plugin.domain.ProductConstants;
 
 public class HtmlProviderFactory {
-	
-    public static BaseHtmlProvider GetHtmlProvider(String product)
-    {
-        switch (product) {
-            case ProductConstants.DISPLAYED_CODE_SECURITY: 
-            case ProductConstants.DISPLAYED_CODE_QUALITY:
-                return CodeHtmlProvider.getInstance();
-            case ProductConstants.DISPLAYED_OSS:
-                return OssHtmlProvider.getInstance();
-            case ProductConstants.DISPLAYED_IAC:
-                return IacHtmlProvider.getInstance();
-        }
-        return null;
-    }
+
+	public static BaseHtmlProvider GetHtmlProvider(String product) {
+		switch (product) {
+		case ProductConstants.DISPLAYED_CODE_SECURITY:
+		case ProductConstants.DISPLAYED_CODE_QUALITY:
+			return CodeHtmlProvider.getInstance();
+		case ProductConstants.DISPLAYED_OSS:
+			return OssHtmlProvider.getInstance();
+		case ProductConstants.DISPLAYED_IAC:
+			return IacHtmlProvider.getInstance();
+		default:
+			return null;
+		}
+	}
 }

plugin/src/main/java/io/snyk/eclipse/plugin/preferences/LabelFieldEditor.java

@@ -20,11 +20,13 @@ public LabelFieldEditor(String value, Composite parent) {
 
   // Adjusts the field editor to be displayed correctly
   // for the given number of columns.
+  @Override
   protected void adjustForNumColumns(int numColumns) {
     ((GridData) label.getLayoutData()).horizontalSpan = numColumns;
   }
 
   // Fills the field editor's controls into the given parent.
+  @Override
   protected void doFillIntoGrid(Composite parent, int numColumns) {
     label = getLabelControl(parent);
 
@@ -39,17 +41,21 @@ protected void doFillIntoGrid(Composite parent, int numColumns) {
   }
 
   // Returns the number of controls in the field editor.
+  @Override
   public int getNumberOfControls() {
     return 1;
   }
 
   // Labels do not persist any preferences, so these methods are empty.
+  @Override
   protected void doLoad() {
   }
 
+  @Override
   protected void doLoadDefault() {
   }
-
+  
+  @Override
   protected void doStore() {
   }
 }

plugin/src/main/java/io/snyk/eclipse/plugin/properties/FolderConfigs.java

@@ -76,7 +76,7 @@ public FolderConfigsParam updateFolderConfigs() {
 
 		for (var project : openProjects) {
 			Path path = ResourceUtils.getFullPath(project);
-			IScopeContext projectScope = new ProjectScope(project);
+			IScopeContext projectScope = new ProjectScope(project); //NOPMD
 			var projectSettings = projectScope.getNode(Activator.PLUGIN_ID);
 			String additionalParams = projectSettings.get(ProjectPropertyPage.SNYK_ADDITIONAL_PARAMETERS, "");
 			var additionalParamsList = Arrays.asList(additionalParams.split(" "));

plugin/src/main/java/io/snyk/eclipse/plugin/views/ScanWorkspaceFolderHandler.java

@@ -19,6 +19,7 @@
 public class ScanWorkspaceFolderHandler extends AbstractHandler {
 
 	@SuppressWarnings("restriction")
+	@Override
 	public Object execute(ExecutionEvent event) throws ExecutionException {
 		IWorkbenchWindow window = HandlerUtil.getActiveWorkbenchWindowChecked(event);
 

plugin/src/main/java/io/snyk/eclipse/plugin/views/ScanWorkspaceMenuHandler.java

@@ -10,10 +10,11 @@
 
 public class ScanWorkspaceMenuHandler extends AbstractHandler {
 
-  public Object execute(ExecutionEvent event) throws ExecutionException {
-	  CompletableFuture.runAsync(() -> {
+	@Override
+	public Object execute(ExecutionEvent event) throws ExecutionException {
+		CompletableFuture.runAsync(() -> {
 			SnykExtendedLanguageClient.getInstance().triggerScan(null);
 		});
-    return null;
-  }
+		return null;
+	}
 }

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/filters/BaseFilter.java

@@ -5,7 +5,7 @@
 import io.snyk.eclipse.plugin.preferences.Preferences;
 import io.snyk.eclipse.plugin.views.snyktoolview.TreeFilterManager;
 
-@SuppressWarnings("rawtypes")
+@SuppressWarnings({ "rawtypes", "PMD.AbstractClassWithoutAbstractMethod" })
 public abstract class BaseFilter {
 	protected Preferences preferences = Preferences.getInstance();
 	protected TreeFilterManager filterManager;

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/handlers/BaseHandler.java

@@ -27,9 +27,9 @@
 import io.snyk.eclipse.plugin.views.snyktoolview.TreeFilterManager;
 
 public class BaseHandler extends AbstractHandler implements IElementUpdater, IHandlerCommands {
-	protected ImageDescriptor iconEnabled = null;
-	protected ImageDescriptor iconDisabled = null;
-	protected String preferenceKey = null;
+	protected ImageDescriptor iconEnabled;
+	protected ImageDescriptor iconDisabled;
+	protected String preferenceKey;
 
 	public BaseHandler() {
 		iconEnabled = SnykIcons.ENABLED;

plugin/src/main/java/io/snyk/eclipse/plugin/wizards/SnykWizard.java

@@ -44,25 +44,29 @@ public void addPages() {
 		setNeedsProgressMonitor(true);
 	}
 
+	@Override
 	public void init(IWorkbench workbench, IStructuredSelection selection) {
 		this.workbench = workbench;
 		this.selection = selection;
 	}
 
+	@Override
 	public boolean canFinish() {
-		if (this.getContainer().getCurrentPage() == authenticatePage) {
+		if (this.getContainer().getCurrentPage().equals(authenticatePage)) {
 			return true;
 		}
 		return false;
 	}
 
+	@Override
 	public boolean performCancel() {
 		model.resetPreferences();
 		return true;
 	}
 
+	@Override
 	public boolean performFinish() {
-		new Job("Applying configuration from wizard...") {	
+		new Job("Applying configuration from wizard...") {
 			@Override
 			protected IStatus run(IProgressMonitor monitor) {
 				monitor.beginTask("starting", 60);
@@ -84,7 +88,7 @@ protected IStatus run(IProgressMonitor monitor) {
 				monitor.worked(20);
 				monitor.subTask("trusting workspace folders...");
 				var projects = ResourceUtils.getAccessibleTopLevelProjects();
-				if (projects != null && projects.size()>0) {
+				if (projects != null && !projects.isEmpty()) {
 					lc.trustWorkspaceFolders();
 				}
 				monitor.worked(20);