fix: refactor calls to the languageclient

Author: acke

plugin/src/main/java/io/snyk/eclipse/plugin/analytics/TaskProcessor.java

@@ -41,7 +41,7 @@ public static TaskProcessor getInstance() {
 	private void start() {
 		while (true) {
 			String authToken = Preferences.getInstance().getAuthToken();
-			var lc = SnykExtendedLanguageClient.getInstance();
+			SnykExtendedLanguageClient lc = SnykExtendedLanguageClient.getInstance();
 			if (taskQueue.isEmpty() || authToken == null || authToken.isBlank() || lc == null) {
 				try {
 					Thread.sleep(1000);

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/BaseBranchDialog.java

@@ -50,7 +50,8 @@ public void widgetSelected(SelectionEvent e) {
 					folderConfigs.setBaseBranch(projectPath, selectedBranch);
 					shell.close();
 					CompletableFuture.runAsync(() -> {
-						SnykExtendedLanguageClient.getInstance().triggerScan(projectPath);
+						SnykExtendedLanguageClient lc = SnykExtendedLanguageClient.getInstance();
+						lc.triggerScan(projectPath);
 					});
 				} else {
 					SnykLogger.logInfo("Branch is not a valid local branch for repository: " + projectPath);

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/SummaryBrowserHandler.java

@@ -27,7 +27,8 @@ public Object function(Object[] arguments) {
 				}
 
 				Preferences.getInstance().store(Preferences.ENABLE_DELTA, Boolean.toString(value));
-				updateConfiguration();
+
+				CompletableFuture.runAsync(() -> SnykExtendedLanguageClient.getInstance().updateConfiguration());
 
 				return null;
 			}
@@ -36,14 +37,6 @@ public Object function(Object[] arguments) {
 		setDefaultBrowserText();
 	}
 
-	private void updateConfiguration() {
-		CompletableFuture.runAsync(() -> {
-			// Update the Snyk Language Server configuration.
-			final var lc = SnykExtendedLanguageClient.getInstance();
-			lc.updateConfiguration();
-		});
-	}
-
 	public void setDefaultBrowserText() {
 		browser.setText(StaticPageHtmlProvider.getInstance().getSummaryInitHtml());
 	}

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/handlers/BaseProductFilterHandler.java

@@ -22,10 +22,9 @@ public Object execute(ExecutionEvent event) throws ExecutionException {
 
 		// now we can apply the filter
 		new ProductFilter(TreeFilterManager.getInstance(), filterName).applyFilter();
-		
-		final var lc = SnykExtendedLanguageClient.getInstance();
-		lc.updateConfiguration();
-		
+
+		SnykExtendedLanguageClient.getInstance().updateConfiguration();
+
 		return returnValue;
 	}
 }

plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/handlers/FilterNetNewIssuesHandler.java

@@ -32,7 +32,7 @@ public Object execute(ExecutionEvent event) throws ExecutionException {
 
 		CompletableFuture.runAsync(() -> {
 			// Update the Snyk Language Server configuration.
-			final var lc = SnykExtendedLanguageClient.getInstance();
+			SnykExtendedLanguageClient lc = SnykExtendedLanguageClient.getInstance();
 			lc.updateConfiguration();
 			lc.triggerScan(null);
 		});

plugin/src/main/java/io/snyk/eclipse/plugin/wizards/SnykWizardModel.java

@@ -19,10 +19,10 @@ public void resetPreferences() {
     Preferences.getInstance().setIsInsecure(initialUnknownCerts);
     Preferences.getInstance().store(Preferences.AUTH_TOKEN_KEY, initialAuthToken);
 
-    SnykExtendedLanguageClient client = SnykExtendedLanguageClient.getInstance();
+    SnykExtendedLanguageClient lc = SnykExtendedLanguageClient.getInstance();
     // The language client may be null when the extension first loads, so only update configuration if we are able.
-    if (client != null) { 
-        client.updateConfiguration(); 
+    if (lc != null) {
+        lc.updateConfiguration();
     };
   }
 }