feat: add riskScoreThreshold support to settings (#346)

* feat: add riskScoreThreshold support to settings

Add riskScoreThreshold field to enable filtering issues by risk score.
This fixes the same issue that was identified in the IntelliJ plugin
where the riskScoreThreshold value was being lost.

Changes:
- Add RISK_SCORE_THRESHOLD constant to Preferences.java
- Add riskScoreThreshold field to Settings.java
- Update LsConfigurationUpdater to read and include riskScoreThreshold
- Handle riskScoreThreshold in HTMLSettingsPreferencePage.parseAndSaveConfig()
- Add tests for riskScoreThreshold handling

* fix: add NOPMD suppression for empty catch block

Author: bastiandoetsch

plugin/src/main/java/io/snyk/eclipse/plugin/preferences/HTMLSettingsPreferencePage.java

@@ -276,6 +276,14 @@ private void parseAndSaveConfig(String jsonString) {
 			applyIfPresent(config, "enableDeltaFindings", value ->
 				prefs.store(Preferences.ENABLE_DELTA, String.valueOf(value)));
 
+			applyIfPresent(config, "riskScoreThreshold", value -> {
+				if (value instanceof Number) {
+					prefs.store(Preferences.RISK_SCORE_THRESHOLD, String.valueOf(((Number) value).intValue()));
+				} else {
+					prefs.store(Preferences.RISK_SCORE_THRESHOLD, String.valueOf(value));
+				}
+			});
+
 			applyIfPresent(config, "cliPath", value ->
 				prefs.store(Preferences.CLI_PATH, String.valueOf(value)));
 			applyIfPresent(config, "manageBinariesAutomatically", value ->

plugin/src/main/java/io/snyk/eclipse/plugin/preferences/Preferences.java

@@ -58,6 +58,7 @@ public class Preferences {
 	public static final String LSP_VERSION = "LSP_VERSION";
 	public static final String ANALYTICS_PLUGIN_INSTALLED_SENT = "analyticsPluginInstalledSent";
 	public static final String ENABLE_DELTA = "ENABLE_DELTA";
+	public static final String RISK_SCORE_THRESHOLD = "RISK_SCORE_THRESHOLD";
 
 	// all filter preferences are positive: SHOW = true, HIDE = false
 	public static final String FILTER_SHOW_CRITICAL = "FILTER_SHOW_CRITICAL";
@@ -128,6 +129,7 @@ public static synchronized Preferences getTestInstance(IEclipsePreferences insec
 		insecureStore.setDefault(FILTER_SHOW_MEDIUM, TRUE);
 		insecureStore.setDefault(FILTER_SHOW_LOW, TRUE);
 		insecureStore.setDefault(ENABLE_DELTA, FALSE);
+		insecureStore.setDefault(RISK_SCORE_THRESHOLD, "0");
 		insecureStore.setDefault(FILTER_IGNORES_SHOW_OPEN_ISSUES, TRUE);
 		insecureStore.setDefault(FILTER_IGNORES_SHOW_IGNORED_ISSUES, FALSE);
 		insecureStore.setDefault(FILTER_SHOW_ONLY_FIXABLE, FALSE);

plugin/src/main/java/io/snyk/languageserver/LsConfigurationUpdater.java

@@ -65,6 +65,16 @@ Settings getCurrentSettings() {
 
 		String enableDeltaFindings = preferences.getPref(Preferences.ENABLE_DELTA, Boolean.FALSE.toString());
 
+		Integer riskScoreThreshold = null;
+		String riskScoreThresholdStr = preferences.getPref(Preferences.RISK_SCORE_THRESHOLD, "0");
+		try {
+			int value = Integer.parseInt(riskScoreThresholdStr);
+			if (value > 0) {
+				riskScoreThreshold = value;
+			}
+		} catch (NumberFormatException e) { // NOPMD - invalid values default to null (no threshold)
+		}
+
 		// only add folder configs that are initialized
 		var folderConfigs = new ArrayList<FolderConfig>();
 		for (var p : Collections.unmodifiableSet(FolderConfigs.LanguageServerConfigReceived)) {
@@ -81,6 +91,6 @@ Settings getCurrentSettings() {
 				insecure, endpoint, additionalParams, additionalEnv, path, issueViewOptions, sendErrorReports,
 				enableTelemetry, organization, manageBinariesAutomatically, cliPath, token, integrationName,
 				integrationVersion, automaticAuthentication, trustedFolders, enableTrustedFolderFeature, scanningMode,
-				enableDeltaFindings, authenticationMethod, folderConfigs, filterSeverity);
+				enableDeltaFindings, riskScoreThreshold, authenticationMethod, folderConfigs, filterSeverity);
 	}
 }

plugin/src/main/java/io/snyk/languageserver/protocolextension/messageObjects/Settings.java

@@ -35,6 +35,7 @@ public class Settings {
 	private final String osPlatform = SystemUtils.OS_NAME;
 	private final String scanningMode;
 	private final String enableDeltaFindings;
+	private final Integer riskScoreThreshold;
 	private final String requiredProtocolVersion = LsBinaries.REQUIRED_LS_PROTOCOL_VERSION;
 	private final String authenticationMethod;
 	private final List<FolderConfig> folderConfigs;
@@ -46,7 +47,8 @@ public Settings(String activateSnykOpenSource, String activateSnykCodeSecurity,
 			String manageBinariesAutomatically, String cliPath, String token, String integrationName,
 			String integrationVersion, String automaticAuthentication, String[] trustedFolders,
 			String enableTrustedFoldersFeature, String scanningMode, String enableDeltaFindings,
-			String authenticationMethod, List<FolderConfig> folderConfigs, FilterSeverity filterSeverity) {
+			Integer riskScoreThreshold, String authenticationMethod, List<FolderConfig> folderConfigs,
+			FilterSeverity filterSeverity) {
 		this.activateSnykOpenSource = activateSnykOpenSource;
 		this.activateSnykCodeSecurity = activateSnykCodeSecurity;
 		this.activateSnykIac = activateSnykIac;
@@ -69,6 +71,7 @@ public Settings(String activateSnykOpenSource, String activateSnykCodeSecurity,
 		this.enableTrustedFoldersFeature = enableTrustedFoldersFeature;
 		this.scanningMode = scanningMode;
 		this.enableDeltaFindings = enableDeltaFindings;
+		this.riskScoreThreshold = riskScoreThreshold;
 		this.authenticationMethod = authenticationMethod;
 		this.folderConfigs = folderConfigs;
 		this.filterSeverity = filterSeverity;
@@ -190,6 +193,10 @@ public String getEnableDeltaFindings() {
 		return enableDeltaFindings;
 	}
 
+	public Integer getRiskScoreThreshold() {
+		return riskScoreThreshold;
+	}
+
 	public FilterSeverity getFilterSeverity() {
 		return filterSeverity;
 	}

tests/src/test/java/io/snyk/eclipse/plugin/preferences/HTMLSettingsPreferencePageTest.java

@@ -188,6 +188,15 @@ void parseAndSaveConfig_savesEnableDeltaFindings() throws Exception {
 		assertEquals("true", prefs.getPref(Preferences.ENABLE_DELTA));
 	}
 
+	@Test
+	void parseAndSaveConfig_savesRiskScoreThreshold() throws Exception {
+		String json = "{\"riskScoreThreshold\": 200}";
+
+		invokeParseAndSaveConfig(json);
+
+		assertEquals("200", prefs.getPref(Preferences.RISK_SCORE_THRESHOLD));
+	}
+
 	@Test
 	void parseAndSaveConfig_savesSendErrorReports() throws Exception {
 		String json = "{\"sendErrorReports\": false}";

tests/src/test/java/io/snyk/languageserver/LsConfigurationUpdaterTest.java

@@ -75,6 +75,9 @@ void testGetSettings() {
 			assertEquals(AuthConstants.AUTH_OAUTH2, settings.getAuthenticationMethod());
 			assertEquals(LsBinaries.REQUIRED_LS_PROTOCOL_VERSION, settings.getRequiredProtocolVersion());
 
+			// Verify risk score threshold is included
+			assertEquals(Integer.valueOf(200), settings.getRiskScoreThreshold());
+
 			// Verify filter severity is included
 			assertNotNull(settings.getFilterSeverity());
 			assertTrue(settings.getFilterSeverity().isCritical());
@@ -115,6 +118,7 @@ private void setupPreferenceMock() {
 		when(preferenceMock.getPref(Preferences.AUTHENTICATION_METHOD, AuthConstants.AUTH_OAUTH2)).thenReturn("oauth");
 		when(preferenceMock.getBooleanPref(Preferences.SCANNING_MODE_AUTOMATIC)).thenReturn(true);
 		when(preferenceMock.getPref(Preferences.ENABLE_DELTA, Boolean.FALSE.toString())).thenReturn("true");
+		when(preferenceMock.getPref(Preferences.RISK_SCORE_THRESHOLD, "0")).thenReturn("200");
 
 		// Severity filter mocks
 		when(preferenceMock.getBooleanPref(Preferences.FILTER_SHOW_CRITICAL, true)).thenReturn(true);