fix: hook up browswerfunctions for enable/disable delta

acke · acke · commit accd883af0f7 · 2025-01-30T11:26:13.000+01:00
diff --git a/plugin/src/main/java/io/snyk/eclipse/plugin/html/BaseHtmlProvider.java b/plugin/src/main/java/io/snyk/eclipse/plugin/html/BaseHtmlProvider.java
@@ -75,7 +75,7 @@ public String getNoDescriptionHtml() {
 						a {
 							color: var(--link-color)
 						}
-						
+
 						div {
 							padding: 20px
 						}
@@ -94,6 +94,13 @@ public String getNoDescriptionHtml() {
 		return html;
 	}
 
+	public String replaceCssVariables(String html, String ideScript) {
+		html = replaceCssVariables(html);
+		html = html.replace("${ideScript}", ideScript);
+
+		return html;
+	}
+
 	public String replaceCssVariables(String html) {
 		// Build the CSS with the nonce
 		String nonce = getNonce();
@@ -106,8 +113,11 @@ public String replaceCssVariables(String html) {
 		// Replace CSS variables with actual color values
 		html = html.replace("var(--text-color)",
 				getColorAsHex("org.eclipse.ui.workbench.ACTIVE_TAB_TEXT_COLOR", "#000000"));
-		html = html.replace("var(--ide-background-color)",
-				getColorAsHex("org.eclipse.ui.workbench.ACTIVE_TAB_BG_END", "#FFFFFF"));
+
+//		html = html.replace("var(--ide-background-color)",
+//				getColorAsHex("org.eclipse.ui.workbench.DARK_BACKGROUND", "#FFFFFF"));
+		html = html.replace("var(--ide-background-color)", "#2F2F2F");
+
 		html = html.replace("var(--background-color)",
 				getColorAsHex("org.eclipse.ui.workbench.ACTIVE_TAB_BG_END", "#FFFFFF"));
 		html = html.replace("var(--code-background-color)",
@@ -126,7 +136,6 @@ public String replaceCssVariables(String html) {
 		html = html.replace("${headerEnd}", "");
 		html = html.replace("${nonce}", nonce);
 		html = html.replace("ideNonce", nonce);
-		html = html.replace("${ideScript}", "");
 
 		return html;
 	}
diff --git a/plugin/src/main/java/io/snyk/eclipse/plugin/html/StaticPageHtmlProvider.java b/plugin/src/main/java/io/snyk/eclipse/plugin/html/StaticPageHtmlProvider.java
@@ -149,17 +149,17 @@ public String getInitHtml() {
 		return replaceCssVariables(html);
 	}
 
-	//TODO update this when we got new design from Andy
+	// TODO update this when we got new design from Andy
 	public String getSummaryInitHtml() {
+
 		var html = """
 				<!DOCTYPE html>
 				<html lang="en">
 				<body>
 				    <div class="container">
 				        <h3 class="summary-header">SUMMARY</h3>
-				                  <button type="button" onclick="window.showAllIssuesTab()">All issues</button>
-				                  <button type="button" onclick="window.showDeltaIssuesTab()">Delta issues</button>
-				        <div class="summary-row">
+				           <div class="snx-header">
+							<div class="summary-row">
 				            <span class="icon">⚠️</span>
 				            <span class="text">312 issues found in your project</span>
 				        </div>
@@ -175,7 +175,26 @@ public String getSummaryInitHtml() {
 		return replaceCssVariables(html);
 	}
 
+	public String ideScript() {
+		return """
+				<script>
+				document.addEventListener('DOMContentLoaded', function() {
+					const totalIssuesRadio = document.getElementById('totalIssues');
+					const newIssuesRadio = document.getElementById('newIssues');
+
+					totalIssuesRadio.addEventListener('change', function() {
+						window.totalIssues();
+					});
+
+					 newIssuesRadio.addEventListener('change', function() {
+							window.newIssues();
+					});
+				});
+				</script>
+				 """;
+	}
+
 	public String getFormattedSummaryHtml(String summary) {
-		return replaceCssVariables(summary);
+		return replaceCssVariables(summary, ideScript());
 	}
 }
diff --git a/plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/SummaryBrowserHandler.java b/plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/SummaryBrowserHandler.java
@@ -18,7 +18,7 @@ public SummaryBrowserHandler(Browser browser) {
 
 	public void initialize() {
 
-		new BrowserFunction(browser, "showAllIssuesTab") {
+		new BrowserFunction(browser, "totalIssues") {
 			@Override
 			public Object function(Object[] arguments) {
 				Preferences.getInstance().store(Preferences.ENABLE_DELTA, Boolean.FALSE.toString());
@@ -28,7 +28,7 @@ public Object function(Object[] arguments) {
 			}
 		};
 
-		new BrowserFunction(browser, "showDeltaIssuesTab") {
+		new BrowserFunction(browser, "newIssues") {
 			@Override
 			public Object function(Object[] arguments) {
 				Preferences.getInstance().store(Preferences.ENABLE_DELTA, Boolean.TRUE.toString());
