Merge pull request #147 from snyk/fix/HEAD-447_custom_path

Fix: custom path for CLI

Author: PeterSchafer

plugin/src/main/java/io/snyk/languageserver/LsRuntimeEnvironment.java

@@ -123,16 +123,9 @@ public void addPath(Map<String, String> env) {
     var pathOptional = Preferences.getInstance().getPath();
     if (pathOptional.isPresent()) {
       var path = pathOptional.get();
-      String splitBy;
-      if (path.contains(";")) {
-        splitBy = ";";
-      } else {
-        splitBy = ":";
-      }
-      String newPath = path.replace(splitBy, File.pathSeparator)
-        + File.pathSeparator
+      String newPath = path + File.pathSeparator
         + System.getenv("PATH");
-      env.put("PATH", newPath);
+		env.put("PATH", newPath);
     }
   }
 

tests/src/test/java/io/snyk/languageserver/LsRuntimeEnvironmentTest.java

@@ -18,6 +18,7 @@
 import org.osgi.framework.Version;
 
 import java.util.HashMap;
+import java.util.Optional;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
@@ -145,4 +146,14 @@ void testEnableTelemetryIsAddedToEnvironmentDisabled() throws StorageException {
     // This is a bit confusing - CLI takes DISABLE as env variable, but we ask for ENABLE, so it's reverted
     assertEquals("1", env.get(Preferences.ENABLE_TELEMETRY));
   }
+  @Test
+  void testAddPath() throws StorageException {
+	String expected = "C;/myPath/:";
+    HashMap<String, String> env = new HashMap<>();
+    when(preferenceMock.getPath()).thenReturn(Optional.of(expected));
+    
+    environment.addPath(env);
+
+    assert(env.get("PATH").startsWith(expected));
+  }
 }