fix: get security and quality nodes if enabled (#241)

Co-authored-by: Bastian Doetsch <bastian.doetsch@snyk.io>

Author: ShawkyZ

plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java

@@ -399,6 +399,7 @@ private void openToolView() {
 	}
 
 	private Set<ProductTreeNode> getAffectedProductNodes(String snykScanProduct, String folderPath) {
+		Preferences pref = Preferences.getInstance();
 		Set<ProductTreeNode> affectedProductTreeNodes = new HashSet<>();
 		var displayProduct = SCAN_PARAMS_TO_DISPLAYED.get(snykScanProduct);
 		if (displayProduct != null) {
@@ -408,11 +409,11 @@ private Set<ProductTreeNode> getAffectedProductNodes(String snykScanProduct, Str
 			}
 		} else {
 			ProductTreeNode productNode = toolView.getProductNode(DISPLAYED_CODE_SECURITY, folderPath);
-			if (productNode != null) {
+			if (productNode != null && pref.getBooleanPref(Preferences.ACTIVATE_SNYK_CODE_SECURITY)) {
 				affectedProductTreeNodes.add(productNode);
 			}
 			productNode = toolView.getProductNode(DISPLAYED_CODE_QUALITY, folderPath);
-			if (productNode != null) {
+			if (productNode != null && pref.getBooleanPref(Preferences.ACTIVATE_SNYK_CODE_QUALITY)) {
 				affectedProductTreeNodes.add(productNode);
 			}
 		}

tests/src/test/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClientTest.java

@@ -191,7 +191,7 @@ void testPublishDiagnosticsShouldChangeCache() {
 			folderPath = "C://a/b";
 			uri = "file:///" + folderPath + "/c/";
 		}
-		
+
 
 		File pathFromUri = LSPEclipseUtils.fromUri(URI.create(uri));
 		var filePath = pathFromUri.getAbsolutePath();
@@ -237,6 +237,8 @@ void testSnykScanUpdatesRootNodeStatus() {
 		param.setFolderPath("a/b/c");
 		ProductTreeNode productNode = new ProductTreeNode(DISPLAYED_CODE_SECURITY);
 		when(toolWindowMock.getProductNode(DISPLAYED_CODE_SECURITY, param.getFolderPath())).thenReturn(productNode);
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_SECURITY, "true");
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_QUALITY, "true");
 
 		cut = new SnykExtendedLanguageClient();
 		cut.setToolWindow(toolWindowMock);
@@ -253,6 +255,8 @@ void testSnykScanSuccessAddsInfoNodes_NoIssuesFound() {
 		param.setStatus(SCAN_STATE_SUCCESS);
 		param.setProduct(SCAN_PARAMS_CODE);
 		param.setFolderPath("a/b/c");
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_SECURITY, "true");
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_QUALITY, "true");
 
 		int issueCount = 0;
 		String expectedFirstInfoNode = CONGRATS_NO_ISSUES_FOUND;
@@ -288,6 +292,8 @@ void testSnykScanSuccessAddsInfoNodes_IssuesFound_nothingFixable() {
 
 		pref.store(Preferences.FILTER_IGNORES_SHOW_IGNORED_ISSUES, "false");
 		pref.store(Preferences.FILTER_IGNORES_SHOW_OPEN_ISSUES, "true");
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_SECURITY, "true");
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_QUALITY, "true");
 
 		runInfoNodeTest(param, issueCount, 0, 0, 3, expectedFirstInfoNode, expectedSecondInfoNode,
 				expectedThirdInfoNode);
@@ -305,6 +311,8 @@ void testSnykScanSuccessAddsInfoNodes_IssuesFound_singleFixable() {
 
 		pref.store(Preferences.FILTER_IGNORES_SHOW_IGNORED_ISSUES, "false");
 		pref.store(Preferences.FILTER_IGNORES_SHOW_OPEN_ISSUES, "true");
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_SECURITY, "true");
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_QUALITY, "true");
 
 		runInfoNodeTest(param, 1, 1, 0, 3, expectedFirstInfoNode, expectedSecondInfoNode, expectedThirdInfoNode);
 	}
@@ -321,13 +329,17 @@ void testSnykScanSuccessAddsInfoNodes_IssuesFound_multipleFixable() {
 
 		pref.store(Preferences.FILTER_IGNORES_SHOW_IGNORED_ISSUES, "false");
 		pref.store(Preferences.FILTER_IGNORES_SHOW_OPEN_ISSUES, "true");
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_SECURITY, "true");
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_QUALITY, "true");
 
 		runInfoNodeTest(param, 4, 2, 0, 3, expectedFirstInfoNode, expectedSecondInfoNode, expectedThirdInfoNode);
 	}
 
 	@Test
 	void testSnykScanSuccessAddsInfoNodes_IssuesFound_oneIgnored() {
 		var param = new SnykScanParam();
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_SECURITY, "true");
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_QUALITY, "true");
 		param.setStatus(SCAN_STATE_SUCCESS);
 		param.setProduct(SCAN_PARAMS_CODE);
 		param.setFolderPath("a/b/c");
@@ -348,6 +360,8 @@ void testSnykScanSuccessAddsInfoNodes_IssuesFound_onlyIgnoredDisplayed() {
 		pref.store(Preferences.IS_GLOBAL_IGNORES_FEATURE_ENABLED, "true");
 		pref.store(Preferences.FILTER_IGNORES_SHOW_OPEN_ISSUES, "true");
 		pref.store(Preferences.FILTER_IGNORES_SHOW_IGNORED_ISSUES, "false");
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_SECURITY, "true");
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_QUALITY, "true");
 
 		String expectedFirstInfoNode = "✋ 4 issues found by Snyk, 4 ignored";
 		String expectedSecondInfoNode = "⚡️ 2 issues can be fixed automatically";
@@ -365,6 +379,8 @@ void testSnykScanSuccessAddsInfoNodes_IssuesFound_onlyOpenDisplayed() {
 		pref.store(Preferences.IS_GLOBAL_IGNORES_FEATURE_ENABLED, "true");
 		pref.store(Preferences.FILTER_IGNORES_SHOW_OPEN_ISSUES, "false");
 		pref.store(Preferences.FILTER_IGNORES_SHOW_IGNORED_ISSUES, "true");
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_SECURITY, "true");
+		pref.store(Preferences.ACTIVATE_SNYK_CODE_QUALITY, "true");
 
 		String expectedFirstInfoNode = "✋ 4 issues found by Snyk";
 		String expectedSecondInfoNode = "⚡️ 2 issues can be fixed automatically";
@@ -376,7 +392,7 @@ void testSnykScanSuccessAddsInfoNodes_IssuesFound_onlyOpenDisplayed() {
 	private void runInfoNodeTest(SnykScanParam param, int issueCount, int fixableCount, int ignoredCount,
 			int expectedInfoNodeUpdateCount, String expectedFirstInfoNode, String expectedSecondInfoNode,
 			String expectedThirdInfoNode) {
-		
+
 		var productNodes = setupProductNodes(param);
 
 		var infoNodeCaptor = ArgumentCaptor.forClass(InfoTreeNode.class);
@@ -568,4 +584,4 @@ void testGetTotal() throws IOException {
 	private AdditionalData getSecurityIssue() {
 		return Instancio.of(AdditionalData.class).set(Select.field(AdditionalData::isSecurityType), true).create();
 	}
-}
+}