Skip to content

Commit 2ea3636

Browse files
authored
Landing page uses published version o SolidStart (#1723)
* docs: landing page uses latest published `@solidjs/start` * docs: lock version of pnpm in GH Action because of pnpm/issues/8953
1 parent 9a99e13 commit 2ea3636

8 files changed

Lines changed: 30 additions & 40 deletions

File tree

.github/workflows/cr.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ jobs:
2121

2222
- uses: pnpm/action-setup@v3
2323
with:
24-
version: 9
24+
# https://github.com/pnpm/pnpm/issues/8953
25+
version: 9.15.3
2526

2627
- name: Use Node.js 20
2728
uses: actions/setup-node@v4
@@ -36,4 +37,4 @@ jobs:
3637
run: pnpm run build:all
3738

3839
- name: Release
39-
run: pnpm dlx pkg-pr-new@0.0 publish './packages/start' --template './examples/*' --compact
40+
run: pnpm dlx pkg-pr-new@0.0 publish './packages/start' --template './examples/*' --compact

.github/workflows/docs.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ jobs:
2828

2929
- uses: pnpm/action-setup@v3
3030
with:
31-
version: 9
31+
# https://github.com/pnpm/pnpm/issues/8953
32+
version: 9.15.3
3233

3334
- name: Use Node.js 20
3435
uses: actions/setup-node@v4

.github/workflows/server-function.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,11 @@ name: ci
22

33
on:
44
pull_request:
5-
branches: [ main ]
5+
branches: [main]
66
push:
7-
branches: [ main ]
7+
branches: [main]
88

99
jobs:
10-
1110
e2e-tests:
1211
name: "E2E tests using ${{ matrix.browser }}"
1312
strategy:
@@ -21,15 +20,16 @@ jobs:
2120
uses: actions/checkout@v4
2221
- uses: actions/setup-node@v4
2322
with:
24-
node-version-file: '.nvmrc'
23+
node-version-file: ".nvmrc"
2524

2625
- uses: pnpm/action-setup@v4
2726
with:
28-
version: 9
27+
# https://github.com/pnpm/pnpm/issues/8953
28+
version: 9.15.3
2929

3030
- name: Install project dependencies
3131
run: pnpm i
32-
32+
3333
- name: Install project dependencies
3434
run: pnpm run build
3535

@@ -47,4 +47,3 @@ jobs:
4747
build: pnpm run build
4848
start: pnpm run start
4949
browser: ${{ matrix.browser }}
50-

.github/workflows/typecheck.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ jobs:
4747

4848
- uses: pnpm/action-setup@v3
4949
with:
50-
version: 9
50+
# https://github.com/pnpm/pnpm/issues/8953
51+
version: 9.15.3
5152

5253
- name: Use Node.js ${{ matrix.node-version }}
5354
uses: actions/setup-node@v4

docs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"@kobalte/utils": "^0.9.0",
1414
"@solidjs/meta": "^0.29.0",
1515
"@solidjs/router": "^0.15.0",
16-
"@solidjs/start": "workspace:*",
16+
"@solidjs/start": "latest",
1717
"@tailwindcss/typography": "^0.5.9",
1818
"autoprefixer": "^10.4.19",
1919
"citty": "^0.1.5",

package.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,26 +12,20 @@
1212
"private": true,
1313
"scripts": {
1414
"bump": "node scripts/bump.js",
15-
1615
"build": "pnpm run packages:build",
1716
"build:all": "pnpm run packages:build && pnpm run examples:build && pnpm run docs:build",
18-
1917
"clean": "pnpm run clean:all",
2018
"clean:all": "pnpm run examples:clean && pnpm run packages:clean && pnpm run clean:root",
2119
"clean:root": "pnpx rimraf ./node_modules ./.vinxi/ ./.output/",
22-
2320
"docs:dev": "pnpm --filter solid-start-docs dev",
2421
"docs:build": "pnpm --filter solid-start-docs build",
2522
"docs:start": "pnpm --filter solid-start-docs start",
2623
"docs:clean": "pnpx rimraf ./docs/node_modules ./docs/.vinxi/ ./docs/.output/",
27-
2824
"examples:build": "pnpm --filter './examples/*' --if-present build",
2925
"examples:clean": "pnpx rimraf ./examples/*/node_modules/ ./examples/*/.vinxi/ ./examples/*/.output/",
3026
"examples:use-workspace-package": "node ./util/use-workspace-package-in-examples.js",
31-
3227
"packages:build": "pnpm --filter @solidjs/start build",
3328
"packages:clean": "pnpx rimraf ./packages/*/node_modules/ ./packages/*/dist/",
34-
3529
"install:playwright": "pnpm --filter solid-start-tests run install:playwright",
3630
"clean:test": "pnpx rimraf .tmp",
3731
"test:all": "pnpm run clean:test && cross-env START_ADAPTER=solid-start-node npm run test",

pnpm-lock.yaml

Lines changed: 16 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pnpm-workspace.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,3 @@ catalog:
1212
"vite-plugin-solid": ^2.10.2
1313
"@solidjs/router": 0.15.3
1414
"solid-js": 1.9.4
15-
16-
options:
17-
prefer-workspace-packages: true
18-
strict-peer-dependencies: false

0 commit comments

Comments
 (0)