fix: server id encoding (#2061)

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: atilafassina <2382552+atilafassina@users.noreply.github.com>

Author: 3 people

.changeset/fix-server-id-encoding.md

@@ -0,0 +1,5 @@
+---
+"@solidjs/start": patch
+---
+
+fix: use percent encoding for `x-server-id` header value instead of reserved `#` character

packages/start/src/runtime/server-handler.ts

@@ -90,7 +90,7 @@ async function handleServerFunction(h3Event: HTTPEvent) {
   let functionId: string | undefined | null, name: string | undefined | null;
   if (serverReference) {
     invariant(typeof serverReference === "string", "Invalid server function");
-    [functionId, name] = serverReference.split("#");
+    [functionId, name] = decodeURIComponent(serverReference).split("#");
   } else {
     functionId = url.searchParams.get("id");
     name = url.searchParams.get("name");

packages/start/src/runtime/server-runtime.ts

@@ -125,7 +125,7 @@ function createRequest(base: string, id: string, instance: string, options: Requ
     ...options,
     headers: {
       ...options.headers,
-      "X-Server-Id": id,
+      "X-Server-Id": encodeURIComponent(id),
       "X-Server-Instance": instance
     }
   });