fix: handle deleted cookies in Single-Flight requests (#1970)

Co-authored-by: Kyle Zheng <kylezheng73@gmail.com>

Author: atilafassina

.changeset/spotty-cooks-trade.md

@@ -0,0 +1,5 @@
+---
+"@solidjs/start": patch
+---
+
+delete expired cookies in Single-Flight requests

packages/start/package.json

@@ -69,6 +69,7 @@
     "@tanstack/server-functions-plugin": "1.121.21",
     "@vinxi/plugin-directives": "^0.5.0",
     "@vinxi/server-components": "^0.5.0",
+    "cookie-es": "^2.0.0",
     "defu": "^6.1.2",
     "error-stack-parser": "^2.1.4",
     "html-to-image": "^1.11.11",

packages/start/src/runtime/server-handler.ts

@@ -1,4 +1,5 @@
 /// <reference types="vinxi/types/server" />
+import { parseSetCookie } from "cookie-es";
 import { crossSerializeStream, fromJSON, getCrossReferenceHeader } from "seroval";
 // @ts-ignore
 import {
@@ -322,9 +323,16 @@ function createSingleFlightHeaders(sourceEvent: FetchEvent) {
   }
   SetCookies.forEach(cookie => {
     if (!cookie) return;
-    const keyValue = cookie.split(";")[0]!;
-    const [key, value] = keyValue.split("=");
-    key && value && (cookies[key] = value);
+    const { maxAge, expires, name, value } = parseSetCookie(cookie);
+    if (maxAge != null && maxAge <= 0) {
+      delete cookies[name];
+      return;
+    }
+    if (expires != null && expires.getTime() <= Date.now()) {
+      delete cookies[name];
+      return;
+    }
+    cookies[name] = value;
   });
   Object.entries(cookies).forEach(([key, value]) => {
     headers.append("cookie", `${key}=${value}`);