USB: fix EPO STALL issue in STM32 USB Device library

fpistm · fpistm · commit 9181ce9677de · 2021-04-29T17:49:06.000+02:00
USB Specification EP0 should never STALL during setup stage.
Device is not properly setup if STALL present.

Signed-off-by: Frederic Pillon &lt;frederic.pillon@st.com&gt;
diff --git a/system/Middlewares/ST/STM32_USB_Device_Library/Core/Src/usbd_core.c b/system/Middlewares/ST/STM32_USB_Device_Library/Core/Src/usbd_core.c
@@ -439,7 +439,12 @@ USBD_StatusTypeDef USBD_LL_DataInStage(USBD_HandleTypeDef *pdev,
               pdev->pClass->EP0_TxSent(pdev);
             }
           }
-          (void)USBD_LL_StallEP(pdev, 0x80U);
+          /*
+           * Fix EPO STALL issue in STM32 USB Device library 2.5.1
+           * Issue raised by @makarenya, see #388
+           * USB Specification EP0 should never STALL.
+           */
+          /* (void)USBD_LL_StallEP(pdev, 0x80U); */
           (void)USBD_CtlReceiveStatus(pdev);
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -439,7 +439,12 @@ USBD_StatusTypeDef USBD_LL_DataInStage(USBD_HandleTypeDef *pdev,`
`439`	`439`	`pdev->pClass->EP0_TxSent(pdev);`
`440`	`440`	`}`
`441`	`441`	`}`
`442`		`- (void)USBD_LL_StallEP(pdev, 0x80U);`
	`442`	`+ /*`
	`443`	`+ * Fix EPO STALL issue in STM32 USB Device library 2.5.1`
	`444`	`+ * Issue raised by @makarenya, see #388`
	`445`	`+ * USB Specification EP0 should never STALL.`
	`446`	`+ */`
	`447`	`+ /* (void)USBD_LL_StallEP(pdev, 0x80U); */`
`443`	`448`	`(void)USBD_CtlReceiveStatus(pdev);`
`444`	`449`	`}`
`445`	`450`	`}`