Skip to content

Commit bafccd4

Browse files
committed
Add Mypy on the checklist for creating a PR
1 parent 0d8a232 commit bafccd4

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

docs/dev-guide.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ For documentation changes, see the documentation section below.
6464
### Code and commit
6565

6666
Here's a quick checklist to follow when coding to ensure a good pull request
67-
(PR):
67+
(PR) that will pass the PR checks:
6868

6969
- Only touch the fewest number of files possible while still accomplishing the
7070
goal.
@@ -74,6 +74,8 @@ Here's a quick checklist to follow when coding to ensure a good pull request
7474
`black --line-length 120 tableauserverclient samples test` to catch and fix any style
7575
issues before submitting your pull request. (Run black with the `--check` option if
7676
you want to check whether formatting is valid without changing any files.)
77+
- Ensure the Mypy static type checker is still passing by running
78+
`mypy --show-error-codes --disable-error-code misc --disable-error-code import tableauserverclient test`.
7779
- Keep commit messages clean and descriptive.
7880

7981
### Use git pre-commit hook

0 commit comments

Comments
 (0)