File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -64,7 +64,7 @@ For documentation changes, see the documentation section below.
6464### Code and commit
6565
6666Here's a quick checklist to follow when coding to ensure a good pull request
67- (PR):
67+ (PR) that will pass the PR checks :
6868
6969- Only touch the fewest number of files possible while still accomplishing the
7070 goal.
@@ -74,6 +74,8 @@ Here's a quick checklist to follow when coding to ensure a good pull request
7474 ` black --line-length 120 tableauserverclient samples test ` to catch and fix any style
7575 issues before submitting your pull request. (Run black with the ` --check ` option if
7676 you want to check whether formatting is valid without changing any files.)
77+ - Ensure the Mypy static type checker is still passing by running
78+ ` mypy --show-error-codes --disable-error-code misc --disable-error-code import tableauserverclient test ` .
7779- Keep commit messages clean and descriptive.
7880
7981### Use git pre-commit hook
You can’t perform that action at this time.
0 commit comments