fix: use version publish date instead of misleading time.modified (npmx-dev#702)

Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: 3 people

app/components/ColumnPicker.vue

@@ -42,7 +42,7 @@ const columnLabelKey: Record<string, string> = {
   version: 'filters.columns.version',
   description: 'filters.columns.description',
   downloads: 'filters.columns.downloads',
-  updated: 'filters.columns.updated',
+  updated: 'filters.columns.published',
   maintainers: 'filters.columns.maintainers',
   keywords: 'filters.columns.keywords',
   qualityScore: 'filters.columns.quality_score',

app/components/Package/Card.vue

@@ -94,7 +94,7 @@ const pkgDescription = useMarkdown(() => ({
               <dd class="font-mono">{{ result.package.publisher.username }}</dd>
             </div>
             <div v-if="result.package.date" class="flex items-center gap-1.5">
-              <dt class="sr-only">{{ $t('package.card.updated') }}</dt>
+              <dt class="sr-only">{{ $t('package.card.published') }}</dt>
               <dd>
                 <DateTime
                   :datetime="result.package.date"

app/components/Package/ListControls.vue

@@ -33,7 +33,7 @@ const sortOptions = computed(
   () =>
     [
       { value: 'downloads', label: $t('package.sort.downloads') },
-      { value: 'updated', label: $t('package.sort.updated') },
+      { value: 'updated', label: $t('package.sort.published') },
       { value: 'name-asc', label: $t('package.sort.name_asc') },
       { value: 'name-desc', label: $t('package.sort.name_desc') },
     ] as const,

app/components/Package/ListToolbar.vue

@@ -91,7 +91,7 @@ const sortKeyLabelKeys: Record<SortKey, string> = {
   'downloads-day': 'filters.sort.downloads_day',
   'downloads-month': 'filters.sort.downloads_month',
   'downloads-year': 'filters.sort.downloads_year',
-  'updated': 'filters.sort.updated',
+  'updated': 'filters.sort.published',
   'name': 'filters.sort.name',
   'quality': 'filters.sort.quality',
   'popularity': 'filters.sort.popularity',

app/components/Package/Skeleton.vue

@@ -70,10 +70,10 @@
           </dd>
         </div>
 
-        <!-- Updated -->
+        <!-- Published -->
         <div class="space-y-1 col-span-2">
           <dt class="text-xs text-fg-subtle uppercase tracking-wider">
-            {{ $t('package.skeleton.updated') }}
+            {{ $t('package.skeleton.published') }}
           </dt>
           <dd class="font-mono text-sm">
             <span class="skeleton inline-block h-5 w-28" />

app/components/Package/Table.vue

@@ -85,7 +85,7 @@ const columnLabelKeys: Record<ColumnId, string> = {
   version: 'filters.columns.version',
   description: 'filters.columns.description',
   downloads: 'filters.columns.downloads',
-  updated: 'filters.columns.updated',
+  updated: 'filters.columns.published',
   maintainers: 'filters.columns.maintainers',
   keywords: 'filters.columns.keywords',
   qualityScore: 'filters.columns.quality_score',

app/composables/usePackageComparison.ts

@@ -21,6 +21,12 @@ export interface PackageComparisonData {
   }
   metadata?: {
     license?: string
+    /**
+     * Publish date of this version (ISO 8601 date-time string).
+     * Uses `time[version]` from the registry, NOT `time.modified`.
+     * For example, if the package was most recently published 3 years ago
+     * but a maintainer was removed last week, this would show the '3 years ago' time.
+     */
     lastUpdated?: string
     engines?: { node?: string; npm?: string }
     deprecated?: string
@@ -133,7 +139,9 @@ export function usePackageComparison(packageNames: MaybeRefOrGetter<string[]>) {
               },
               metadata: {
                 license: pkgData.license,
-                lastUpdated: pkgData.time?.modified,
+                // Use version-specific publish time, NOT time.modified (which can be
+                // updated by metadata changes like maintainer additions)
+                lastUpdated: pkgData.time?.[latestVersion],
                 engines: analysis?.engines,
                 deprecated: versionData?.deprecated,
               },

app/pages/package/[...package].vue

@@ -863,12 +863,23 @@ function handleClick(event: MouseEvent) {
             </template>
           </ClientOnly>
 
-          <div v-if="pkg.time?.modified" class="space-y-1 sm:col-span-2">
-            <dt class="text-xs text-fg-subtle uppercase tracking-wider">
-              {{ $t('package.stats.updated') }}
+          <div
+            v-if="resolvedVersion && pkg.time?.[resolvedVersion]"
+            class="space-y-1 sm:col-span-2"
+          >
+            <dt
+              class="text-xs text-fg-subtle uppercase tracking-wider"
+              :title="
+                $t('package.stats.published_tooltip', {
+                  package: pkg.name,
+                  version: resolvedVersion,
+                })
+              "
+            >
+              {{ $t('package.stats.published') }}
             </dt>
             <dd class="font-mono text-sm text-fg">
-              <DateTime :datetime="pkg.time.modified" date-style="medium" />
+              <DateTime :datetime="pkg.time[resolvedVersion]!" date-style="medium" />
             </dd>
           </div>
         </dl>
@@ -878,7 +889,7 @@ function handleClick(event: MouseEvent) {
           <PackageSkillsModal
             :skills="skillsData?.skills ?? []"
             :package-name="pkg.name"
-            :version="displayVersion?.version"
+            :version="resolvedVersion || undefined"
           />
         </ClientOnly>
       </section>
@@ -1033,7 +1044,7 @@ function handleClick(event: MouseEvent) {
               v-if="skillsData?.skills?.length"
               :skills="skillsData.skills"
               :package-name="pkg.name"
-              :version="displayVersion?.version"
+              :version="resolvedVersion || undefined"
             />
           </ClientOnly>
 

i18n/locales/ar.json

@@ -142,7 +142,6 @@
       "deps": "الاعتماديات",
       "install_size": "حجم التثبيت",
       "vulns": "الثغرات",
-      "updated": "آخر تحديث",
       "skills": "المهارات",
       "view_dependency_graph": "عرض مخطط الاعتماديات",
       "inspect_dependency_tree": "فحص شجرة الاعتماديات",
@@ -206,7 +205,6 @@
     "compatibility": "التوافق",
     "card": {
       "publisher": "الناشر",
-      "updated": "آخر تحديث",
       "weekly_downloads": "التنزيلات الأسبوعية",
       "keywords": "الكلمات المفتاحية",
       "license": "الترخيص"
@@ -366,7 +364,6 @@
       "weekly": "أسبوعيًا",
       "size": "الحجم",
       "deps": "الاعتماديات",
-      "updated": "آخر تحديث",
       "get_started": "ابدأ",
       "readme": "README",
       "maintainers": "المشرفون",
@@ -376,7 +373,6 @@
     },
     "sort": {
       "downloads": "الأكثر تنزيلًا",
-      "updated": "مُحدَّثة مؤخرًا",
       "name_asc": "الاسم (A-Z)",
       "name_desc": "الاسم (Z-A)"
     }
@@ -661,7 +657,6 @@
       "downloads_day": "التنزيلات/اليوم",
       "downloads_month": "التنزيلات/الشهر",
       "downloads_year": "التنزيلات/السنة",
-      "updated": "آخر تحديث",
       "name": "الاسم",
       "quality": "الجودة",
       "popularity": "الشعبية",
@@ -677,7 +672,6 @@
       "version": "الإصدار",
       "description": "الوصف",
       "downloads": "التنزيلات/الأسبوع",
-      "updated": "آخر تحديث",
       "maintainers": "المشرفون",
       "keywords": "الكلمات المفتاحية",
       "quality_score": "درجة الجودة",

i18n/locales/az.json

@@ -129,7 +129,6 @@
       "deps": "Asılılıqlar",
       "install_size": "Quraşdırma Həcmi",
       "vulns": "Zəifliklər",
-      "updated": "Yenilənib",
       "view_dependency_graph": "Asılılıq qrafikini göstər",
       "inspect_dependency_tree": "Asılılıq ağacını yoxla",
       "size_tooltip": {
@@ -176,7 +175,6 @@
     "compatibility": "Uyğunluq",
     "card": {
       "publisher": "Naşir",
-      "updated": "Yenilənib",
       "weekly_downloads": "Həftəlik endirmələr",
       "keywords": "Açar sözlər",
       "license": "Lisenziya"
@@ -330,7 +328,6 @@
       "weekly": "Həftəlik",
       "size": "Həcm",
       "deps": "Asılılıqlar",
-      "updated": "Yenilənib",
       "get_started": "Başla",
       "readme": "Readme",
       "maintainers": "Dəstəkçilər",
@@ -340,7 +337,6 @@
     },
     "sort": {
       "downloads": "Ən çox endirilən",
-      "updated": "Son yenilənən",
       "name_asc": "Ad (A-Z)",
       "name_desc": "Ad (Z-A)"
     }
@@ -620,7 +616,6 @@
       "downloads_day": "Endirmələr/gün",
       "downloads_month": "Endirmələr/ay",
       "downloads_year": "Endirmələr/il",
-      "updated": "Son Yenilənmə",
       "name": "Ad",
       "quality": "Keyfiyyət",
       "popularity": "Populyarlıq",
@@ -636,7 +631,6 @@
       "version": "Versiya",
       "description": "Təsvir",
       "downloads": "Endirmələr/həftə",
-      "updated": "Son Yenilənmə",
       "maintainers": "Dəstəkçilər",
       "keywords": "Açar sözlər",
       "quality_score": "Keyfiyyət xalı",