Add a bunch more tests - crossrefs, multiple cites, mismatched aux lines. This should cover most main code paths as well as some particularly useful warning/error paths

Author: CraftSpider

crates/engine_bibtex/bibtex/bibtex.c

@@ -7278,6 +7278,7 @@ initialize(const char *aux_file_name)
         hash_text[k] = 0;
     }
 
+    cite_xptr = 0;
     hash_used = hash_max + 1;
     pool_ptr = 0;
     str_ptr = 1;

tests/bibtex.rs

@@ -85,8 +85,14 @@ impl TestCase {
 }
 
 #[test]
-fn single_entry() {
-    TestCase::new("single_entry", None).go()
+fn test_single_entry() {
+    TestCase::new("single_entry", Some("cites")).go()
+}
+
+#[test]
+fn test_many() {
+    TestCase::new("many", Some("cites"))
+        .go();
 }
 
 #[test]
@@ -107,3 +113,43 @@ fn test_mismatched_expr() {
         .test_bbl(false)
         .go();
 }
+
+#[test]
+fn test_mismatched_data() {
+    TestCase::new("data", Some("mismatched_braces"))
+        .test_bbl(false)
+        .go();
+}
+
+#[test]
+fn test_mismatched_style() {
+    TestCase::new("style", Some("mismatched_braces"))
+        .test_bbl(false)
+        .go();
+}
+
+#[test]
+fn test_duplicated_data() {
+    TestCase::new("data", Some("duplicated"))
+        .test_bbl(false)
+        .go();
+}
+
+#[test]
+fn test_duplicated_style() {
+    TestCase::new("style", Some("duplicated"))
+        .test_bbl(false)
+        .go();
+}
+
+#[test]
+fn test_bad_crossref() {
+    TestCase::new("bad", Some("crossref"))
+        .go();
+}
+
+#[test]
+fn test_min_crossref() {
+    TestCase::new("min", Some("crossref"))
+        .go();
+}

tests/bibtex/cites/many.aux

@@ -0,0 +1,11 @@
+\relax
+\citation{Nobody01}
+\citation{Nobody02}
+\citation{Nobody03}
+\citation{Nobody04}
+\bibdata{many}
+\bibcite{Nobody01}{1}
+\bibcite{Nobody02}{2}
+\bibcite{Nobody03}{3}
+\bibcite{Nobody04}{4}
+\bibstyle{../plain}

tests/bibtex/cites/many.bbl

@@ -0,0 +1,19 @@
+\begin{thebibliography}{1}
+
+\bibitem{Nobody03}
+
+
+\bibitem{Nobody04}
+
+
+\bibitem{Nobody01}
+Nobody Jr, Nobody Sr, and Nobody von Nobody.
+\newblock My article.
+\newblock {\em NoJournal}, 1(1):1--2, 2006.
+
+\bibitem{Nobody02}
+Nobody Nobody.
+\newblock {\em My Book}.
+\newblock NothingCorp, 123 Example Street, Nowhere USA, 2023.
+
+\end{thebibliography}

tests/bibtex/cites/many.bib

@@ -0,0 +1,22 @@
+@article{ Nobody01,
+    author = "Nobody Jr and Nobody Sr and Nobody von Nobody",
+    title = "My Article",
+    year = "2006",
+    journal = "NoJournal",
+    volume = "1",
+    number = "1",
+    pages = "1--2",
+}
+
+@book{ Nobody02,
+    author = "Nobody, Nobody",
+    title = "My Book",
+    year = "2023",
+    publisher = "NothingCorp",
+    address = "123 Example Street, Nowhere USA",
+}
+
+@misc { Nobody03 }
+
+@misc { Nobody04 }
+

tests/bibtex/cites/many.blg

@@ -0,0 +1,8 @@
+This is BibTeX, Version 0.99d
+Capacity: max_strings=35307, hash_size=35307, hash_prime=30011
+The top-level auxiliary file: many.aux
+The style file: ../plain.bst
+Database file #1: many.bib
+Warning--to sort, need author or key in Nobody03
+Warning--to sort, need author or key in Nobody04
+(There were 2 warnings)

tests/bibtex/single_entry.aux tests/bibtex/cites/single_entry.auxtests/bibtex/single_entry.aux renamed to tests/bibtex/cites/single_entry.aux

@@ -2,4 +2,4 @@
 \citation{Nobody06}
 \bibdata{single_entry}
 \bibcite{Nobody06}{1}
-\bibstyle{plain}
+\bibstyle{../plain}

tests/bibtex/single_entry.bbl tests/bibtex/cites/single_entry.bbltests/bibtex/single_entry.bbl renamed to tests/bibtex/cites/single_entry.bbl

@@ -1,5 +1,5 @@
 This is BibTeX, Version 0.99d
 Capacity: max_strings=35307, hash_size=35307, hash_prime=30011
 The top-level auxiliary file: single_entry.aux
-The style file: plain.bst
+The style file: ../plain.bst
 Database file #1: single_entry.bib