Skip to content

Commit c2f1693

Browse files
committed
Review fixes
1 parent b86cb11 commit c2f1693

2 files changed

Lines changed: 2 additions & 14 deletions

File tree

crates/engine_bibtex/src/c_api/cite.rs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -127,17 +127,6 @@ fn less_than(arg1: &CiteNumber, arg2: &CiteNumber) -> Ordering {
127127
let str2 = entries.strs(ptr2);
128128

129129
Ord::cmp(str1, str2)
130-
// for (){
131-
// match (char1, char2) {
132-
// (127, 127) => return arg1.cmp(arg2),
133-
// (127, _) => return Ordering::Less,
134-
// (_, 127) => return Ordering::Greater,
135-
// (char1, char2) if char1 != char2 => return char1.cmp(&char2),
136-
// _ => (),
137-
// }
138-
//
139-
// char_ptr += 1;
140-
// }
141130
})
142131
}
143132

crates/engine_bibtex/src/c_api/exec.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ pub struct ExecCtx {
6969
pub(crate) lit_stack: Box<XBuf<ExecVal>>,
7070
pub lit_stk_ptr: usize,
7171
pub mess_with_entries: bool,
72-
/// Pointer to the current top of the string pool, used to optimized certain string operations
72+
/// Pointer to the current top of the string pool, used to optimize certain string operations
7373
pub bib_str_ptr: StrNumber,
7474
}
7575

@@ -227,8 +227,7 @@ pub fn bst_ex_warn_print(ctx: &ExecCtx, pool: &StringPool) -> Result<(), BibtexE
227227
}
228228

229229
write_logs("\nwhile executing-");
230-
// SAFETY: The `Bibtex` value pointed to by `ExecCtx` is guaranteed valid
231-
bst_ln_num_print(unsafe { &*ctx.glbl_ctx }, pool)?;
230+
bst_ln_num_print(ctx.glbl_ctx(), pool)?;
232231
mark_error();
233232
Ok(())
234233
}

0 commit comments

Comments
 (0)