Commit 16bfa8f
committed
fix: Address Copilot code review comments
- Removed empty TestDecodeJSONIndentation class (was adding unnecessary code)
- Fixed flawed assertion logic in test_json_indent_with_different_indent_sizes
- Changed return type from Any to Union[JsonValue, str] for better type safety
(makes it clear the function returns either a Python value or a JSON string)
- Added Union to typing imports in decoder.py
All 19 spec-based json_indent tests passing ✓1 parent 9f906f9 commit 16bfa8f
2 files changed
Lines changed: 6 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
229 | 229 | | |
230 | 230 | | |
231 | 231 | | |
232 | | - | |
| 232 | + | |
233 | 233 | | |
234 | 234 | | |
235 | 235 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
292 | 292 | | |
293 | 293 | | |
294 | 294 | | |
295 | | - | |
296 | | - | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | | - | |
302 | | - | |
| 295 | + | |
| 296 | + | |
303 | 297 | | |
304 | 298 | | |
305 | 299 | | |
| |||
380 | 374 | | |
381 | 375 | | |
382 | 376 | | |
383 | | - | |
384 | | - | |
385 | | - | |
| 377 | + | |
| 378 | + | |
386 | 379 | | |
387 | 380 | | |
388 | 381 | | |
| |||
0 commit comments