Skip to content

Commit 0bd553e

Browse files
committed
fix: remove unnecessary console logs from async_progress_worker tests
1 parent af6fccb commit 0bd553e

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

packages/test/node-addon-api/async_progress_worker.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ class TestWorker : public AsyncProgressWorker<ProgressData> {
3838
for (int32_t idx = 0; idx < _times; idx++) {
3939
data.progress = idx;
4040
progress.Send(&data, 1);
41+
4142
{
4243
std::unique_lock<std::mutex> lk(_cvm);
4344
_cv.wait(lk, [this] { return dataSent; });

packages/test/node-addon-api/async_progress_worker.test.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,10 @@ const assert = require('assert')
66
module.exports = common.runTest(test)
77

88
async function test ({ asyncprogressworker }) {
9-
console.log('await success(asyncprogressworker)')
109
await success(asyncprogressworker)
11-
console.log('await fail(asyncprogressworker)')
1210
await fail(asyncprogressworker)
13-
console.log('await signalTest(asyncprogressworker.doMalignTest)')
1411
await signalTest(asyncprogressworker.doMalignTest)
15-
console.log('await signalTest(asyncprogressworker.doSignalAfterProgressTest)')
1612
await signalTest(asyncprogressworker.doSignalAfterProgressTest)
17-
console.log('done')
1813
}
1914

2015
function success (binding) {
@@ -23,13 +18,11 @@ function success (binding) {
2318
const actual = []
2419
binding.doWork(expected.length,
2520
common.mustCall((err) => {
26-
console.log('success callback called', err)
2721
if (err) {
2822
reject(err)
2923
}
3024
}),
3125
common.mustCall((_progress) => {
32-
console.log('success progress called', _progress)
3326
actual.push(_progress)
3427
if (actual.length === expected.length) {
3528
assert.deepEqual(actual, expected)

0 commit comments

Comments
 (0)