Merge pull request #139 from tpucci/tslint-to-eslint

Migrate from tslint to typescript-eslint

Author: tpucci

.eslintrc

@@ -0,0 +1,41 @@
+module.exports = {
+  parser: '@typescript-eslint/parser', // Specifies the ESLint parser
+  extends: [
+    'eslint:recommended',
+    'plugin:react/recommended', // Uses the recommended rules from @eslint-plugin-react
+    'plugin:@typescript-eslint/recommended', // Uses the recommended rules from @typescript-eslint/eslint-plugin
+    'plugin:prettier/recommended', // Enables eslint-plugin-prettier and displays prettier errors as ESLint errors. Make sure this is always the last configuration in the extends array.
+  ],
+  parserOptions: {
+    ecmaVersion: 2018,
+    sourceType: 'module',
+    ecmaFeatures: {
+      jsx: true,
+    },
+  },
+  rules: {
+    '@typescript-eslint/indent': 'off',
+    '@typescript-eslint/explicit-function-return-type': 'off',
+    '@typescript-eslint/explicit-member-accessibility': 'off',
+  },
+  settings: {
+    react: {
+      version: 'detect',
+    },
+  },
+  env: {
+    browser: true,
+    node: true,
+  },
+  overrides: [
+    {
+      files: ['**/*.test.ts', '**/*.test.tsx'],
+      env: {
+        jest: true,
+      },
+      rules: {
+        '@typescript-eslint/explicit-function-return-type': 'off',
+      },
+    },
+  ],
+};

.eslintrc.js

@@ -0,0 +1,2 @@
+node_modules
+package.json

.prettierignore

@@ -0,0 +1,5 @@
+{
+  "trailingComma": "es5",
+  "singleQuote": true,
+  "printWidth": 100
+}

.prettierrc

@@ -1,10 +1,11 @@
 {
-  "prettier.eslintIntegration": true,
-  "javascript.validate.enable": false,
   "editor.formatOnSave": true,
+  "eslint.enable": true,
+  "eslint.packageManager": "yarn",
+  "eslint.validate": ["javascript", "javascriptreact", "typescript", "typescriptreact"],
+  "javascript.validate.enable": false,
   "jest.showCoverageOnLoad": true,
-  "typescript.validate.enable": true,
   "npm.packageManager": "yarn",
-  "eslint.packageManager": "yarn",
-  "prettier.tslintIntegration": true
+  "prettier.requireConfig": true,
+  "typescript.validate.enable": true
 }

.vscode/settings.json

@@ -1,12 +1,16 @@
-[![Build Status](https://travis-ci.com/tpucci/react-gondola.svg?branch=master)](https://travis-ci.com/tpucci/react-gondola)
-[![Coverage Status](https://coveralls.io/repos/github/tpucci/react-gondola/badge.svg?branch=master)](https://coveralls.io/github/tpucci/react-gondola?branch=master)
-![npm](https://img.shields.io/npm/dw/react-gondola.svg)
-[![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http://commitizen.github.io/cz-cli/)
-[![semantic-release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg)](https://github.com/semantic-release/semantic-release)
+<h1 align="center">React Gondola</h1>
 
-# React Gondola
+<p align="center">React Native declarative and reactive navigation.</p>
 
-React Native declarative and reactive navigation.
+<p align="center">
+<a href="https://travis-ci.com/tpucci/react-gondola"><img src="https://travis-ci.com/tpucci/react-gondola.svg?branch=master" alt="Build Status"/></a>
+<a href="https://coveralls.io/github/tpucci/react-gondola?branch=master"><img src="https://coveralls.io/repos/github/tpucci/react-gondola/badge.svg?branch=master" alt="Coverage Status"/></a>
+<a href="https://www.npmjs.com/package/react-gondola"><img src="https://img.shields.io/npm/dw/react-gondola.svg" alt="NPM Downloads"/></a>
+<a href="http://commitizen.github.io/cz-cli/"><img src="https://img.shields.io/badge/commitizen-friendly-brightgreen.svg" alt="Commitizen friendly"/></a>
+<a href="https://github.com/semantic-release/semantic-release"><img src="https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg" alt="semantic-release"/></a>
+</p>
+
+<br>
 
 ## Philosophy
 

README.md

@@ -5,7 +5,7 @@
   "scripts": {
     "postinstall": "patch-package",
     "start": "node ../node_modules/react-native/local-cli/cli.js start",
-    "test:lint": "cd .. && yarn tslint example/src/**/*.ts{,x} && cd example",
+    "test:lint": "cd .. && yarn eslint example/src/**/*.ts{,x} && cd example",
     "test:unit": "cd .. && yarn jest --config=example/jest.config.js && cd example",
     "test:unit:u": "cd .. && yarn jest --config=example/jest.config.js -u && cd example",
     "test:unit:ci": "cd .. && yarn jest --config=example/jest.config.js --runInBand && cd example",

example/package.json

@@ -2,8 +2,7 @@ import React, { Component } from 'react';
 import { SignIn } from './canals/SignIn';
 import { FullScreenPortal } from 'react-gondola';
 
-interface IProps {}
-export default class App extends Component<IProps> {
+export default class App extends Component<{}> {
   render() {
     return (
       <FullScreenPortal>

example/src/App.tsx

@@ -1,8 +1,7 @@
 import React, { Component } from 'react';
 import { SignIn } from './SignIn';
 
-interface IProps {}
-export class Confirm extends Component<IProps> {
+export class Confirm extends Component<{}> {
   render() {
     return <SignIn />;
   }

example/src/canals/SignIn/Confirm.tsx

@@ -1,10 +1,20 @@
 import React, { Component } from 'react';
 import { StyleSheet, Text, View, Button, TextInput } from 'react-native';
 
-interface IProps {
+interface Props {
   onNext: () => any;
 }
-export class FirstName extends Component<IProps> {
+
+const styles = StyleSheet.create({
+  container: {
+    alignItems: 'center',
+    backgroundColor: '#FFAAAA',
+    flex: 1,
+    justifyContent: 'space-around',
+  },
+});
+
+export class FirstName extends Component<Props> {
   render() {
     return (
       <View style={styles.container}>
@@ -15,12 +25,3 @@ export class FirstName extends Component<IProps> {
     );
   }
 }
-
-const styles = StyleSheet.create({
-  container: {
-    alignItems: 'center',
-    backgroundColor: '#FFAAAA',
-    flex: 1,
-    justifyContent: 'space-around'
-  }
-});