🚧 (createStop) add transition prop

This also renames StopHOC into createStop.

Author: tpucci

src/StopValidator.ts

@@ -1,11 +1,14 @@
 import React, { ComponentType } from 'react';
 
+import { TransitionType } from './Transitions/Transition';
+
 export interface IStop<T extends string> {
   name: T;
   Component: ComponentType<any>;
   isFullScreen?: boolean;
   onBack?: () => any;
   props?: object;
+  transition?: TransitionType;
 }
 
 export class StopValidator {

src/Transitions/Transition.d.ts

@@ -0,0 +1 @@
+export type TransitionType = 'slide-right';

src/__tests__/StopHOC.test.tsx src/__tests__/createStop.test.tsxsrc/__tests__/StopHOC.test.tsx renamed to src/__tests__/createStop.test.tsx

@@ -3,15 +3,21 @@ import { of } from 'rxjs';
 import { View } from 'react-native';
 import TestRenderer from 'react-test-renderer';
 
-import { StopHOC } from '../StopHOC';
+import { createStop } from '../createStop';
 import { Navigation } from '../Navigation';
 
-describe('StopHOC', () => {
+describe('createStop', () => {
   it('creates a Component which pipes back events and filter them based on name', () => {
     const spy = jest.fn();
     const initialEvent = { target: 'myComponent' };
     const back$ = of(initialEvent);
-    const Stop = StopHOC({ back$ }, undefined, 'myComponent', View, undefined);
+    const Stop = createStop(
+      { back$ },
+      undefined,
+      'myComponent',
+      View,
+      undefined
+    );
     const testRenderer = TestRenderer.create(<Stop />);
     testRenderer.root.instance.back$.subscribe(spy);
     expect(spy).toHaveBeenCalledWith(initialEvent);
@@ -21,7 +27,13 @@ describe('StopHOC', () => {
     const spy = jest.fn();
     const initialEvent = { target: 'notMyComponent' };
     const back$ = of(initialEvent);
-    const Stop = StopHOC({ back$ }, undefined, 'myComponent', View, undefined);
+    const Stop = createStop(
+      { back$ },
+      undefined,
+      'myComponent',
+      View,
+      undefined
+    );
     const testRenderer = TestRenderer.create(<Stop />);
     testRenderer.root.instance.back$.subscribe(spy);
     expect(spy).not.toHaveBeenCalled();
@@ -35,7 +47,13 @@ describe('StopHOC', () => {
     );
     const initialEvent = { target: 'myComponent' };
     const back$ = of(initialEvent);
-    const Stop = StopHOC({ back$ }, onBackSpy, 'myComponent', View, undefined);
+    const Stop = createStop(
+      { back$ },
+      onBackSpy,
+      'myComponent',
+      View,
+      undefined
+    );
     const testRenderer = TestRenderer.create(<Stop />);
     testRenderer.root.instance.back$.subscribe();
     expect(setOnBackCallbackSpy).toHaveBeenCalledWith(onBackSpy);

src/createCanal.tsx

@@ -14,7 +14,7 @@ import { last } from './utils/Array.last';
 import { IBackEvent } from './Navigation/BackHandlerDelegate';
 import { withBackContext, WithBackContext } from './withBackContext';
 import { StopValidator, IStop } from './StopValidator';
-import { StopHOC } from './StopHOC';
+import { createStop } from './createStop';
 
 type CanalComponentProps<T> = {
   style?: StyleProp<ViewStyle>;
@@ -60,12 +60,13 @@ export const createCanal = <
 
     stopsList = stops.map(stop => ({
       ...stop,
-      Component: StopHOC(
+      Component: createStop(
         this,
         stop.onBack,
         stop.name,
         stop.Component,
-        stop.props
+        stop.props,
+        stop.transition
       )
     }));
     authorizations$ = new Subject<Authorizations>();

src/StopHOC.tsx src/createStop.tsxsrc/StopHOC.tsx renamed to src/createStop.tsx

@@ -8,13 +8,15 @@ import { View, StyleSheet } from 'react-native';
 import { filter, share, tap } from 'rxjs/operators';
 import { Navigation } from './Navigation';
 import { ICanal } from './createCanal';
+import { TransitionType } from './Transitions/Transition';
 
-export const StopHOC = (
+export const createStop = (
   canal: ICanal,
   onBack: (() => any) | undefined,
   name: string,
   Component: ComponentType,
-  props: object | undefined
+  props: object | undefined,
+  transition: TransitionType | undefined
 ) => {
   /**
    * @TODO 2019-07-26 Update @types/react once https://github.com/DefinitelyTyped/DefinitelyTyped/pull is merged.