pass SegmentKey by ref

Author: MarinPostma

libsql-wal/src/replication/storage.rs

@@ -48,7 +48,7 @@ where
         Box::pin(async_stream::try_stream! {
             loop {
                 let key = self.storage.find_segment(&self.namespace, current, None).await?;
-                let index = self.storage.fetch_segment_index(&self.namespace, key, None).await?;
+                let index = self.storage.fetch_segment_index(&self.namespace, &key, None).await?;
                 let mut pages = index.into_stream();
                 let mut maybe_seg = None;
                 while let Some((page, offset)) = pages.next() {
@@ -59,7 +59,7 @@ where
                         let segment = match maybe_seg {
                             Some(ref seg) => seg,
                             None => {
-                                maybe_seg = Some(self.storage.fetch_segment_data(&self.namespace, key, None).await?);
+                                maybe_seg = Some(self.storage.fetch_segment_data(&self.namespace, &key, None).await?);
                                 maybe_seg.as_ref().unwrap()
                             },
                         };

libsql-wal/src/storage/mod.rs

@@ -165,14 +165,14 @@ pub trait Storage: Send + Sync + 'static {
     async fn fetch_segment_index(
         &self,
         namespace: &NamespaceName,
-        key: SegmentKey,
+        key: &SegmentKey,
         config_override: Option<Arc<Self::Config>>,
     ) -> Result<Map<Arc<[u8]>>>;
 
     async fn fetch_segment_data(
         &self,
         namespace: &NamespaceName,
-        key: SegmentKey,
+        key: &SegmentKey,
         config_override: Option<Arc<Self::Config>>,
     ) -> Result<CompactedSegment<impl FileExt>>;
 }
@@ -232,7 +232,7 @@ impl Storage for NoStorage {
     async fn fetch_segment_index(
         &self,
         _namespace: &NamespaceName,
-        _key: SegmentKey,
+        _key: &SegmentKey,
         _config_override: Option<Arc<Self::Config>>,
     ) -> Result<Map<Arc<[u8]>>> {
         unimplemented!()
@@ -241,7 +241,7 @@ impl Storage for NoStorage {
     async fn fetch_segment_data(
         &self,
         _namespace: &NamespaceName,
-        _key: SegmentKey,
+        _key: &SegmentKey,
         _config_override: Option<Arc<Self::Config>>,
     ) -> Result<CompactedSegment<impl FileExt>> {
         unimplemented!();
@@ -388,7 +388,7 @@ impl<IO: Io> Storage for TestStorage<IO> {
     async fn fetch_segment_index(
         &self,
         namespace: &NamespaceName,
-        key: SegmentKey,
+        key: &SegmentKey,
         _config_override: Option<Arc<Self::Config>>,
     ) -> Result<Map<Arc<[u8]>>> {
         let inner = self.inner.lock();
@@ -408,7 +408,7 @@ impl<IO: Io> Storage for TestStorage<IO> {
     async fn fetch_segment_data(
         &self,
         namespace: &NamespaceName,
-        key: SegmentKey,
+        key: &SegmentKey,
         _config_override: Option<Arc<Self::Config>>,
     ) -> Result<CompactedSegment<impl FileExt>> {
         let inner = self.inner.lock();