Skip to content

Commit 66c012e

Browse files
- Updated changelog regarding npm i dependency issue fix.
- Noted area needing improvement in asset build script
1 parent 8eb89de commit 66c012e

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
2828
- Added public `getSprinklesPath` & `setSprinklesPath` to return or set the path to the sprinkle dir (`app/sprinkles/`)
2929
- Added `JsonException` if `sprinkles.json` doesn't contain valid json.
3030
- Added specific tests for sprinkleManager with 100% test coverage
31+
- Ignore existing `package-lock.json` which caused incorrect dependencies to be installed when upgrading from older versions of UserFrosting.
3132

3233
## 4.2.0-beta.1
3334

build/gulpfile.esm.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,7 @@ export function bundle() {
267267
* @param {string} path Absolute path to resolve.
268268
*/
269269
function resolveToAssetPath(path) {
270+
// TODO There is a significant amount of duplicated code here. We can do better.
270271
if (path.startsWith(resolvePath(sprinklesDir))) {
271272
// Handle sprinkle path
272273
for (const sprinkle of sprinkles) {

0 commit comments

Comments
 (0)