Fix issue with Symfony/Console throwing error when empty array is passed to writeln

Author: lcharette

app/sprinkles/core/src/Bakery/MigrateCommand.php

@@ -14,6 +14,7 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use UserFrosting\Sprinkle\Core\Bakery\Helper\ConfirmableTrait;
+use UserFrosting\Sprinkle\Core\Database\Migrator\Migrator;
 use UserFrosting\System\Bakery\BaseCommand;
 
 /**
@@ -79,13 +80,13 @@ protected function execute(InputInterface $input, OutputInterface $output)
         try {
             $migrated = $migrator->run(['pretend' => $pretend, 'step' => $step]);
         } catch (\Exception $e) {
-            $this->io->writeln($migrator->getNotes());
+            $this->displayNotes($migrator);
             $this->io->error($e->getMessage());
             exit(1);
         }
 
         // Get notes and display them
-        $this->io->writeln($migrator->getNotes());
+        $this->displayNotes($migrator);
 
         // If all went well, there's no fatal errors and we have migrated
         // something, show some success
@@ -128,4 +129,15 @@ protected function setupMigrator(InputInterface $input)
 
         return $migrator;
     }
+
+    /**
+     * Display migrator notes
+     * @param  Migrator $migrator
+     */
+    protected function displayNotes(Migrator $migrator)
+    {
+        if (!empty($notes = $migrator->getNotes())) {
+            $this->io->writeln($notes);
+        }
+    }
 }

app/sprinkles/core/src/Bakery/MigrateRefreshCommand.php

@@ -71,13 +71,13 @@ protected function execute(InputInterface $input, OutputInterface $output)
         try {
             $rolledback = $migrator->rollback(['pretend' => false, 'steps' => $steps]);
         } catch (\Exception $e) {
-            $this->io->writeln($migrator->getNotes());
+            $this->displayNotes($migrator);
             $this->io->error($e->getMessage());
             exit(1);
         }
 
         // Get notes and display them
-        $this->io->writeln($migrator->getNotes());
+        $this->displayNotes($migrator);
 
         // Stop if nothing was rolledback
         if (empty($rolledback)) {
@@ -88,7 +88,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // Run back up again
         $migrated = $migrator->run(['pretend' => false, 'step' => false]);
-        $this->io->writeln($migrator->getNotes());
+        $this->displayNotes($migrator);
 
         // If all went well, there's no fatal errors and we have migrated
         // something, show some success

app/sprinkles/core/src/Bakery/MigrateResetCommand.php

@@ -87,13 +87,13 @@ protected function performReset(InputInterface $input)
         try {
             $resetted = $migrator->reset($pretend);
         } catch (\Exception $e) {
-            $this->io->writeln($migrator->getNotes());
+            $this->displayNotes($migrator);
             $this->io->error($e->getMessage());
             exit(1);
         }
 
         // Get notes and display them
-        $this->io->writeln($migrator->getNotes());
+        $this->displayNotes($migrator);
 
         // Delete the repository
         if (!$pretend && $migrator->repositoryExists()) {

app/sprinkles/core/src/Bakery/MigrateRollbackCommand.php

@@ -80,13 +80,13 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 $migrated = $migrator->rollback(['pretend' => $pretend, 'steps' => $steps]);
             }
         } catch (\Exception $e) {
-            $this->io->writeln($migrator->getNotes());
+            $this->displayNotes($migrator);
             $this->io->error($e->getMessage());
             exit(1);
         }
 
         // Get notes and display them
-        $this->io->writeln($migrator->getNotes());
+        $this->displayNotes($migrator);
 
         // If all went well, there's no fatal errors and we have migrated
         // something, show some success