test: add test for date parsing

Author: bluwy

src/certificate-expiration.ts

@@ -27,11 +27,13 @@ function getCertificateExpirationDate(cert: X509Certificate): Date {
     return cert.validToDate
   }
 
-  // validTo is a nonstandard format: %s %2d %02d:%02d:%02d %d%s GMT
-  // https://github.com/nodejs/node/issues/52931
-  const [month, day, time, year] = cert.validTo
-    .split(' ')
-    .filter((part) => !!part)
+  return parseNonStandardDateString(cert.validTo)
+}
+
+// validTo is a nonstandard format: %s %2d %02d:%02d:%02d %d%s GMT
+// https://github.com/nodejs/node/issues/52931
+export function parseNonStandardDateString(str: string): Date {
+  const [month, day, time, year] = str.split(' ').filter((part) => !!part)
   // convert string month to number
   const monthIndex = MONTHS.indexOf(month) + 1
   return new Date(

test/test.spec.ts

@@ -1,7 +1,10 @@
 import { beforeEach, describe, test, expect, vi, Mock } from 'vitest'
 import { X509Certificate } from 'node:crypto'
 import { createCertificate } from '../src/certificate'
-import { isCertificateExpired } from '../src/certificate-expiration'
+import {
+  isCertificateExpired,
+  parseNonStandardDateString,
+} from '../src/certificate-expiration'
 
 test('create certificate', () => {
   const content = createCertificate()
@@ -31,7 +34,7 @@ describe('isCertificateExpired', () => {
       expect(isExpired).toBe(false)
     })
 
-     test('returns true', () => {
+    test('returns true', () => {
       validToDateMock.mockReturnValue(new Date(Date.now() - 10000))
 
       const content = createCertificate()
@@ -49,7 +52,7 @@ describe('isCertificateExpired', () => {
       const isExpired = isCertificateExpired(content)
       expect(isExpired).toBe(false)
     })
-    
+
     test('returns true', () => {
       validToDateMock.mockReturnValue(undefined)
       validToMock.mockReturnValue('Jan 22 08:20:44 2022 GMT')
@@ -60,3 +63,14 @@ describe('isCertificateExpired', () => {
     })
   })
 })
+
+test('parseNonStandardDateString', () => {
+  const content = createCertificate()
+  const cert = new X509Certificate(content)
+  const date = parseNonStandardDateString(cert.validTo)
+  expect(date).toBeInstanceOf(Date)
+  expect(date.getTime()).toBeGreaterThan(0)
+  if (cert.validToDate) {
+    expect(date.getTime()).toBe(cert.validToDate.getTime())
+  }
+})