Skip to content

Commit 580788d

Browse files
authored
fix(rsc): exclude react 3rd party libs from server optimizeDeps (#1119)
1 parent 377cfda commit 580788d

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

packages/plugin-rsc/examples/react-router/cf/vite.config.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,5 @@ export default defineConfig({
4040
include: ['react-router', 'react-router/internal/react-server-client'],
4141
},
4242
},
43-
ssr: {
44-
optimizeDeps: {
45-
exclude: ['react-router'],
46-
},
47-
},
48-
rsc: {
49-
optimizeDeps: {
50-
exclude: ['react-router'],
51-
},
52-
},
5343
},
5444
})

packages/plugin-rsc/src/plugin.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -486,6 +486,10 @@ export default function vitePluginRsc(
486486
PKG_NAME,
487487
...result.ssr.noExternal.sort(),
488488
]
489+
const optimizeDepsExclude = noExternal.filter(
490+
(pkg) =>
491+
!['react', 'react-dom', 'react-server-dom-webpack'].includes(pkg),
492+
)
489493
hasReactServerDomWebpack = result.ssr.noExternal.includes(
490494
'react-server-dom-webpack',
491495
)
@@ -542,7 +546,7 @@ export default function vitePluginRsc(
542546
'react-dom/static.edge',
543547
`${reactServerDomPackageName}/client.edge`,
544548
],
545-
exclude: [PKG_NAME],
549+
exclude: [PKG_NAME, ...optimizeDepsExclude],
546550
},
547551
},
548552
rsc: {
@@ -569,7 +573,7 @@ export default function vitePluginRsc(
569573
`${reactServerDomPackageName}/server.edge`,
570574
`${reactServerDomPackageName}/client.edge`,
571575
],
572-
exclude: [PKG_NAME],
576+
exclude: [PKG_NAME, ...optimizeDepsExclude],
573577
},
574578
},
575579
},

0 commit comments

Comments
 (0)