Skip to content

Commit 6fd58bf

Browse files
committed
keep same warning for alpha as previously (might do the same for RGB as well), this will be useful for hue in HSL, as the previous warning infer clipping which is not always the case
1 parent 4c579aa commit 6fd58bf

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

org/w3c/css/values/RGBA.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
import org.w3c.css.util.ApplContext;
1717
import org.w3c.css.util.InvalidParamException;
18-
import org.w3c.css.util.Util;
1918

2019
public class RGBA extends RGB {
2120
static final String functionname = "rgba";
@@ -35,15 +34,16 @@ public final void setAlpha(ApplContext ac, CssValue val)
3534
} else {
3635
if (val.getType() == CssTypes.CSS_NUMBER) {
3736
CssCheckableValue v = val.getCheckableValue();
38-
if (!v.warnPositiveness(ac, "RGBA")) {
37+
if (!v.isPositive()) {
38+
ac.getFrame().addWarning("out-of-range", val.toString());
3939
CssNumber nb = new CssNumber();
4040
nb.setIntValue(0);
4141
nv = nb;
4242
}
4343
if (val.getRawType() == CssTypes.CSS_NUMBER) {
4444
float p = ((CssNumber) val).getValue();
4545
if (p > 1.) {
46-
ac.getFrame().addWarning("out-of-range", Util.displayFloat(p));
46+
ac.getFrame().addWarning("out-of-range", val.toString());
4747
CssNumber nb = new CssNumber();
4848
nb.setIntValue(1);
4949
nv = nb;
@@ -52,15 +52,16 @@ public final void setAlpha(ApplContext ac, CssValue val)
5252
} else if (val.getType() == CssTypes.CSS_PERCENTAGE) {
5353
// This starts with CSS Color 4
5454
CssCheckableValue v = val.getCheckableValue();
55-
if (!v.warnPositiveness(ac, "RGB")) {
55+
if (!v.isPositive()) {
56+
ac.getFrame().addWarning("out-of-range", val.toString());
5657
CssNumber nb = new CssNumber();
5758
nb.setIntValue(0);
5859
nv = nb;
5960
}
6061
if (val.getRawType() == CssTypes.CSS_PERCENTAGE) {
6162
float p = ((CssPercentage) val).floatValue();
6263
if (p > 100.) {
63-
ac.getFrame().addWarning("out-of-range", Util.displayFloat(p));
64+
ac.getFrame().addWarning("out-of-range", val.toString());
6465
nv = new CssPercentage(100);
6566
}
6667
}

0 commit comments

Comments
 (0)