Extract states into a constant

Author: anapaulagomes

bcb/utils.py

@@ -8,6 +8,9 @@
    "SE": ["ES", "MG", "RJ", "SP"],
    "S": ["PR", "RS", "SC"]
 }
+BRAZILIAN_STATES = []
+for state in BRAZILIAN_REGIONS.values():
+    BRAZILIAN_STATES.extend(state)
 
 
 class Date:

tests/sgs/test_regional_economy.py

@@ -1,7 +1,7 @@
 import pandas as pd
 import pytest
 from bcb.sgs.regional_economy import get_non_performing_loans, get_non_performing_loans_codes
-from bcb.utils import BRAZILIAN_REGIONS
+from bcb.utils import BRAZILIAN_REGIONS, BRAZILIAN_STATES
 from bcb.sgs import regional_economy
 
 
@@ -48,15 +48,12 @@ def non_performing_constants(self):
         return constants
 
     def test_if_all_regions_and_states_are_there(self, non_performing_constants):
-        states = []
-        for state in BRAZILIAN_REGIONS.values():
-            states.extend(state)
         for item_str in non_performing_constants:
             item = getattr(regional_economy, item_str)
             if "REGION" in str(item):
                 assert (list(item.values()) == list(BRAZILIAN_REGIONS.keys())), item_str
             elif "STATE" in str(item):
-                assert (list(item.values()) == states), item_str
+                assert (list(item.values()) == BRAZILIAN_STATES), item_str
 
     def test_check_if_codes_are_unique(self, non_performing_constants):
         for item_str in non_performing_constants: