-
-
Notifications
You must be signed in to change notification settings - Fork 5
Expand file tree
/
Copy pathaddDestruct.spec.ts
More file actions
342 lines (308 loc) · 9.86 KB
/
addDestruct.spec.ts
File metadata and controls
342 lines (308 loc) · 9.86 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
import { fourslashLikeTester } from '../testing'
describe('Add destructure', () => {
describe('Basic cases', () => {
test('Same variable and accessor name', () => {
const initial = /* ts */ `
const /*t*/something/*t*/ = obj.something
`
const expected = /* ts */ `
const { something } = obj
`
const { codeAction } = fourslashLikeTester(initial, undefined, { dedent: true })
codeAction(0, {
refactorName: 'Add Destruct',
newContent: expected,
})
})
test('Different name', () => {
const initial = /* ts */ `
const /*t*/test/*t*/ = obj.something
`
const expected = /* ts */ `
const { something: test } = obj
`
const { codeAction } = fourslashLikeTester(initial, undefined, { dedent: true })
codeAction(0, {
refactorName: 'Add Destruct',
newContent: expected,
})
})
test('Multiple same prop extractions', () => {
const initial = /* ts */ `
const /*t*/props/*t*/ = {
source: {
type: Object,
required: true,
},
};
const test = props.source;
const test2 = props.source;
const test3 = props.source;
`
const expected = /* ts */ `
const { source } = {
source: {
type: Object,
required: true,
},
};
const test = source;
const test2 = source;
const test3 = source;
`
const { codeAction } = fourslashLikeTester(initial, undefined, { dedent: true })
codeAction(0, {
refactorName: 'Add Destruct',
newContent: expected,
})
})
})
describe('Works with types', () => {
test('Should preserve type', () => {
const initial = /* ts */ `
const /*t*/something/*t*/: number = anObject.something;
`
const { codeAction } = fourslashLikeTester(initial, undefined, { dedent: true })
const content = codeAction(
0,
{
refactorName: 'Add Destruct',
},
{},
{ compareContent: true },
)
expect(content).toMatchInlineSnapshot(`
"
const { something }: {
something: number;
} = anObject;
"
`)
})
})
test('Should convert `new` Expression', () => {
const { codeAction } = fourslashLikeTester(
/* ts */ `
const /*t*/something/*t*/ = new Foo().something;
`,
undefined,
{ dedent: true },
)
codeAction(0, {
refactorName: 'Add Destruct',
newContent: /* ts */ `
const { something } = new Foo();
`,
})
})
test('Should convert `await` Expression', () => {
const { codeAction } = fourslashLikeTester(
/* ts */ `
const /*t*/something/*t*/ = (await aPromise()).something;
`,
undefined,
{ dedent: true },
)
codeAction(0, {
refactorName: 'Add Destruct',
newContent: /* ts */ `
const { something } = (await aPromise());
`,
})
})
test('Should handle shorthandAssignment', () => {
const initial = /* ts */ `
const /*t*/newVariable/*t*/ = foo
const obj = {
tag: newVariable.tag,
}
`
const expected = /* ts */ `
const { tag } = foo
const obj = {
tag,
}
`
const { codeAction } = fourslashLikeTester(initial, undefined, { dedent: true })
codeAction(0, {
refactorName: 'Add Destruct',
newContent: expected,
})
})
test('Should destruct function params', () => {
const initial = /* ts */ `
function fn(/*t*/newVariable/*t*/) {
const something = newVariable.bar + newVariable.foo
}
`
const expected = /* ts */ `
function fn({ bar, foo }) {
const something = bar + foo
}
`
const { codeAction } = fourslashLikeTester(initial, undefined, { dedent: true })
codeAction(0, {
refactorName: 'Add Destruct',
newContent: expected,
})
})
test('Should work with name collisions', () => {
const { codeAction } = fourslashLikeTester(
/* ts */ `
function fn(/*t*/newVariable/*t*/) {
const bar = 4
const foo = 5
const something = newVariable.bar + newVariable.foo
}
`,
undefined,
{ dedent: true },
)
codeAction(0, {
refactorName: 'Add Destruct',
newContent: /* ts */ `
function fn({ bar: _bar, foo: _foo }) {
const bar = 4
const foo = 5
const something = _bar + _foo
}
`,
})
})
describe('Works with inline object', () => {
const expected = /* ts */ `
const { foo } = {
foo: 1,
}
foo
`
test('Cursor position on object variable declaration', () => {
const cursorOnObjVarDecl = /* ts */ `
const /*t*/a/*t*/ = {
foo: 1,
}
a.foo
`
const { codeAction } = fourslashLikeTester(cursorOnObjVarDecl, undefined, { dedent: true })
codeAction(0, {
refactorName: 'Add Destruct',
newContent: expected,
})
})
})
describe('Handles reserved words', () => {
test('Makes unique identifier for reserved word', () => {
const initial = /* ts */ `
const /*t*/a/*t*/ = {
class: 1,
}
a.class
`
const expected = /* ts */ `
const { class: _class } = {
class: 1,
}
_class
`
const { codeAction } = fourslashLikeTester(initial, undefined, { dedent: true })
codeAction(0, {
refactorName: 'Add Destruct',
newContent: expected,
})
})
})
describe('Should handle `this` keyword destructure', () => {
test('Basic `this` destructure', () => {
const initial = /* ts */ `
const obj = {
foo() {
const a = /*t*/this.a/*t*/
}
}
`
const expected = /* ts */ `
const obj = {
foo() {
const { a } = this
}
}
`
const { codeAction } = fourslashLikeTester(initial, undefined, { dedent: true })
codeAction(0, {
refactorName: 'Add Destruct',
newContent: expected,
})
})
})
test('Adds destructure to argument of call expression', () => {
const initial = /* ts */ `
const /*t*/newVariable/*t*/ = { test: 1 }
const obj = {
tag: foo.map(newVariable.test),
}
`
const expected = /* ts */ `
const { test } = { test: 1 }
const obj = {
tag: foo.map(test),
}
`
const { codeAction } = fourslashLikeTester(initial, undefined, { dedent: true })
codeAction(0, {
refactorName: 'Add Destruct',
newContent: expected,
})
})
describe('Skip cases', () => {
test('Should skip if trying to destruct expression of call expression', () => {
const initial = /* ts */ `
const /*t*/newVariable/*t*/ = foo
const obj = {
tag: newVariable.map(() => 10),
}
`
const { codeAction } = fourslashLikeTester(initial, undefined, { dedent: true })
codeAction(0, {
refactorName: 'Add Destruct',
newContent: null,
})
})
test('Should skip if cursor is on accessor', () => {
const cursorOnAccessor = /* ts */ `
const a = {
foo: 1,
}
a./*t*/foo/*t*/
`
const { codeAction } = fourslashLikeTester(cursorOnAccessor, undefined, { dedent: true })
codeAction(0, {
refactorName: 'Add Destruct',
newContent: null,
})
})
test('Should skip optional chain', () => {
const initial = /* ts */ `
const /*t*/something/*t*/ = aProperty?.something;
`
const { codeAction } = fourslashLikeTester(initial, undefined, { dedent: true })
codeAction(0, {
refactorName: 'Add Destruct',
newContent: null,
})
})
test('Should skip typeof operator', () => {
const initial = /* ts */ `
const /*t*/obj/*t*/ = {
test: 1,
}
obj.test
type foo = typeof obj;
`
const { codeAction } = fourslashLikeTester(initial, undefined, { dedent: true })
codeAction(0, {
refactorName: 'Add Destruct',
newContent: null,
})
})
})
})