Sema: improve struct/union field error locations

Closes #14206

Author: Vexu

src/Sema.zig

@@ -29,9 +29,9 @@ export fn d() void {
 // backend=stage2
 // target=native
 //
-// :3:5: error: opaque types have unknown size and therefore cannot be directly embedded in structs
+// :3:8: error: opaque types have unknown size and therefore cannot be directly embedded in structs
 // :1:11: note: opaque declared here
-// :7:5: error: opaque types have unknown size and therefore cannot be directly embedded in unions
+// :7:10: error: opaque types have unknown size and therefore cannot be directly embedded in unions
 // :19:18: error: opaque types have unknown size and therefore cannot be directly embedded in structs
 // :18:22: note: opaque declared here
 // :24:23: error: opaque types have unknown size and therefore cannot be directly embedded in structs

test/cases/compile_errors/directly_embedding_opaque_type_in_struct_and_union.zig

@@ -39,7 +39,7 @@ export fn entry() void {
 // backend=stage2
 // target=native
 //
-// :31:5: error: extern structs cannot contain fields of type 'tmp.E'
-// :31:5: note: enum tag type 'u9' is not extern compatible
-// :31:5: note: only integers with power of two bits are extern compatible
+// :31:8: error: extern structs cannot contain fields of type 'tmp.E'
+// :31:8: note: enum tag type 'u9' is not extern compatible
+// :31:8: note: only integers with power of two bits are extern compatible
 // :1:15: note: enum declared here

test/cases/compile_errors/extern_struct_with_extern-compatible_but_inferred_integer_tag_type.zig

@@ -11,7 +11,7 @@ export fn entry() void {
 // backend=stage2
 // target=native
 //
-// :3:5: error: extern structs cannot contain fields of type 'tmp.E'
-// :3:5: note: enum tag type 'u31' is not extern compatible
-// :3:5: note: only integers with power of two bits are extern compatible
+// :3:8: error: extern structs cannot contain fields of type 'tmp.E'
+// :3:8: note: enum tag type 'u31' is not extern compatible
+// :3:8: note: only integers with power of two bits are extern compatible
 // :1:15: note: enum declared here

test/cases/compile_errors/extern_struct_with_non-extern-compatible_integer_tag_type.zig

@@ -0,0 +1,17 @@
+const Parser = @This();
+fn Chunk() type {
+    return struct {
+        const Self = @This();
+    };
+}
+parser_chunk: Chunk,
+
+comptime {
+    _ = @sizeOf(@This()) + 1;
+}
+
+// error
+// backend=stage2
+// target=native
+//
+// :7:15: error: expected type 'type', found 'fn() type'

test/cases/compile_errors/file_level_struct_invalid_field_type.zig

@@ -7,5 +7,5 @@ export fn testf(fluff: *stroo) void { _ = fluff; }
 // backend=stage2
 // target=native
 //
-// :2:5: error: extern structs cannot contain fields of type '?[*c]u8'
-// :2:5: note: only pointer like optionals are extern compatible
+// :2:10: error: extern structs cannot contain fields of type '?[*c]u8'
+// :2:10: note: only pointer like optionals are extern compatible

test/cases/compile_errors/invalid_optional_type_in_extern_struct.zig

@@ -9,4 +9,4 @@ comptime {
 // backend=stage2
 // target=native
 //
-// :2:5: error: struct fields cannot be 'noreturn'
+// :2:8: error: struct fields cannot be 'noreturn'

test/cases/compile_errors/noreturn_struct_field.zig

@@ -12,9 +12,9 @@ comptime {
 // backend=stage2
 // target=native
 //
-// :2:5: error: extern structs cannot contain fields of type 'fn() callconv(.C) void'
-// :2:5: note: type has no guaranteed in-memory representation
-// :2:5: note: use '*const ' to make a function pointer type
+// :2:8: error: extern structs cannot contain fields of type 'fn() callconv(.C) void'
+// :2:8: note: type has no guaranteed in-memory representation
+// :2:8: note: use '*const ' to make a function pointer type
 // :8:13: error: C pointers cannot point to non-C-ABI-compatible type '[4]fn() callconv(.C) void'
 // :8:13: note: type has no guaranteed in-memory representation
 // :8:13: note: use '*const ' to make a function pointer type

test/cases/compile_errors/old_fn_ptr_in_extern_context.zig

@@ -70,22 +70,22 @@ export fn entry12() void {
 // backend=llvm
 // target=native
 //
-// :3:9: error: packed structs cannot contain fields of type 'anyerror'
-// :3:9: note: type has no guaranteed in-memory representation
-// :8:9: error: packed structs cannot contain fields of type '[2]u24'
-// :8:9: note: type has no guaranteed in-memory representation
-// :13:9: error: packed structs cannot contain fields of type 'anyerror!u32'
-// :13:9: note: type has no guaranteed in-memory representation
-// :18:9: error: packed structs cannot contain fields of type 'tmp.S'
-// :18:9: note: only packed structs layout are allowed in packed types
+// :3:12: error: packed structs cannot contain fields of type 'anyerror'
+// :3:12: note: type has no guaranteed in-memory representation
+// :8:12: error: packed structs cannot contain fields of type '[2]u24'
+// :8:12: note: type has no guaranteed in-memory representation
+// :13:20: error: packed structs cannot contain fields of type 'anyerror!u32'
+// :13:20: note: type has no guaranteed in-memory representation
+// :18:12: error: packed structs cannot contain fields of type 'tmp.S'
+// :18:12: note: only packed structs layout are allowed in packed types
 // :56:11: note: struct declared here
-// :23:9: error: packed structs cannot contain fields of type 'tmp.U'
-// :23:9: note: only packed unions layout are allowed in packed types
+// :23:12: error: packed structs cannot contain fields of type 'tmp.U'
+// :23:12: note: only packed unions layout are allowed in packed types
 // :59:18: note: union declared here
-// :28:9: error: packed structs cannot contain fields of type '?anyerror'
-// :28:9: note: type has no guaranteed in-memory representation
-// :38:9: error: packed structs cannot contain fields of type 'fn() void'
-// :38:9: note: type has no guaranteed in-memory representation
-// :38:9: note: use '*const ' to make a function pointer type
-// :65:28: error: packed structs cannot contain fields of type '[]u8'
-// :65:28: note: slices have no guaranteed in-memory representation
+// :28:12: error: packed structs cannot contain fields of type '?anyerror'
+// :28:12: note: type has no guaranteed in-memory representation
+// :38:12: error: packed structs cannot contain fields of type 'fn() void'
+// :38:12: note: type has no guaranteed in-memory representation
+// :38:12: note: use '*const ' to make a function pointer type
+// :65:31: error: packed structs cannot contain fields of type '[]u8'
+// :65:31: note: slices have no guaranteed in-memory representation

test/cases/compile_errors/packed_struct_with_fields_of_not_allowed_types.zig

@@ -15,6 +15,6 @@ export fn entry() void {
 // backend=stage2
 // target=native
 //
-// :6:5: error: packed unions cannot contain fields of type 'tmp.Foo'
-// :6:5: note: only packed structs layout are allowed in packed types
+// :6:8: error: packed unions cannot contain fields of type 'tmp.Foo'
+// :6:8: note: only packed structs layout are allowed in packed types
 // :1:13: note: struct declared here