chore: sqlite framework#2265
Open
SantiagoPittella wants to merge 1 commit into
Open
Conversation
31dc8cc to
a954f57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2248 and #2249
Summary
Introduces a light SQLite framework in crates/db (
miden-node-db) and migrates the validator onto it, removing Diesel. It handles a connection pool, type-enforced read/write transactions, always-cached queries, a type codec, and cacheable IN-list helpers.handle:
read(...)gives you aReadTx. It begins a read-only transaction that is never committed, sonothing it does can persist.
write(...)gives you aWriteTx. It begins a write transaction.query_rows,query_opt,query_one,exists,countandexecute(write only). Every one of them prepares its statement through SQLite's cache.The usage is like this:
Changelog