feat(decisions): ask_user tool with inline TUI chooser and selected-option display by alecuba16 · Pull Request #1815 · 1jehuang/jcode

alecuba16 · 2026-10-13T00:21:18Z

Adds an ask_user tool the agent can call when it needs a structured choice mid-turn. The TUI renders an inline chooser with digit shortcuts, free-form fallback, and a timeout auto-pick; the reply names the option the user actually picked (label + value) instead of a generic verb. Feature is behind features.decisions with a configurable decision_timeout_secs. Builds on the protocol discussed in #1600 (the original proposal thread), where the squashed branch was offered for review.

Tests: ask_user suite 10/10, decision chooser suite 31/31, fmt/clippy clean on the squashed commit.
Closes #1600.

greptile-apps · 2026-10-13T00:43:23Z

Confidence Score: 4/5

[High impact] The PR adds a user-facing choice flow and changes an operator-run telemetry data migration.

Do not merge yet: batched questions can still stop blocking, and the required narrow-terminal fixes remain outstanding.

Findings

Batched questions stop blocking ▶
Failed reply looks successful ▶
Worker details disappear ▶
Key hints get cut off ▶
Network errors stop the move ▶
Wrapped answers lose indentation ▶
Locked input text gets clipped ▶
Coverage hides missing decision support ▶

Fix with agent prompt

### Issue 1
crates/jcode-tool-core/src/lib.rs:undefined-170
Passing the decision channel to batch children lets `ask_user` wait inside `batch`, but the parent still moves to the background after the default three seconds. The backgrounding policy checks only the parent name, so the exception for `ask_user` does not apply.

With no answer sent, the agent continued and finished its turn while the question was still waiting. Turn completion then removed the unanswered chooser. Keep batches containing `ask_user` in the foreground, or reject that combination, before merging.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

### Issue 2
crates/jcode-tui/src/tui/app/decision.rs:83-89
If sending an answer fails, `send_decision_answer` shows an error but returns normally. Its callers then record “you picked” or “you answered” and replace the failure status notice with “Answered”. The chooser and draft also disappear because the decision was already taken. This is a non-blocking recovery concern: return the send result, record an answer only on success, and keep the draft when sending fails.

### Issue 3
crates/jcode-tui-render/src/swarm_gallery.rs:1086-1089
Removing the per-worker metadata from `render_swarm_strip_vertical` hides elapsed time, context usage, model and effort, output-token counts, and provider/auth route from compact worker rows. Rendering at 180 columns confirmed that these details disappear despite ample room. This affects both unfocused rows and unselected compact workers while another worker is expanded; the selected expanded view still retains some details.

This is a non-blocking display regression. Restore the metadata and its width-based trimming so users can inspect compact workers without opening each one.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

### Issue 4
crates/jcode-tui/src/tui/ui_inline.rs:374-376
The chooser passes its full key hint to `Paragraph` without trimming it. In narrow terminals, the hint gets cut off without an ellipsis. The repository guide requires compact UI rows to fit their available display width or end with an ellipsis, so this repository requirement must be satisfied before merging.

Use `decision_truncate_display(hint, inner.width as usize)` here. The empty-answer hint has the same problem.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

### Issue 5
telemetry-worker/scripts/move-bulk-events.mjs:30-34
Removing the `try/catch` around `fetch` makes a single dropped connection stop the entire bulk move. The retry loop now handles only requests that return a response; network errors escape it.

This is a non-blocking recovery concern: completed work is safe to resume, but an operator must restart the move. Restore the bounded network retries.

### Issue 6
crates/jcode-tui/src/tui/ui_inline.rs:135-140
When a pasted answer contains indented lines longer than the wrap width, `wrap_paragraph_into_rows` drops their leading spaces. The chooser then shows different code or structured text from the answer it sends. This is a non-blocking display concern: preserve whitespace while wrapping so users can check the actual answer before submitting.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

### Issue 7
crates/jcode-tui/src/tui/ui_input.rs:2192-2194
The locked input message reaches `Paragraph` without being shortened. In narrow terminals, it gets cut off without an ellipsis. The repository guide requires compact UI rows to fit their available display width or end with an ellipsis, so this requirement must be satisfied before merging.

Shorten the complete line, including its prompt number, to `area.width` before drawing it.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

### Issue 8
crates/jcode-harness-api/src/harness_api_tests/capability_coverage.rs:undefined-56
`DecisionResponse` is marked `Covered`, which means clients can reach it through the harness API. But `ApiRequest` has no matching request, the bridge has no decision handler, and clients cannot opt into decisions. The coverage check therefore passes while this API feature is missing.

This is a non-blocking coverage concern. Mark it `Gap` with a reason, or implement the missing API path.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds ask_user with an inline chooser, free-form answers, optional timeout, and selected-answer display.

The agent can pause for a user’s choice and continue with the answer.
Slow terminal color replies can finish without being treated as stray input.
Compact swarm rows show less worker detail beside each task.
The telemetry migration script moves event families one at a time.
Platform-specific helpers and housekeeping edits leave their related workflows unchanged.

Diagram

sequenceDiagram
    participant Agent
    participant Tool as ask_user
    participant Server
    participant TUI
    Agent->>Tool: Question and options
    Tool->>Server: DecisionInputRequest
    Server->>TUI: DecisionRequest
    TUI->>Server: DecisionResponse
    Server->>Tool: Selected option or text
    Tool->>Agent: Answer with selected label and detail

_{Reviews (39) · Last reviewed commit: "chore(budgets): refresh ratchet baseline..." · Reviewed by Greptile}

greptile-apps · 2026-10-13T00:43:26Z

+                    self.send_decision_answer(
+                        &decision.request_id,
+                        DecisionChoice::Option { index },
+                        remote,
+                    )
+                    .await;
+                    self.record_decision_answer(&decision, "picked");


Failed reply looks successful

If sending an answer fails, send_decision_answer shows an error but returns normally. Its callers then record “you picked” or “you answered” and replace the failure status notice with “Answered”. The chooser and draft also disappear because the decision was already taken. This is a non-blocking recovery concern: return the send result, record an answer only on success, and keep the draft when sending fails.

_{Ran code and verified through T-Rex}

Prompt To Fix With AI

This is a comment left during a code review. Path: crates/jcode-tui/src/tui/app/decision.rs Line: 83-89 Comment: **Failed reply looks successful** If sending an answer fails, `send_decision_answer` shows an error but returns normally. Its callers then record “you picked” or “you answered” and replace the failure status notice with “Answered”. The chooser and draft also disappear because the decision was already taken. This is a non-blocking recovery concern: return the send result, record an answer only on success, and keep the draft when sending fails. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fixed: send_decision_answer returns bool and callers only record the "you picked/answered" message when the send succeeded. On failure the chooser and draft stay open for retry and the error notice is not overwritten (regression test: failed_decision_send_pushes_an_error_message).

greptile-apps · 2026-11-02T19:22:11Z

            ),
            working_dir: self.working_dir.clone(),
            stdin_request_tx: self.stdin_request_tx.clone(),
+            decision_request_tx: self.decision_request_tx.clone(),


Batched questions stop blocking

Passing the decision channel to batch children lets ask_user wait inside batch, but the parent still moves to the background after the default three seconds. The backgrounding policy checks only the parent name, so the exception for ask_user does not apply.

With no answer sent, the agent continued and finished its turn while the question was still waiting. Turn completion then removed the unanswered chooser. Keep batches containing ask_user in the foreground, or reject that combination, before merging.

Artifacts

Server and agent regression runner

The authored runner executes comparable socket regressions with child decision-channel propagation disabled and enabled, then restores its temporary source edits.

Executed server and agent test source

The executed Rust harness uses a fake provider with the real server, streaming agent, batch, and ask_user tools to observe whether the turn finishes before an answer.

Socket behavior without child decision-channel propagation

The control run captures the chooser-unavailable fallback, provider continuation, and turn completion with no waiting decision, establishing the comparison.

Head socket behavior with an unanswered batch decision

The head run captures a real chooser followed by automatic backgrounding after 3 seconds and turn completion while ask_user still waits, confirming the defect.

Captured-event replay runner

The authored runner executes the actual TUI handler against both socket captures and restores its temporary test registration.

Executed chooser replay test source

The executed Rust test replays captured decision and completion events through the real TUI handler and asserts the resulting chooser state.

TUI replay without a nested chooser

The control replay completes with no chooser before or after turn completion, matching the socket control.

TUI replay removing the unanswered head chooser

The head replay keeps the chooser through parent tool completion but removes it on turn completion, confirming the user-visible consequence.

Relevant source and clean tracked-file verification

The final command capture records the exact head, relevant source lines, empty tracked diff, and removal of temporary test modules, verifying restoration.

_{Ran code and verified through TREX}

Prompt To Fix With AI

This is a comment left during a code review. Path: crates/jcode-tool-core/src/lib.rs Line: 170 Comment: **Batched questions stop blocking** Passing the decision channel to batch children lets `ask_user` wait inside `batch`, but the parent still moves to the background after the default three seconds. The backgrounding policy checks only the parent name, so the exception for `ask_user` does not apply. With no answer sent, the agent continued and finished its turn while the question was still waiting. Turn completion then removed the unanswered chooser. Keep batches containing `ask_user` in the foreground, or reject that combination, before merging. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

greptile-apps · 2026-11-03T00:20:17Z

+    for word in paragraph.split(' ') {
+        let word_width = inline_view_display_width(word);
+        if row_width > 0 && row_width + 1 + word_width <= width {
+            row.push(' ');
+            row.push_str(word);
+            row_width += 1 + word_width;


Wrapped answers lose indentation

When a pasted answer contains indented lines longer than the wrap width, wrap_paragraph_into_rows drops their leading spaces. The chooser then shows different code or structured text from the answer it sends. This is a non-blocking display concern: preserve whitespace while wrapping so users can check the actual answer before submitting.

Artifacts

▶ Chooser rendering on the supplied head

Chromium displays the actual Ratatui buffer and received Enter submission on unchanged head, showing that the wrapped line loses four visible spaces while the submitted text retains them.

▶ Chooser rendering with the temporary diagnostic fix

Chromium displays the same executed test with temporary leading-space preservation, showing aligned interior lines and unchanged submitted text.

Supplied-head recording poster

The poster captures the unchanged-head buffer and observed submission, exposing the mismatch between rendered indentation and sent text.

Diagnostic-fix recording poster

The poster captures the diagnostic-fix buffer and observed submission, showing that preserving leading spaces resolves this rendering mismatch.

Rust test output on the supplied head

The captured Cargo output includes the command, working directory, exit code, actual buffer rows, column assertions, and received request, confirming the defect on head.

Rust test output with the diagnostic fix

The captured Cargo output includes the same execution details after temporary indentation preservation, confirming aligned rendering without changing submission.

Captured head buffer and transport request

The executed Rust test serialized its actual buffer rows, measured columns, pasted input, and received request, preserving machine-readable evidence of the mismatch.

Captured diagnostic-fix buffer and transport request

The executed Rust test serialized the same observations with temporary indentation preservation, preserving machine-readable evidence of the corrected alignment.

Executed Rust regression test source

This exact authored test was temporarily appended to decision_tests.rs and executed in both conditions, exercising paste, real rendering, Enter handling, and transport receipt.

Executed Rust test runner and restoration script

This executed script installs the test temporarily, runs both conditions, captures output, and restores original source bytes in a finally block.

Temporary diagnostic indentation patch

The captured Git diff records the exact temporary wrapping change used for the after run, making clear that it was diagnostic and not retained.

Executed Chromium video capture source

This executed Playwright script presents the captured runtime data and records comparable before and after videos, emphasizing the affected lines.

Chromium capture command output

The captured command output records successful creation of both videos and posters, confirming that browser capture executed.

Source locations and clean tracked-diff check

The captured Git and numbered-source output identifies the implicated lines and confirms that no tracked changes remain.

_{Ran code and verified through TREX}

Prompt To Fix With AI

This is a comment left during a code review. Path: crates/jcode-tui/src/tui/ui_inline.rs Line: 135-140 Comment: **Wrapped answers lose indentation** When a pasted answer contains indented lines longer than the wrap width, `wrap_paragraph_into_rows` drops their leading spaces. The chooser then shows different code or structured text from the answer it sends. This is a non-blocking display concern: preserve whitespace while wrapping so users can check the actual answer before submitting. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

greptile-apps · 2026-11-03T16:36:29Z

+    let line = Line::from(spans);
+    let paragraph = if app.centered_mode() {
+        Paragraph::new(line.alignment(Alignment::Center)).alignment(Alignment::Center)


Locked input text gets clipped

The locked input message reaches Paragraph without being shortened. In narrow terminals, it gets cut off without an ellipsis. The repository guide requires compact UI rows to fit their available display width or end with an ellipsis, so this requirement must be satisfied before merging.

Shorten the complete line, including its prompt number, to area.width before drawing it.

Context Used: AGENTS.md (source)

Prompt To Fix With AI

This is a comment left during a code review. Path: crates/jcode-tui/src/tui/ui_input.rs Line: 2173-2175 Comment: **Locked input text gets clipped** The locked input message reaches `Paragraph` without being shortened. In narrow terminals, it gets cut off without an ellipsis. The repository guide requires compact UI rows to fit their available display width or end with an ellipsis, so this requirement must be satisfied before merging. Shorten the complete line, including its prompt number, to `area.width` before drawing it. **Context Used:** AGENTS.md ([source](https://github.com/1jehuang/jcode/blob/master/AGENTS.md)) --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

greptile-apps · 2026-11-04T07:43:04Z

    ("Compact", Covered),
    ("ConfigureTools", Covered),
    ("CycleModel", ClientInternal),
+    ("DecisionResponse", Covered),


Coverage hides missing decision support

DecisionResponse is marked Covered, which means clients can reach it through the harness API. But ApiRequest has no matching request, the bridge has no decision handler, and clients cannot opt into decisions. The coverage check therefore passes while this API feature is missing.

This is a non-blocking coverage concern. Mark it Gap with a reason, or implement the missing API path.

Prompt To Fix With AI

This is a comment left during a code review. Path: crates/jcode-harness-api/src/harness_api_tests/capability_coverage.rs Line: 56 Comment: **Coverage hides missing decision support** `DecisionResponse` is marked `Covered`, which means clients can reach it through the harness API. But `ApiRequest` has no matching request, the bridge has no decision handler, and clients cannot opt into decisions. The coverage check therefore passes while this API feature is missing. This is a non-blocking coverage concern. Mark it `Gap` with a reason, or implement the missing API path. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Master tip 7c69754 fails its own Format and Quality Guardrails checks: 15 files carry rustfmt drift (app-core server/timing, jcode-core stdin_detect, ratatui-core span/fast, tui status_tests, cloud_runtime) and the swallowed-error plus test-size ratchets fell behind current source. Same recipe as the maintainer's own 025d879 fix, applied against the current tip.

libc 0.2.191 declares openpty with *mut winsize; the pty test helper passed a null const-pointer and a shared reference, so the jcode-tui test build fails to compile on the current master tip.

- rendering.rs: upstream added token counts to file_activity rows, update the render assert to the new expected text - frame_flicker.rs: copy badge label is platform-dependent (opt glyph on macos), assert via copy_badge_alt_label() instead of a literal - idle_hibernation.rs: 'private mem' notice only renders when the host exposes process memory snapshots (linux/windows); keep that assert conditional on measurement availability so the frozen-frame test passes on macos too

- prompt_tests: DEFAULT_SWARM_PROMPT grew to 1041 bytes with b82768c's coordination guidance, raise the stale 600-char budget to 1200 - platform_tests: use getsid(2) on a live detached child instead of parsing 'ps -o sid=' which does not exist on BSD ps (macOS) - session_tests: scope the pmset streaming-assertion checks to this process, an ambient jcode daemon legitimately holds assertions - tool/tests: exempt macos_computer_use and the new todo/session_search params from the token caps, matching the existing exemption pattern - browser.rs: restore intent_schema_property() in the browser schema, a5a1746's trim left a bare {type: string} and broke the display-only intent guard - compile_remote: skip the non-utf8 filename test when the filesystem itself refuses invalid-UTF-8 names (APFS) - client_lifecycle_tests: message 78 carries user-shaped content, so e6d9cb4 runs it as a real turn and the invalid skill terminal-errors instead of the old Done replay suppression - browser_session_tests: measure responsiveness from the confirmed stall, daemon spawn cost on a loaded host must not count - provider_init_tests: clear ambient JCODE_OPENROUTER_*/profile env and third-party compatible provider keys so auto-detect stays isolated - commands_tests: a bare IP is loopback-like since 1jehuang#2018, pin the new requires_api_key contract - onboarding_flow: guard JCODE_INITIAL_PROVIDER_EXPLICIT the same way the strongest-model unit test does, an agent session exports it and it leaks into the first-run preference assert

A fragmented OSC 11 reply (ESC ] 11;rgb: ...) can take longer than the 250ms stray-input timeout to spell out its whole introducer over ssh or a slow pty. Expiry measured from the first held byte, so the half-built report was replayed as ordinary keys (bare Esc, ']', digits) before it could finish; the pty test caught it because the synthesized theme Resize never became the first event. Track when the last report byte was held and measure the window from that. A stalled fragment still replays on the same short clock, so a genuine lone Escape outside a query is not delayed. The recognized REPORT_TIMEOUT path is unchanged.

Upstream tip is red across its own quality guardrails under the current stable toolchain. The workspace lints vendored ratatui-core/-widgets, so its new clippy findings block everything: - ratatui-core buffer.rs: drop the redundant & in the Debug impl; the current clippy flags it as useless_borrows_in_formatting - ratatui-core span.rs: clippy now exempts deprecated methods from wrong_self_convention, so the three #[expect]s are unfulfilled and fail under -D warnings; drop them. The ASCII fast path slices per byte, which string_slice flags, but is_printable_ascii guarantees each byte is a standalone char; allow it at the binding with the invariant stated - ratatui-widgets paragraph.rs: b7ca4ec's direct row blit removed the last UnicodeWidthStr use, drop the dead import - ratatui-widgets sparkline.rs: use checked_div for the zero-max guard with the original evaluation order preserved - ratatui-widgets reflow.rs: truncate(0) is now manual_clear, use clear - jcode-voice: allow type_complexity on the focused-session cache static, same pattern as the four existing allows in the workspace Budgets: the tip also drifted past its own ratchets. Refresh warning_budget.txt (0 -> 32) and the test-size baselines for the five test files the earlier fixes grew; both are mechanical --update runs, the deltas are upstream's own code plus the test guards this branch adds.

The tip's clippy gate fails on three fronts under the current stable toolchain; this clears them all so the workspace passes cargo clippy --all-targets --all-features -- -D warnings with zero findings and the cargo-check warning count drops to zero. - transcript_search: 25 needless borrows on the search-shard arguments, mechanical clippy --fix - tui_state: redundant closure replaced by the function path - app-core: drop the child_pid binding c5c6ad8 orphaned, take the format_error_chain path directly, and unwrap schedule_queued_retry's vestigial loop whose body always returns - companion: allow too_many_arguments on terminal_command_from_parts, same as the three existing allows elsewhere - binary_watch: allow needless_return on ensure_started, the early return is the once-only guard and clippy misreads the cfg block below as the function tail - communicate: mark the three coordination predicates dead-code-exempt outside tests; 92ca181 inlined their production use and the unit tests keep them pinned - cloud_git: the probe loop helpers are cfg(not(test)) so nothing reaches them in the test build, exempt dead_code there only - session picker preview path: the live layout rework orphaned several helpers while the preview tests kept calling them (draw/draw_widgets/ draw_preview_input and the per-source preview loaders); exempt dead_code outside tests for those, plain allow for the ones the rework orphaned outright, and restore the markdown/raw-excerpt re-exports as cfg(test) imports the tests actually use - canvas/filter: move the impl blocks above their test modules so no items sit after a cfg(test) module, keeping the cfg attrs intact - ui_prepare: the too_many_arguments expect sat above the wrong fn (a doc comment separated it from shrink_wrapped_lines); reattach it to wrap_lines_with_map - tests: apply the cloned_ref_to_slice_refs and clone_on_copy suggestions, drop the fully-specified AccountPool's needless struct update - budgets: re-pin warning_budget to 0 (all 32 warnings were these findings) and refresh the size ratchets the new attribute lines grew

CI compiles the workspace for x86_64/aarch64-pc-windows-msvc; four unix patterns leaked past the cfg surface on the tip and failed those jobs: - jcode-voice dictation: the niri IPC socket fast path uses std::os::unix::net::UnixStream without a cfg, so the windows targets failed E0433. Gate the helper and its call like the neighboring send_transcript_blocking already does. - cli cloud_managed_tests: the linux-only shell fixture module uses Path, but the import lived at file scope where the mac clippy sweep (which does not compile the module) read it as unused. Restore the import gated to the module's own cfg. - jcode-base auth transfer: cloud_store/identity_hints/cloud_expiry are only reached from cfg(unix) blocks; dead on windows, so gate them. - jcode-base cloud_environment: Write is only used by the unix staging paths; import it cfg(unix) so the windows build has no unused import. - jcode-base mcp oauth: secret_options mutates only on unix; move the binding inside the unix branch so windows sees no needless mut.

The cfg gates on the four cloud-store helpers let the windows targets compile, but transfer.rs is a code-size-budget tracked file that may not grow, and the attrs pushed it over the ratchet. Move the helpers into a unix-only child module so the gates live once on the module instead of per fn, and the oversized file shrinks (2185 -> 2112 LOC). Callers are unchanged; helpers keep their signatures and are pub(super) re-imported.

…gelog updates box the test asserted no picker metadata (including box borders) in the preview transcript, but the startup header renders an Updates box from unseen changelog entries, which on a fresh CI runner is always non-empty (no last_seen_changelog state file). take the render-state lock and force the unseen entries override to empty, matching the pattern already used by the other render tests

the hermeticity fix added 6 lines to an already-oversized tracked test file, tripping the test-size ratchet. extract nothing, just reuse the production line_plain_text helper instead of an inline span-join closure and tighten the comment; net line count back to the baseline

…ption display

The branch carried pre-uplift baseline values for the size and safety budgets. Restore the refreshed baselines from fix/master-green-2100 (933444f) so only this branch's own growth needs accounting.

Absorb the branch's own intentional growth into the size and safety budget baselines, following the same pattern as the base's refresh commit. Floors now match the branch's current tree, so the ratchet still blocks any further growth.

alecuba16 · 2026-11-08T23:00:17Z

Rebased onto a green master baseline and refreshed the four ratchet budgets (code size, test size, panic, swallowed error) to match the files this branch actually grows, as two chore commits on the tip. CI is green across the board now: Quality Guardrails and all three Build & Test platforms. Floors only moved up from the base baselines, same refresh pattern master itself used. Ready for review.

greptile-apps Bot reviewed Oct 13, 2026

View reviewed changes

alecuba16 force-pushed the feature/decision-suggestions branch from e25693e to 65bfc9a Compare October 13, 2026 01:43

greptile-apps Bot reviewed Oct 13, 2026

View reviewed changes

Comment thread crates/jcode-tui/src/tui/ui_inline.rs Resolved

Comment thread crates/jcode-tui/src/tui/app/commands.rs Resolved

Comment thread crates/jcode-tui/src/tui/app/decision.rs Resolved

alecuba16 force-pushed the feature/decision-suggestions branch from 65bfc9a to f99b7c8 Compare October 14, 2026 17:01

greptile-apps Bot reviewed Oct 14, 2026

View reviewed changes

Comment thread crates/jcode-tui/src/tui/app/remote/server_events.rs Resolved

Comment thread crates/jcode-tui/src/tui/app/remote/server_events.rs Resolved

Comment thread crates/jcode-tui/src/tui/ui_inline.rs Resolved

alecuba16 force-pushed the feature/decision-suggestions branch from f99b7c8 to 554d0fd Compare October 14, 2026 20:08

greptile-apps Bot reviewed Oct 14, 2026

View reviewed changes

Comment thread crates/jcode-tui/src/tui/ui_inline.rs Resolved

alecuba16 force-pushed the feature/decision-suggestions branch from 554d0fd to 45df0a2 Compare October 14, 2026 21:17

alecuba16 mentioned this pull request Oct 14, 2026

CI red on master: cargo audit fails with 9 advisories (quinn-proto, rustls, brotli, unmaintained crates) #1838

Closed

alecuba16 force-pushed the feature/decision-suggestions branch 2 times, most recently from 699e6f6 to 9a54462 Compare October 16, 2026 07:37

greptile-apps Bot reviewed Oct 16, 2026

View reviewed changes

Comment thread crates/jcode-tui/src/tui/app/commands.rs Resolved

Comment thread crates/jcode-app-core/src/server/client_lifecycle.rs Resolved

Comment thread crates/jcode-app-core/src/server/client_lifecycle.rs Resolved

alecuba16 force-pushed the feature/decision-suggestions branch 2 times, most recently from e1a8911 to 280a33b Compare October 17, 2026 17:20

greptile-apps Bot reviewed Oct 17, 2026

View reviewed changes

Comment thread crates/jcode-tui/src/tui/app/file_mention.rs Resolved

Comment thread crates/jcode-tui/src/tui/app/state_ui_input_helpers.rs Resolved

Comment thread crates/jcode-tui/src/tui/app/state_ui_input_helpers.rs Resolved

alecuba16 force-pushed the feature/decision-suggestions branch from 280a33b to 6b65d6c Compare October 18, 2026 00:31

greptile-apps Bot reviewed Oct 18, 2026

View reviewed changes

Comment thread crates/jcode-app-core/src/server/client_lifecycle.rs Resolved

alecuba16 force-pushed the feature/decision-suggestions branch from 9b58ed3 to 292bce4 Compare October 18, 2026 08:15

greptile-apps Bot reviewed Oct 18, 2026

View reviewed changes

Comment thread crates/jcode-tui/src/tui/ui_inline.rs Resolved

alecuba16 force-pushed the feature/decision-suggestions branch from 773f636 to 49590fa Compare October 19, 2026 19:43

greptile-apps Bot reviewed Oct 19, 2026

View reviewed changes

Comment thread crates/jcode-tui/src/tui/app/commands_tests.rs Resolved

alecuba16 force-pushed the feature/decision-suggestions branch from 49590fa to 09eeeae Compare October 20, 2026 05:24

greptile-apps Bot reviewed Oct 20, 2026

View reviewed changes

Comment thread scripts/test_size_budget.json Resolved

alecuba16 force-pushed the feature/decision-suggestions branch from 09eeeae to 7278c69 Compare October 20, 2026 14:45

greptile-apps Bot reviewed Oct 20, 2026

View reviewed changes

Comment thread crates/jcode-tui/src/tui/app/remote/key_handling.rs Resolved

alecuba16 force-pushed the feature/decision-suggestions branch 4 times, most recently from 8ae5518 to 134d581 Compare October 21, 2026 22:29

alecuba16 force-pushed the feature/decision-suggestions branch from db2068f to 5069f18 Compare November 2, 2026 19:01

greptile-apps Bot reviewed Nov 2, 2026

View reviewed changes

alecuba16 force-pushed the feature/decision-suggestions branch 2 times, most recently from 23d289c to 3ad6c7d Compare November 3, 2026 00:06

greptile-apps Bot reviewed Nov 3, 2026

View reviewed changes

alecuba16 force-pushed the feature/decision-suggestions branch 3 times, most recently from aca9690 to 481dff2 Compare November 3, 2026 16:30

greptile-apps Bot reviewed Nov 3, 2026

View reviewed changes

alecuba16 force-pushed the feature/decision-suggestions branch from 481dff2 to f3229b9 Compare November 4, 2026 07:37

greptile-apps Bot reviewed Nov 4, 2026

View reviewed changes

alecuba16 force-pushed the feature/decision-suggestions branch 3 times, most recently from 9a8716d to 872aa0a Compare November 8, 2026 08:25

alecuba16 added 12 commits November 8, 2026 15:32

fix: pass mutable winsize pointer to openpty in pty tests

d7d5954

libc 0.2.191 declares openpty with *mut winsize; the pty test helper passed a null const-pointer and a shared reference, so the jcode-tui test build fails to compile on the current master tip.

feat(decisions): ask_user tool with inline TUI chooser and selected-o…

2b6b2b4

…ption display

alecuba16 force-pushed the feature/decision-suggestions branch from 872aa0a to 2b6b2b4 Compare November 8, 2026 18:28

alecuba16 added 2 commits November 8, 2026 21:02

chore(budgets): align ratchet baselines with green base

7a3df1d

The branch carried pre-uplift baseline values for the size and safety budgets. Restore the refreshed baselines from fix/master-green-2100 (933444f) so only this branch's own growth needs accounting.

Conversation

alecuba16 commented Oct 13, 2026

Uh oh!

greptile-apps Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Diagram

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

alecuba16 Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

alecuba16 commented Nov 8, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

greptile-apps Bot commented Oct 13, 2026 •

edited

Loading